Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Merged #2246 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2246#event-3255460426___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Hi, I did some fixes. Could you please check them. Thanks! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2246#issuecomment-617065971___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

@alexyosifov pushed 1 commit. 58d289c00c2f43806d84f936d4fc0e25d47ac2e2 ims_registrar_scscf: fix multiple contacts in NOTIFY -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Hi, I just tested my change and reginfo enabled in PCSCF configuration. I got the same result as you. But the problem is that without my change there is an issue with the NOTIFY sent to the UE. If there are two or more contacts (for example after re-registration) the NOTIFY sent to the UE

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Hi, thank you for the quick response! And see the problem right now but be honest with you - in our test lab we never met this behavior of the P-CSCF. The P-CSCF sends SUBSCRIBE generated from itself (with Contact: and Call-ID 7fb844aa6636e93a-173@192.168.178.92) and there is a problem with my

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

> Looks fine to me, you can merge. > > Just a note for the archive - would probably make sense to review static int > handle_ruri_alias(struct sip_msg *msg) in nathelper.c, which does a kind of > similar function internally like the new added extract_alias_ip_port, to see > if this could be

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Sorry for the delay. Due to the Corona virus, the access to the Lab is a limited. In fact, it's good business for our Lab-Network vendors, as we had to replicate the Lab to various colleagues at home... ;-) However, the result of testing is exactly as expected. This is the NOTIFY for the

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

@ngvoice, Hi, Any update with the local tests? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2246#issuecomment-610357341___ Kamailio (SER) - Development

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

@ngvoice - do you managed to do the local tests, any update? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2246#issuecomment-602623773___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Hi, Unfortunately not. I will test this locally and comment on this afterwards if my assumption was correct or wrong. Thanks, Carsten Henning Westerholt schrieb am Fr., 13. März 2020, 09:05: > @ngvoice does this adress your concerns? If > not, probably make sense

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

@ngvoice does this adress your concerns? If not, probably make sense to discuss e.g. on the list with @alexyosifov all the details and then update this ticket with the outcome. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Hi, Yes, that's right. But the AS or P-CSCF will get a NOTIFY without content, as it never matches... Thanks, Carsten Александър Йосифов schrieb am Do., 12. März 2020, 18:14: > Hi all, > The changes will affect only the content of the NOTIFY message. The > procedure after reception of

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Hi all, The changes will affect only the content of the NOTIFY message. The procedure after reception of SUBSCRIBE is not affected. On Thu, 12 Mar 2020, 18:45 ng-voice GmbH, wrote: > Question: > If the Proxy-CSCF (or any other AS) sends a subscribe and expects a > NOTIFY, then the condition

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Question: If the Proxy-CSCF (or any other AS) sends a subscribe and expects a NOTIFY, then the condition would never be true, right? This should be adressed in my opinion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

Looks fine to me, you can merge. Just a note for the archive - would probably make sense to review static int handle_ruri_alias(struct sip_msg *msg) in nathelper.c, which does a kind of similar function internally like the new added extract_alias_ip_port, to see if this could be generalized

[sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

- Prevent multiple contacts for NOTIFY message in Message body registration tag after RE-REGISTRATION procedure. !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md