Merged #1609.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1609#event-1766405730___
Kamailio (SER) - Development Mailing List
Ok to backport.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1609#issuecomment-409746955___
Kamailio (SER) - Development Mailing List
this is causing problems in some `production` servers and i would like to
backport to stable branches if that's ok
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@miconda yes it was, the callback of the notify deletes the subscription. it
actually is required because in the case where we have `fetch_rows=500` and the
entire result set is `5000` rows then we would loose `4500` rows because they
would be deleted.
--
You are receiving this because you
If the removal of the delete at the end was tested properly without side
effects, I am fine to merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files
