Re: [sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-05 Thread Victor Seva
Merged #2162 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2162#event-2858901642___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-05 Thread Henning Westerholt
I like "what to skip" more, in the end most people would probably use it on smaller installations. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-05 Thread Daniel-Constantin Mierla
@linuxmaniac - yes, but can be also the opposite condition: what to skip. What people find better. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-05 Thread Victor Seva
@miconda something like `modparam("registrar", "xavp_rcd_mask", 0)` so we can define what to load? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-05 Thread Daniel-Constantin Mierla
I am fine to merge, but probably we should add in short term a new parameter to control what attributes are cloned in xavp, some of them can be large in size like, path with couple of hops, and maybe not needed in specific cases. -- You are receiving this because you are subscribed to this

Re: [sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-05 Thread Henning Westerholt
This is a small change and a good extension, I think it is fine to merge it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] registrar: add path value to xavp_rcd (#2162)

2019-12-02 Thread Victor Seva
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing