Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Ilya Shipitsin
@miconda  - yes, I noticed .github subfolder a bit later. I was somewhat 
surprized "why do they point me to contribution guide in such weird way", I was 
ok to see contribution guide during PR process (and I meant that exactly)

sorry for that.

thank you for pushing the patch anyway

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311698005___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Daniel-Constantin Mierla
@chipitsine - if you have read the block post you pointed above, you would see 
the reference to .github/ subfolder, and CONTRIBUTING.md file is already there, 
with section for commit message:

  * 
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format

I will push the patch manually.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311681684___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Daniel-Constantin Mierla
Closed #1169.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#event-1142504734___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Victor Seva
Please read 
https://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311631303___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev