On 19 Feb 2015, at 02:59, Luis Azedo l...@2600hz.com wrote:
but are we ready to accept sip...@abcd.com == sip:1...@abcd.com ?
The domain part is always case insensitive. AbCd.COM == abCD.cOm
User names are not case insensitive. ALICE != Alice
I think we have a setting to make it case
Module: kamailio
Branch: master
Commit: 3be5902a697caca2dd70fae2e17a1e0acb87c089
URL:
https://github.com/kamailio/kamailio/commit/3be5902a697caca2dd70fae2e17a1e0acb87c089
Author: Daniel-Constantin Mierla mico...@gmail.com
Committer: Daniel-Constantin Mierla mico...@gmail.com
Date:
Module: kamailio
Branch: master
Commit: 1dbcc93952db87fb158886b05b03f82626ff933c
URL:
https://github.com/kamailio/kamailio/commit/1dbcc93952db87fb158886b05b03f82626ff933c
Author: tsearle tsea...@gmail.com
Committer: tsearle tsea...@gmail.com
Date: 2015-02-19T10:24:43+01:00
Merge pull request
Merged #93.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/93#event-238246839___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Module: kamailio
Branch: master
Commit: b81dff6abab6d8c25892f28db0e663653daa6c2c
URL:
https://github.com/kamailio/kamailio/commit/b81dff6abab6d8c25892f28db0e663653daa6c2c
Author: Daniel-Constantin Mierla mico...@gmail.com
Committer: Daniel-Constantin Mierla mico...@gmail.com
Date:
Module: kamailio
Branch: master
Commit: 2df98c7afdc7ef574124912de01a5fd66f7aa6bb
URL:
https://github.com/kamailio/kamailio/commit/2df98c7afdc7ef574124912de01a5fd66f7aa6bb
Author: Daniel-Constantin Mierla mico...@gmail.com
Committer: Daniel-Constantin Mierla mico...@gmail.com
Date:
Module: kamailio
Branch: master
Commit: 30460e263b9b5492872f1f1437fefdfbba69f92b
URL:
https://github.com/kamailio/kamailio/commit/30460e263b9b5492872f1f1437fefdfbba69f92b
Author: Daniel-Constantin Mierla mico...@gmail.com
Committer: Daniel-Constantin Mierla mico...@gmail.com
Date:
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/93
-- Commit Summary --
* add ability to modify BCI header
* modules/sipt: fix example values in documentation
-- File Changes --
M modules/sipt/README (61)
M
there are two params
match_flags as you proposed
1 - callid
2 - received
3 - contact
the registered() function check that flag, checks the values in xavp_cfg
and assigns the value to a temp vars, that are then compared against the
value in the record.
match_return_flags controls if the record
Patch applied with the fix, to be backported.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/88#issuecomment-75127351___
sr-dev mailing list
sr-dev@lists.sip-router.org
Closed #88.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/88#event-238659528___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Luis Azedo writes:
add param match_return_flags - bit mask
1 add contact xavp
in registered adds or sets into the transaction
in reg_fetch_contacts adds to plc structure
does this mean that a new xavp is created even if any of the new
features are not used? can you tell exactly how
lazedo writes:
added param sip_uri_match
0 - case sensitive (default)
1 - case insensitive
should it rather be called sip_uri_user_match?
i still don't feel comfortable in starting to bloat kamailio with
non-standard behavior. why don't you canonize uri user in config
script?
-- juha
---
Can be merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/31#issuecomment-75129139___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
The patches are ok, but before merging, the 'make install' commands must be
updated to change the paths in configs and kamctl based on PREFIX.
---
Reply to this email directly or view it on GitHub:
We are not on the same meaning of terms here. I refer to function parameter,
not module parameter. I want to do:
```
registered(location, $fu, 1)
```
in order to do registered() with call-id match. The new parameter can be int or
pv (see fixup_igp_null() and fixup_get_ivalue() helper functions)
i added a 3rd param to control if we search for override values for flags.
default is 0, don't search
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/91#issuecomment-75129897___
sr-dev mailing list
There are helper C functions for comparing the URI, used by:
*
http://kamailio.org/docs/modules/devel/modules/siputils.html#siputils.f.cmp_uri
Not sure how this strict uri matching can be made to work with db only mode...
but I guess that is a compromise.
---
Reply to this email directly or
i don't think i did, the flags are in params.
i added the extra search for override to give more flexibility.
i can put that flexibility param dependent.
On Thu, Feb 19, 2015 at 8:03 PM, Daniel-Constantin Mierla
notificati...@github.com wrote:
You misunderstood my proposal. I wanted a new
I don't see any new parameter to registered(...) function. Do I miss something?
Perhaps I can change (sometime during next days) the current call-id matching
to using a new flags param to registered() function and xavp. Then you can add
from there what you need extra.
---
Reply to this email
lazedo writes:
it acts on the sip uri not the user part of the sip uri.
and that exactly is the problem as we have tried to tell.
-- juha
---
Reply to this email directly or view it on GitHub:
Olle E. Johansson writes:
If the module are comparing domains with case sensitivity today,
that's a bug that needs to be fixed.
exactly. i also pointed this out earlier. if implemented, the new
function must operate on uri user only, but i would not prefer to add
this functionality at all as
Hey Daniel,
Received. will look into it!
On Thu Feb 19 2015 at 22:06:30 Daniel-Constantin Mierla
notificati...@github.com wrote:
Apparently it doesn't work to assign more than one developer -- i wanted
to ping the ims guys on this item.
—
Reply to this email directly or view it on
You misunderstood my proposal. I wanted a new parameter to the function:
registered(talble, uri, flags), because I want to avoid searching through xavps
if not needed. The parameter is read only if provided.
If I got right the patches, you search for the flags in xavp list.
---
Reply to this
Apparently it doesn't work to assign more than one developer -- i wanted to
ping the ims guys on this item.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/45#issuecomment-75125684___
sr-dev mailing list
Olle,
it acts on the sip uri not the user part of the sip uri.
On Thu, Feb 19, 2015 at 8:27 PM, juha-h notificati...@github.com wrote:
lazedo writes:
added param sip_uri_match
0 - case sensitive (default)
1 - case insensitive
should it rather be called sip_uri_user_match?
i still
Module: kamailio
Branch: master
Commit: 2597c31eca105084ecbce964791d3bf965b23fdc
URL:
https://github.com/kamailio/kamailio/commit/2597c31eca105084ecbce964791d3bf965b23fdc
Author: Daniel-Constantin Mierla mico...@gmail.com
Committer: Daniel-Constantin Mierla mico...@gmail.com
Date:
Module: kamailio
Branch: master
Commit: cd58d9eafc18edcc6a719d76cd1dbe252d88ae91
URL:
https://github.com/kamailio/kamailio/commit/cd58d9eafc18edcc6a719d76cd1dbe252d88ae91
Author: Olle E. Johansson o...@edvina.net
Committer: Olle E. Johansson o...@edvina.net
Date: 2015-02-06T22:38:17+01:00
Merged #71.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/71#event-238683430___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Yes, as I said the changes seemed minor - besides closing the open items
on the tracker, I was being mostly interested in getting end of line for
the LOG messages. I will merge it then.
Thanks,
Daniel
On 17/02/15 22:41, Robert Boisvert wrote:
Daniel,
I looked over the changes and they are
Can be merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/95#issuecomment-75132915___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
no, nothing is created if not configured.
current behavior is preserved
From: sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Juha Heinanen
[j...@tutpro.com]
Sent: Thursday, February 19, 2015 12:23 PM
To: Kamailio (SER) - Development Mailing List
Hi,
made this commit to the pull request.
i think it answers all questions, comments appreciated.
registrar - match changes
add param match_flags bit mask
1 callid
2 received
3 contact
add param match_return_flags - bit mask
1 add contact xavp
in registered adds or sets into the
I haven't seen any updates to the doc files - or did I miss them?
/O
On 19 Feb 2015, at 14:08, Luis Azedo l...@2600hz.com wrote:
Hi,
made this commit to the pull request.
i think it answers all questions, comments appreciated.
registrar - match changes
add param match_flags bit mask
Hi,
waiting on implementation comments, if accepted, will document before merge
From: sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of Olle E.
Johansson [o...@edvina.net]
Sent: Thursday, February 19, 2015 5:18 AM
To: Kamailio (SER) - Development Mailing
a typo here ?
+ {{su, (sizeof(sut)-1)}, /* */ should be sut ?
+ PVT_OTHER, pv_get_srcaddr_uri_full, 0,
+ 0, 0, 0, 0},
From: sr-dev [sr-dev-boun...@lists.sip-router.org] on behalf of
Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: a7f8ee271acca095fa6a7c2dddf0dcba62102efd
URL:
https://github.com/kamailio/kamailio/commit/a7f8ee271acca095fa6a7c2dddf0dcba62102efd
Author: Torrey Searle tsea...@gmail.com
Committer: Torrey Searle tsea...@gmail.com
Date: 2015-02-18T20:48:11+01:00
add
Module: kamailio
Branch: master
Commit: 059c9a33fd451b59b83f913f86a0843e2c5bbefa
URL:
https://github.com/kamailio/kamailio/commit/059c9a33fd451b59b83f913f86a0843e2c5bbefa
Author: Torrey Searle tsea...@gmail.com
Committer: Torrey Searle tsea...@gmail.com
Date: 2015-02-19T09:24:37+01:00
If the module are comparing domains with case sensitivity today, that's a bug
that needs to be fixed.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/94#issuecomment-75110709___
sr-dev mailing list
Module: kamailio
Branch: master
Commit: af59452ed6ab165e9554c2d814d778abd7441699
URL:
https://github.com/kamailio/kamailio/commit/af59452ed6ab165e9554c2d814d778abd7441699
Author: Victor Seva linuxman...@torreviejawireless.org
Committer: Victor Seva linuxman...@torreviejawireless.org
Date:
Module: kamailio
Branch: master
Commit: 486c069222462e4bc05da36b098062be941d672d
URL:
https://github.com/kamailio/kamailio/commit/486c069222462e4bc05da36b098062be941d672d
Author: Victor Seva linuxman...@torreviejawireless.org
Committer: Victor Seva linuxman...@torreviejawireless.org
Date:
Merged
wrong number on commit fixes :-(
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/31#issuecomment-7522___
sr-dev mailing list
sr-dev@lists.sip-router.org
Closed #31.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/31#event-238951081___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Module: kamailio
Branch: master
Commit: d5ac2a0b21c51f0759c16ff39e6d28e1bc8730d7
URL:
https://github.com/kamailio/kamailio/commit/d5ac2a0b21c51f0759c16ff39e6d28e1bc8730d7
Author: Camille Oudot camille.ou...@orange.com
Committer: Camille Oudot camille.ou...@orange.com
Date:
Can be merged and backported if needed.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/92#issuecomment-75100503___
sr-dev mailing list
sr-dev@lists.sip-router.org
added param sip_uri_match
0 - case sensitive (default)
1 - case insensitive
can be extended to a more compliant version, (sensitive user, insensitive
domain).
the parameter sets the function to call to match uris.
You can view, comment on, or merge this pull request online at:
Merged #92.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/92#event-238554677___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Module: kamailio
Branch: 4.2
Commit: 9524b3471802c09361fd290cf35b2d5096ac0767
URL:
https://github.com/kamailio/kamailio/commit/9524b3471802c09361fd290cf35b2d5096ac0767
Author: lazedo luis.az...@factorlusitano.com
Committer: Luis Azedo l...@2600hz.com
Date: 2015-02-19T17:52:06Z
db_text : missing
Are we still missing docs here?
Note that the param in registrar has another name. Since this is not about the
full SIP uri- i hope we always are case insensitive for domains - maybe a
better name would be sip_username_match
---
Reply to this email directly or view it on GitHub:
A per-TCP connection `lifetime` parameter is needed, to add a new
functionnality in the tcpops module: the ability to dynamically modify the
connection lifetime on a connection (e.g. raise the lifetime of a successfully
authenticated connection).
This requires modifications in the core:
-
yes, i know the docs are missing.
when is something other then a fix, i will gladly add the docs if the request
is accepted.
i hope we always are case insensitive for domains
this implementation acts on the full sip uri. it is open to add a 3rd option
that will take the full uri and matches
@miconda i believe this is it ?
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/91#issuecomment-75176709___
sr-dev mailing list
sr-dev@lists.sip-router.org
52 matches
Mail list logo
