[sr-dev] [kamailio/kamailio] Random collection of typo fixes (#840)

Also greped source tree for similar instances, no luck this time. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/840 -- Commit Summary -- * modules/nathelper: fix small typo in documentation * modules/sanity: fix small typo in

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

Ok, we check that. Thanks for the support. 2016-10-31 23:01 GMT+03:00 Daniel-Constantin Mierla < notificati...@github.com>: > I pushed a set of commits in master removing the valueint, relying on > valuedouble, plus some macros. > > I will think a bit more about backporting or making a dedicated

Re: [sr-dev] [kamailio/kamailio] ss7: Introduce the beginning of a ss7 module (#837)

Some remarks: * there are several places where I spotted 'sipcapture' as module name * each .c and .h file must have at a top the license text and copyright line * the documentation has to be written in xml docbook format, stored inside the doc/ subfolder of the module directory (like the

[sr-dev] git:master:3413f7ad: modules: readme files regenerated - permissions ...

Module: kamailio Branch: master Commit: 3413f7ad64e4b493e32379b05006e312be8a4006 URL: https://github.com/kamailio/kamailio/commit/3413f7ad64e4b493e32379b05006e312be8a4006 Author: Kamailio Dev Committer: Kamailio Dev Date:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

I pushed a set of commits in master removing the valueint, relying on valuedouble, plus some macros. I will think a bit more about backporting or making a dedicated fix for 4.4 branch. Testing and reporting back the results would be very appreciated. -- You are receiving this because you are

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

Closed #838. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/838#event-842493837___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] permissions: doc typo fixed (#839)

Merged #839. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/839#event-842490584___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:26c41e16: permissions: doc typo fixed

Module: kamailio Branch: master Commit: 26c41e16512f04b7d83d66432a78f277852a8664 URL: https://github.com/kamailio/kamailio/commit/26c41e16512f04b7d83d66432a78f277852a8664 Author: albertollamaso Committer: albertollamaso Date:

[sr-dev] git:master:616ece6d: Merge pull request #839 from albertollamaso/master

Module: kamailio Branch: master Commit: 616ece6db2438f1a3e0f516017550ada92bac7a9 URL: https://github.com/kamailio/kamailio/commit/616ece6db2438f1a3e0f516017550ada92bac7a9 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2016-10-31T20:59:12+01:00

[sr-dev] git:master:114ec80c: htable: switched to json macros for numbers in dmq operations

Module: kamailio Branch: master Commit: 114ec80c58f06c876fc76d884b73095c5dcc8bff URL: https://github.com/kamailio/kamailio/commit/114ec80c58f06c876fc76d884b73095c5dcc8bff Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:3ab5a9e5: dialog: fixed conditions for dmq addition

Module: kamailio Branch: master Commit: 3ab5a9e51f2ed4d50a2382dc4a42ece4ff2597e1 URL: https://github.com/kamailio/kamailio/commit/3ab5a9e51f2ed4d50a2382dc4a42ece4ff2597e1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:ecd22245: lib/srutils: removed valueint field from json struct

Module: kamailio Branch: master Commit: ecd22245336f2d3d6d2f9404ebfdd4369f19bd97 URL: https://github.com/kamailio/kamailio/commit/ecd22245336f2d3d6d2f9404ebfdd4369f19bd97 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:b8d6b99a: rtjson: use json macros to retrieve int values

Module: kamailio Branch: master Commit: b8d6b99a36e57b65f7b7d9fba321e2088032178b URL: https://github.com/kamailio/kamailio/commit/b8d6b99a36e57b65f7b7d9fba321e2088032178b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:2853500c: jsonrpc-s: switched to use json helper macros for numbers

Module: kamailio Branch: master Commit: 2853500cc73a5dfc66654e6f3555c1c40e072817 URL: https://github.com/kamailio/kamailio/commit/2853500cc73a5dfc66654e6f3555c1c40e072817 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:f68f0864: dmq_usrloc: use usigned int for contact info values

Module: kamailio Branch: master Commit: f68f0864c77e8556e48db4d5681ba8dc3ea06f62 URL: https://github.com/kamailio/kamailio/commit/f68f0864c77e8556e48db4d5681ba8dc3ea06f62 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:d7653eb9: dialog: converted to use json helper macros for dlg profile

Module: kamailio Branch: master Commit: d7653eb9e7e6ffe21988f2a616deae0c01083c57 URL: https://github.com/kamailio/kamailio/commit/d7653eb9e7e6ffe21988f2a616deae0c01083c57 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:2c226646: lib/srutils: srjson - init number value for null, true and false

Module: kamailio Branch: master Commit: 2c22664610de2a007bbb881fead5640048ed24ba URL: https://github.com/kamailio/kamailio/commit/2c22664610de2a007bbb881fead5640048ed24ba Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:c5681600: ndb_redis: get the srv structure after checking parameter sanity

Module: kamailio Branch: master Commit: c5681600a5fdd650a4830e77aca2b4804766ccfa URL: https://github.com/kamailio/kamailio/commit/c5681600a5fdd650a4830e77aca2b4804766ccfa Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

I think the valueint should be removed and add some helper macros to get the int/unsigned int/long/whatever number/... out of the double val. It should be more sane for the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

Closed #833. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/833#event-841925963___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

it's working thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/833#issuecomment-257299936___ sr-dev mailing list

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

I pushed a patch for it, hopefully it's going to catch the situation and throw some warnings in the logs, instead of breaking the sip message. I am closing this one, but some testing would be very appreciated and if all ok, then I will backport. -- You are receiving this because you are

[sr-dev] git:master:49dd3315: uac: safety check for new uri to include only printable characters

Module: kamailio Branch: master Commit: 49dd3315b7298addeaa85dd1628cd0a25ddef5b1 URL: https://github.com/kamailio/kamailio/commit/49dd3315b7298addeaa85dd1628cd0a25ddef5b1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:00571fd1: uac: coherent indentation of code for replace from/to values

Module: kamailio Branch: master Commit: 00571fd1d07edbfb5950ca6786e898ecbc0b33f5 URL: https://github.com/kamailio/kamailio/commit/00571fd1d07edbfb5950ca6786e898ecbc0b33f5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

srjson_t *srjson_CreateNumber(srjson_doc_t *doc, double num) { srjson_t *item = srjson_New_Item(doc); if (item) { item->type = srjson_Number; item->valuedouble = num; // <-- here is correct value item->valueint = (int) num; // <--

[sr-dev] [kamailio/kamailio] permissions: doc typo fixed (#839)

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/839 -- Commit Summary -- * permissions: doc typo fixed -- File Changes -- M modules/permissions/doc/permissions_admin.xml (2) -- Patch Links --

[sr-dev] git:master:1a2918e2: core: parse addr spec - removed old style log message prefixes

Module: kamailio Branch: master Commit: 1a2918e2d962e2a61a8c185974e49fe9cc09c631 URL: https://github.com/kamailio/kamailio/commit/1a2918e2d962e2a61a8c185974e49fe9cc09c631 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

So you say that both fields valueint and valuedouble are set in this case and you can read any of them? I expected that double is set only for numbers with a dot (floating point type). On the other hand, the int and unsigned int have the same size. Doing a cast should work. -- You are

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

Yes, the auto mode needs a safety check fix, so it doesn't break the messages. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

@miconda Changing 'valueint' to 'valuedouble' need because 'valueint' has 'int' type and 'methods' are sometimes not fit into them when we obtain json message. But it fits in 'valuedouble' which has type 'double' and also been set on parse. Situation: when client supports all methods we got

[sr-dev] git:master:7c43359e: core: parser - use square brakets for log messages of addr-spec parsing

Module: kamailio Branch: master Commit: 7c43359e3c2ebe9aab8a69717225f83737d18345 URL: https://github.com/kamailio/kamailio/commit/7c43359e3c2ebe9aab8a69717225f83737d18345 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

for our setup it's working with restore mode manually. I'll test the other call scenarios if we need to restore the From header some where. thanks for the hint! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

ok, i'll try that. But should it work with the auto mode? I would say even if i have auto mode the Bye From header should not be destroyed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

If you change for the initial invite and the restore mode is auto, then it will be changed for all requests within the dialog, including the bye. You can change the restore mode parameter for uac module. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [sr-dev] [kamailio/kamailio] uac rewrites from user with non valid string (#833)

Hi, maybe one more hint, we do not change the FROM Header on intention. According config the Bye gets routet by our loose_route which only makes some xlog, rtpengine stuff and t_relay. We du not use any uac_rewrite mechanism. maybe we are doing something wrong, but i cannot find anything we

Re: [sr-dev] [kamailio/kamailio] Presence: Fix startup inconsistency in presentity hash table (#809)

If none else has comments, probably I will merge this patch in the next few days. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: fix variable type mismatch (#838)

I understand the need of changing local var methods to unsigned int, but why it needs to take the value from the double val field in the json? Is it printed in json as a floating point type? ``` - methods = it->valueint; + methods = it->valuedouble;