```
CC (clang38) [M ims_dialog.so] dlg_hash.o
dlg_hash.c:674:37: warning: equality comparison with extraneous parentheses
[-Wparentheses-equality]
if ((d_entry_out->first == d_entry_out->last)) {
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
dlg_hash.c:674:37: note: remove extraneous parentheses around the comparison to
silence this warning
if ((d_entry_out->first == d_entry_out->last)) {
~ ^ ~
dlg_hash.c:674:37: note: use '=' to turn this equality comparison into an
assignment
if ((d_entry_out->first == d_entry_out->last)) {
^~
=
CC (clang38) [M ims_qos.so] rx_avp.o
rx_avp.c:492:16: warning: comparison of unsigned expression >= 0 is always true
[-Wtautological-compare]
if (bandwidth >= 0) {
~~~~~~~~~ ^ ~
rx_avp.c:504:16: warning: comparison of unsigned expression >= 0 is always true
[-Wtautological-compare]
if (bandwidth >= 0) {
~~~~~~~~~ ^ ~
CC (clang38) [M ims_registrar_scscf.so] save.o
save.c:114:21: warning: comparison of unsigned expression >= 0 is always true
[-Wtautological-compare]
if (expires_hdr >= 0)
~~~~~~~~~~~ ^ ~
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/637
-- Commit Summary --
* modules/ims_auth lib/ims: use header type instead of header flag
* modules/ims_qos modules/ims_registrar_scscf: fix comparison of unsigned
expression
* modules/ims_dialog: fix clang warning -Wparentheses-equality
-- File Changes --
M lib/ims/ims_getters.c (6)
M modules/ims_auth/utils.c (4)
M modules/ims_dialog/dlg_hash.c (2)
M modules/ims_qos/rx_avp.c (4)
M modules/ims_registrar_scscf/save.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/637.patch
https://github.com/kamailio/kamailio/pull/637.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/637
_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
