Re: [sr-dev] [kamailio/kamailio] lib/binrpc modules/ctl utils/kamcmd : set UNIX_PATH_MAX to lowest common value (#589)

2016-04-28 Thread Daniel-Constantin Mierla
Thanks for patch and pointers, helped to clarify. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/589#issuecomment-215550652___ sr-dev

Re: [sr-dev] [kamailio/kamailio] lib/binrpc modules/ctl utils/kamcmd : set UNIX_PATH_MAX to lowest common value (#589)

2016-04-28 Thread Daniel-Constantin Mierla
Merged #589. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/589#event-644844791___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] lib/binrpc modules/ctl utils/kamcmd : set UNIX_PATH_MAX to lowest common value (#589)

2016-04-28 Thread Mikko Lehto
UNIX_PATH_MAX is used to validate string length before memcpy() to sun_path. https://github.com/kamailio/kamailio/blob/master/lib/binrpc/binrpc_api.c#L148 https://github.com/kamailio/kamailio/blob/master/modules/ctl/init_socks.c#L94

Re: [sr-dev] [kamailio/kamailio] lib/binrpc modules/ctl utils/kamcmd : set UNIX_PATH_MAX to lowest common value (#589)

2016-04-28 Thread Daniel-Constantin Mierla
Why the lowest and not the highest? Is it used for buffers where the values are copied? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] lib/binrpc modules/ctl utils/kamcmd : set UNIX_PATH_MAX to lowest common value (#589)

2016-04-28 Thread Mikko Lehto
sockaddr_un.sun_path[] seem to be either 104 or 108 in following Unices: 104 - NetBSD, OpenBSD, FreeBSD, DragonFly BSD, MINIX, XNU(Apple OS X) 108 - illumos, Solaris, Linux You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/589 -- Commit