[sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Juha Heinanen
i have now narrowed the problem down a bit: presence server sends notifies over tcp without problems in this version: author Daniel-Constantin Mierla mico...@gmail.com Wed, 20 Feb 2013 10:29:06 + (11:29 +0100) committer Daniel-Constantin Mierla mico...@gmail.com Wed, 20 Feb

[sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Juha Heinanen
does this make sense in t_msgbuilder.h: #define MAXFWD_VALUE 70 #define MAXFWD_HEADER Max-Forwards: MAXFWD_VALUE CRLF #define MAXFWD_HEADER_LEN (sizeof(MAXFWD_HEADER) - 1) what is that -1 leaving CR and removing LF from the length? -- juha ___

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Daniel-Constantin Mierla
Hello, that should be ok, I will push a patch soon, it is related to the fact the maxfwd header is added by presence module in this case. Cheers, Daniel On 3/11/13 9:04 AM, Juha Heinanen wrote: does this make sense in t_msgbuilder.h: #define MAXFWD_VALUE 70 #define MAXFWD_HEADER

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Daniel-Constantin Mierla
Try with latest master or 4.0 branch and let me know if it is ok now. Btw, to be more clear, the -1in sizeof() is removing ending '\0' from the defined buffer. Thanks, Daniel On 3/11/13 9:26 AM, Daniel-Constantin Mierla wrote: Hello, that should be ok, I will push a patch soon, it is

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Daniel-Constantin Mierla
On 3/11/13 9:36 AM, Juha Heinanen wrote: Daniel-Constantin Mierla writes: Try with latest master or 4.0 branch and let me know if it is ok now. i'm building new package right now and will tell soon if is works. Btw, to be more clear, the -1in sizeof() is removing ending '\0' from the

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Juha Heinanen
Daniel-Constantin Mierla writes: hmm, what you mean?!? it is what it says, the length of max forward define, it is not the size of the buffer that stores it. daniel, i apologize my message. i was stressed when i found a major problem in code that was to be release the same day. also, i was

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Juha Heinanen
Juha Heinanen writes: looks like i was the only one that had tried presence in 4.0. olle, did you do any presence tests in the sipping event or is sip presence dead? -- juha ___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Daniel-Constantin Mierla
On 3/11/13 10:30 AM, Juha Heinanen wrote: Daniel-Constantin Mierla writes: that should be ok, I will push a patch soon, it is related to the fact the maxfwd header is added by presence module in this case. after the patch, notify from presence server works in 4.0. thanks. looks like i was

Re: [sr-dev] presence notify packet garbage with latest 4.0

2013-03-11 Thread Olle E. Johansson
11 mar 2013 kl. 10:37 skrev Juha Heinanen j...@tutpro.com: Juha Heinanen writes: looks like i was the only one that had tried presence in 4.0. olle, did you do any presence tests in the sipping event or is sip presence dead? I don't think it's dead, but we did not do any tests at

[sr-dev] presence notify packet garbage with latest 4.0

2013-03-10 Thread Juha Heinanen
i tested my presence server using the latest 4.0 branch and noticed that some notify requests generated by presence server over tcp cannot be interpreted by my sip proxy. here is working example using version 4.0.0-pre1 when presence server is sending notify request to sip proxy over tcp to port