Re: [sr-dev] [kamailio/kamailio] having keep-alive response count before ending the dialog (#438)

2018-02-12 Thread Daniel-Constantin Mierla
Closed #438. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/438#event-1469052834___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

2018-02-12 Thread Vasiliy Ganchev
Hi, Daniel! thanks for the patch! will give it a try today -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Emmanuel BUU
Hi Daniel, I reviewed the code and unfortunately, it does not cover the case when - enable_double_rr=1 - both UA are using the same IP and the same port and there is only one route inserted by record_route() To handle this case, see the patch I suggest below. Alternatively, we could set

[sr-dev] git:master:76b40abd: presence: check if all related dialog states are terminated

2018-02-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 76b40abd6534a5af0164601e48e525b9a5915930 URL: https://github.com/kamailio/kamailio/commit/76b40abd6534a5af0164601e48e525b9a5915930 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] redis support into usrloc (#1137)

2018-02-12 Thread Daniel-Constantin Mierla
I am closing this one here, having two pull requests related to it, discussions can be continue there. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
Did you just review the code or you also tested it? It covers the cases when enable_double_rr is 1 (or different than 0) and there is no second Route header. Because if there is a second route, then the socket is forced later to the outgoing socket. -- You are receiving this because you are

[sr-dev] git:master:92451536: presence: return on having a full match on states in xml document

2018-02-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 92451536a0ef985ff1d16c5531c232cd657532e1 URL: https://github.com/kamailio/kamailio/commit/92451536a0ef985ff1d16c5531c232cd657532e1 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

2018-02-12 Thread Daniel-Constantin Mierla
@vance-od - I tried a quick fix with the patches referenced above. Can you try with them and see if all ok? It relies on matching all related dialog states in the same xml document. If one found mismatching, then will not consider it terminated. Likely it can be improved with matching on

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
OK, let's see the results, because it should work for single Route header, that was the purpose of the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Emmanuel BUU
No I did not test it. I will. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-364925128___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

2018-02-12 Thread Vasiliy Ganchev
I tried proposed changes. in ps_match_dialog_state_from_body there is a loop: while(node != NULL) { why do we need there one more while loop? What actually happens: . if(strcmp(tmp_state, vstate)!=0) { // here we come only once, when matching first dialog ... all later dialogs are

[sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)

2018-02-12 Thread Julien Chavanton
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README

Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)

2018-02-12 Thread Julien Chavanton
I wonder what is the problem with the CI build, looking at the logs last thing done was building, and then nothing. ``` CC (clang) [M evrexec.so] evrexec_mod.o LD (clang) [M evrexec.so] evrexec.so ``` -- You are receiving this because you are subscribed to this

Re: [sr-dev] [kamailio/kamailio] Crash on receiving incorrect REGISTER request? (#1420)

2018-02-12 Thread Daniel-Constantin Mierla
@kbdfck - if you get the coredump, the sip message will be inside it. Having the backtrace from corefile with gdb is important here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)

2018-02-12 Thread Julien Chavanton
@jchavanton pushed 1 commit. 6b8fccd acc: Makefile test -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1437/files/8e15a950002718b40293298737096d1c6682813e..6b8fccd2fa076d350d4f45ad959326b59c471720

[sr-dev] git:5.0:749dd5c5: rtpengine: get again body pointer only when read_sdp_pv is set

2018-02-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.0 Commit: 749dd5c55ed100e9a57ece18e82fab2d1eaaab8e URL: https://github.com/kamailio/kamailio/commit/749dd5c55ed100e9a57ece18e82fab2d1eaaab8e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] rtpengine: rtpengine_offer is stripping all INVITE multipart bodies except application/sdp (#1434)

2018-02-12 Thread Daniel-Constantin Mierla
Closed #1434. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1434#event-1468934502___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] rtpengine: rtpengine_offer is stripping all INVITE multipart bodies except application/sdp (#1434)

2018-02-12 Thread Daniel-Constantin Mierla
Thanks for testing and feedback! Patch backported. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1434#issuecomment-364850593___

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
Closed #1428. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#event-1468935219___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Thomas Carvello
Thank you for your time! One of our engineer is currently testing it. If we have any issue or comments ,we will come back to you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:be6a419a: topos: revert "topos: set uuid fields before checking contact/rr fields"

2018-02-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: be6a419a5b0d6fe3922219a30788ad527a313fd6 URL: https://github.com/kamailio/kamailio/commit/be6a419a5b0d6fe3922219a30788ad527a313fd6 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
Closing after the commit and remarks in the previous comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] topos 5.1.1 regression: missing Contact header in in-dialog requests despite record_route() having been executed for initial request (#1421)

2018-02-12 Thread Daniel-Constantin Mierla
I reverted 97532ca as per comment from @sergey-vb . It was done also in branch 5.1. Reopen if still an issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:5.1:cc638e4c: topos: revert "topos: set uuid fields before checking contact/rr fields"

2018-02-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.1 Commit: cc638e4cd6d6f4ff9aca0bf6c9d6c940a3e64e59 URL: https://github.com/kamailio/kamailio/commit/cc638e4cd6d6f4ff9aca0bf6c9d6c940a3e64e59 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] topos 5.1.1 regression: missing Contact header in in-dialog requests despite record_route() having been executed for initial request (#1421)

2018-02-12 Thread Daniel-Constantin Mierla
Closed #1421. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1421#event-1468948263___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

2018-02-12 Thread Vasiliy Ganchev
The result: for multiple dialog bodie only first body checked (I added custom logging inside your code to see where it worked) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:a0b6b3ab: tls: small updates to tls config

2018-02-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: a0b6b3abe1beab33e11a52ff601c9cc50f7e2d56 URL: https://github.com/kamailio/kamailio/commit/a0b6b3abe1beab33e11a52ff601c9cc50f7e2d56 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)

2018-02-12 Thread Daniel-Constantin Mierla
Thanks for the contribution! The option to enable features in a module with compile time defines is not preferred at all. We had in the past the RADIUS (and DIAMETER) accounting as part of acc and it was very inconvenient to maintain or package. The solution is to implement this as a new

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

2018-02-12 Thread Daniel-Constantin Mierla
What was the result of testing it? Not working? The `while()` is there to deal with xml docs that have many `dialog` nodes. The `do { ... } while ()` is to find the next node with `dialog` name. These are to be compliant with xml specs, as there can be other nodes with different names. So just