[sr-dev] [kamailio/kamailio] app_python: don't hide the real exception on load failure (#1471)

2018-03-02 Thread aalba6675
Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README

[sr-dev] git:master:829941d0: app_python3: don't hide the real exception on load failure

2018-03-02 Thread AnthonyA
Module: kamailio Branch: master Commit: 829941d0079cb7f46a20ec975252790fd17019ba URL: https://github.com/kamailio/kamailio/commit/829941d0079cb7f46a20ec975252790fd17019ba Author: AnthonyA Committer: AnthonyA Date: 2018-03-03T01:02:48+08:00

Re: [sr-dev] [kamailio/kamailio] app_python: don't hide the real exception on load failure (#1471)

2018-03-02 Thread Daniel-Constantin Mierla
Thanks! @aalba6675 you can commit directly to app_python as well, there is no other very active developer for the module. If you really want a review for your commit, then it is ok to do PR as well. Otherwise, from my point of view, you are more familiar with embedding python interpreter. --

Re: [sr-dev] [kamailio/kamailio] app_python: don't hide the real exception on load failure (#1471)

2018-03-02 Thread Daniel-Constantin Mierla
Merged #1471. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1471#event-1501889489___ Kamailio (SER) - Development Mailing List

[sr-dev] git:master:310c60cb: app_python: don't hide the real exception on load failure

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 310c60cb34641f73ac0e8b48c9bf68efa5fb3533 URL: https://github.com/kamailio/kamailio/commit/310c60cb34641f73ac0e8b48c9bf68efa5fb3533 Author: AnthonyA Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:045d4476: core: check return of dlsym() before dlerror() handling

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 045d44762ce7cd267e64849c1c138d45b1fa040f URL: https://github.com/kamailio/kamailio/commit/045d44762ce7cd267e64849c1c138d45b1fa040f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] cannot load app_perl (#1465)

2018-03-02 Thread Daniel-Constantin Mierla
Can you try with the patch referenced above? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1465#issuecomment-370126361___ Kamailio

Re: [sr-dev] [kamailio/kamailio] sqlops: sqlops_do_query - Make result parameter optional in C API (#1467)

2018-03-02 Thread Hugh Waite
sql_get_result does not currently check the 'name' parameter and will crash in core_case_hash if this is NULL. This is also true for sql_get_connection and sql_init_con. However, these three functions are only called from within the sqlops module. I will add a check to the C-API/KEMI wrapper

Re: [sr-dev] [kamailio/kamailio] sqlops: sqlops_do_query - Make result parameter optional in C API (#1467)

2018-03-02 Thread Hugh Waite
@que273 pushed 1 commit. 53e1326 sqlops: Add NULL parameter check to C/KEMI API functions -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] sqlops: sqlops_do_query - Make result parameter optional in C API (#1467)

2018-03-02 Thread henningw
Hello Hugh, thank you for the pull request. Wouldn't make sense to move the null check to the beginning of the function? Otherwise sql_get_result would call with a null before your check. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [sr-dev] [kamailio/kamailio] sqlops: sqlops_do_query - Make result parameter optional in C API (#1467)

2018-03-02 Thread henningw
Forget my previous comment - I think we should add a null check to sql_do_query as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:8926698e: modules: readme files regenerated - json ... [skip ci]

2018-03-02 Thread Kamailio Dev
Module: kamailio Branch: master Commit: 8926698e92675d712db318c335f30d4f43f1a53d URL: https://github.com/kamailio/kamailio/commit/8926698e92675d712db318c335f30d4f43f1a53d Author: Kamailio Dev Committer: Kamailio Dev Date:

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread Daniel-Constantin Mierla
@sergey-safarov thanks for prompt reaction and the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1464#issuecomment-369937426___

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread Daniel-Constantin Mierla
Closed #1464. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1464#event-1501265476___ Kamailio (SER) - Development Mailing List

[sr-dev] SIP header when 911 called

2018-03-02 Thread Abdul Basit
Hi Team, Does kamailio has compatibility with E911, i.e. through location in SIP header when 911 called? Is there any reference document? -- regards, abdul basit ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org

[sr-dev] [kamailio/kamailio] pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring … (#1470)

2018-03-02 Thread sergey-safarov
…rpm installation You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1470 -- Commit Summary -- * pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring rpm installation -- File Changes -- M pkg/kamailio/obs/kamailio.spec (2)

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring … (#1470)

2018-03-02 Thread sergey-safarov
This is cherry-pick 630a697cd928d01f92f4de1b232567c52592df04 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] cannot load app_perl (#1465)

2018-03-02 Thread sergey-safarov
Hello Daniel This is relevant log messages ``` 0(30) DEBUG: [core/cfg.y:1659]: yyparse(): loading module app_perl.so 0(30) DEBUG: [core/sr_module.c:575]: load_module(): trying to load 0(30) DEBUG: [core/sr_module.c:634]: load_module(): looking up exports with name: _app_perl_exports

[sr-dev] git:5.1:9b3aa0c7: pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring rpm installation

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.1 Commit: 9b3aa0c75bb2b4a643713c428d1a8a3d2d1c9e5c URL: https://github.com/kamailio/kamailio/commit/9b3aa0c75bb2b4a643713c428d1a8a3d2d1c9e5c Author: Sergey Safarov Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring … (#1470)

2018-03-02 Thread Daniel-Constantin Mierla
Merged #1470. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1470#event-1501318475___ Kamailio (SER) - Development Mailing List

[sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
### Description rtpengine module is hijacking the DTLS key rtpengine_manage("DTLS=off") DTLS=off is a valid command to rtpengine, but the module uses that flag to set transport as UDP/TLS/RTP/SAVP Unfortunately even though the transport can be fixed by RTP/SAVP, the lines outputted by

Re: [sr-dev] [kamailio/kamailio] rtpengine: added support for DTLS transports (#1460)

2018-03-02 Thread aalba6675
@rfuchs this commit has broken my use of `rtpengine_manage(DTLS=off)`. Now the key DTLS is not passed to rtpengine but hijacked to set transport. Without DTLS=off rtpengine adds two lines to SDP a=setup:actpass a=fingerprint:xxx This seems harmless, but FreeSWITCH

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread Daniel-Constantin Mierla
For which package specs? Debs, rpms? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1464#issuecomment-369890814___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
The following attempted workaround also fails: 1. don't use DTLS=off, force transport rtpengine_manage("ICE=remove transport-protocol=RTP/SAVP"); 2. rtpengine side use dtls-passive rtpengine --dtls-passive For some reason this also doesn't work, as rtpengine after rewritng SDP adds

Re: [sr-dev] [kamailio/kamailio] cannot load app_perl (#1465)

2018-03-02 Thread Daniel-Constantin Mierla
For some of the modules, the exports structure is named `_modname_exports` because of exporting with global scope and having naming conflicts. Can you get the logs with debug=3? Just to confirm, because it should show that it lookups the _app_perl_exports. -- You are receiving this because

Re: [sr-dev] [kamailio/kamailio] rtpengine: added support for DTLS transports (#1460)

2018-03-02 Thread Daniel-Constantin Mierla
@aalba6675 - do not comment in two places for the same issue, it is hard to track where the relevant information is written. As you opened a bug, comment there and reference the PR with #NUMBER . -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread udf2457
Well I am talking about systemd ;-) http://download.opensuse.org/repositories/home:/kamailio:/v5.1.x-rpms/CentOS_7/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread Daniel-Constantin Mierla
Well you were talking about systemd, that was clear, but there are also deb spec files and deb packages that include systemd options, it is not a single place and different people taking care of them. In this case, maybe @sergey-safarov can check and see what can be done. -- You are receiving

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread udf2457
@miconda Fair enough & thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1464#issuecomment-369892619___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
@rfuchs hoping you can take a look at this. The merge to master and backport to 5.1.2 has broken my use of rtpengine_manage("DTLS=off") since the DTLS key is removed from the ng-protocol messaged and not processed by rtpengine. It is needed specifically for FreeSWITCH in SDES (who for some

Re: [sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread Daniel-Constantin Mierla
It is a side effect of PR #1460. More specific, from mailing list discussion (https://lists.kamailio.org/pipermail/sr-users/2018-March/100539.html), the related change should be: ``` + else if (str_eq(, "DTLS")) +

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread sergey-safarov
Hello @udf2457 This folder `/var/run/kamailio` is created using [kamailio.tmpfiles](https://github.com/kamailio/kamailio/blob/master/pkg/kamailio/obs/kamailio.tmpfiles) config and command [systemd-tmpfiles --create

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread udf2457
The issue was noticed post-installation. `/var/run/kamalio` was non-existent. As for `/var/run` of course I meant `/var/run/kamailio` management. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread Daniel-Constantin Mierla
Thanks @rfuchs for the quick reaction! Otherwise, no worries, it's software! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
Yes, indeed - thanks for fixing it so fast. Much appreciated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] [kamailio/kamailio] pkg/kamailio/obs: Fixed kamailio tmpfiles creation … (#1469)

2018-03-02 Thread sergey-safarov
…durring rpm installation You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1469 -- Commit Summary -- * pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring rpm installation -- File Changes -- M

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread sergey-safarov
[PR to master](https://github.com/kamailio/kamailio/pull/1469/files) is created Later will create cherry-pick to 5.1 branch In short time 5.1.2 rpm packages will be re created. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

[sr-dev] git:master:630a697c: pkg/kamailio/obs: Fixed kamailio tmpfiles creation durring rpm installation

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 630a697cd928d01f92f4de1b232567c52592df04 URL: https://github.com/kamailio/kamailio/commit/630a697cd928d01f92f4de1b232567c52592df04 Author: Sergey Safarov Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:bff50c44: json: add new function json_get_string() to return string value without quotes

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: bff50c44e32c48b5449e405f67ca02f7d8055ba0 URL: https://github.com/kamailio/kamailio/commit/bff50c44e32c48b5449e405f67ca02f7d8055ba0 Author: Emmanuel Schmidbauer Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/obs: Fixed kamailio tmpfiles creation … (#1469)

2018-03-02 Thread Daniel-Constantin Mierla
Merged #1469. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1469#event-1501225132___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] json: add new function json_get_string() to return string value witho… (#1466)

2018-03-02 Thread Daniel-Constantin Mierla
Merged #1466. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1466#event-1501225890___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread sergey-safarov
RPM files is recreated. I tested and now issue fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1464#issuecomment-369935748___

Re: [sr-dev] [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread Richard Fuchs
Closed #1468 via 0d89dc5e3c4c06084af8aae03e9b705673289703. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1468#event-1501156028___

[sr-dev] git:master:0d89dc5e: rtpengine: allow dual usage of DTLS flag and DTLS= switch

2018-03-02 Thread Richard Fuchs
Module: kamailio Branch: master Commit: 0d89dc5e3c4c06084af8aae03e9b705673289703 URL: https://github.com/kamailio/kamailio/commit/0d89dc5e3c4c06084af8aae03e9b705673289703 Author: Richard Fuchs Committer: Richard Fuchs Date: 2018-03-02T08:34:55-05:00

[sr-dev] git:5.1:db971272: rtpengine: allow dual usage of DTLS flag and DTLS= switch

2018-03-02 Thread Richard Fuchs
Module: kamailio Branch: 5.1 Commit: db97127276fc116ef55874cc4b0171936ed50ff8 URL: https://github.com/kamailio/kamailio/commit/db97127276fc116ef55874cc4b0171936ed50ff8 Author: Richard Fuchs Committer: Richard Fuchs Date: 2018-03-02T08:41:44-05:00

Re: [sr-dev] [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread jerzyptak
First of all, I am sorry for crating this regression - I have clearly not fully appreciated how the fall through of flags in rtpengine module works. Using "DTLS" for declaring transport is just a shortcut for the log version UDP/TLS/RTP/SAVP, so removing it will not make much difference. --

[sr-dev] git:master:af6c1f70: pkg/kamailio/deb: kamailio.service fix for /run in tmpfs

2018-03-02 Thread Victor Seva
Module: kamailio Branch: master Commit: af6c1f709ad4343539a4e47c84ff94c2f237eb16 URL: https://github.com/kamailio/kamailio/commit/af6c1f709ad4343539a4e47c84ff94c2f237eb16 Author: Victor Seva Committer: Victor Seva Date:

Re: [sr-dev] [kamailio/kamailio] Add /var/run management to systemd script (#1464)

2018-03-02 Thread Victor Seva
https://salsa.debian.org/pkg-voip-team/kamailio/blob/master/debian/kamailio.service This is what I have in the Debian ``` # /var/run/kamailio in tmpfs RuntimeDirectory=kamailio RuntimeDirectoryMode=0750 ``` relevant info https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837678 -- You are

Re: [sr-dev] [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread Richard Fuchs
Ya sorry, my bad. I should have caught this when reviewing it. Will fix. I suggest "DTLS" alone as a switch to enable UDP/TLS transport, while DTLS=... as a flag would keep its old meaning. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

[sr-dev] git:master:9b7bb4ea: kamctl: fixed the name of rpc command for dialplan reload

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 9b7bb4ea6c100f5f33d2dddc9061febf33c47f5e URL: https://github.com/kamailio/kamailio/commit/9b7bb4ea6c100f5f33d2dddc9061febf33c47f5e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:5.1:4c840b7e: kamctl: fixed the name of rpc command for dialplan reload

2018-03-02 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.1 Commit: 4c840b7e9144e0540e97be5c9d3444b38a901a27 URL: https://github.com/kamailio/kamailio/commit/4c840b7e9144e0540e97be5c9d3444b38a901a27 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: