@eschmidbauer - my comment was to wait a few days before merging to see the
opinion of other developers, not to merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Module: kamailio
Branch: master
Commit: 626fbd002e4d569767e84a99a2163d0bd9ff6efd
URL:
https://github.com/kamailio/kamailio/commit/626fbd002e4d569767e84a99a2163d0bd9ff6efd
Author: Emmanuel Schmidbauer
Committer: GitHub
Date: 2020-07-03T13:26:13-04:00
Merge pull request #2389 from
Module: kamailio
Branch: master
Commit: 2802bd75cd03e16bf6541fde1d6459bda2698153
URL:
https://github.com/kamailio/kamailio/commit/2802bd75cd03e16bf6541fde1d6459bda2698153
Author: Emmanuel Schmidbauer
Committer: GitHub
Date: 2020-07-03T13:22:16-04:00
Revert "nathelper: add optional
Not really fixing it, because now set_contact_alias() from kemi require a
parameter always, so existing kemi deployement will be broken on upgrade. A new
function can be exported to kemi (e.g., set_contact_alias_trim()) and the old
one should stay the same. So practically a new wrapper function
Reverts kamailio/kamailio#2388
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2389
-- Commit Summary --
* Revert nathelper: add optional set_contact_alias([trim])
parameter
-- File Changes --
M src/core/dset.c (85)
M
@eschmidbauer pushed 1 commit.
988a666e85b01f52966e6cb28932efea1578e0cc nathelper: add optional
set_contact_alias([trim]) parameter
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@eschmidbauer pushed 1 commit.
3c02c11d66c95102698ee52187952bd98a51510c nathelper: add optional
set_contact_alias([trim]) parameter
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
reverted and resubmitted PR (https://github.com/kamailio/kamailio/pull/2390)
with update to address the LGTM scanner issue
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for
Merged #2389 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2389#event-3511678932___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: 6a637cf84906ec5315c77e5458180f7d9d69a481
URL:
https://github.com/kamailio/kamailio/commit/6a637cf84906ec5315c77e5458180f7d9d69a481
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-07-03T23:00:24+02:00
core: tcp - test
A fair amount of time should be allowed for comments, considering time zones,
traveling, etc ...
With the revert, I noticed that a new function was actually added to the core.
If wanted there, then it should have been a separate commit for it. We want
commits per components, so maintainers of
Module: kamailio
Branch: master
Commit: 9322a98cd451fa470c8ff93f85758f41c4fc6bce
URL:
https://github.com/kamailio/kamailio/commit/9322a98cd451fa470c8ff93f85758f41c4fc6bce
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2020-07-03T19:31:10+02:00
modules: readme files regenerated - nathelper
ive updated the new PR with 2 separate commits, one for core and one for the
module
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@eschmidbauer For a revert you can simply use "git revert" on command line or
git client, not necessary to create a pull request for this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@eschmidbauer pushed 1 commit.
adc58d15186c8ac1fd71f85b9844f72914946246 nathelper: add optional
set_contact_alias([trim]) parameter
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Apologies, I misunderstood. I can revert the commit
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2388#issuecomment-653627967___
There is also an issue reported by LGTM scanner: 'Local variable hides global
variable', see above comments from their bot.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Pretty much, I would only suggest to use `ki_` prefix for the kemi functions,
like the other wraperss which have a specific prefix for exports to kemi (e.g.,
the last three in the kemi exports structure).
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@miconda commented on this pull request.
> @@ -704,10 +707,12 @@ static int fix_nated_contact_f(struct sip_msg *msg,
> char *str1, char *str2)
* Replaces ip:port pair in the Contact: field with the source address
* of the packet.
*/
-static int set_contact_alias(struct sip_msg *msg)
@eschmidbauer pushed 1 commit.
95b7786489648e1b4690b823e0c1e52196d31a57 nathelper: add optional
set_contact_alias([trim]) parameter
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> Not really fixing it, because now set_contact_alias() from kemi require a
> parameter always, so existing kemi deployement will be broken on upgrade. A
> new function can be exported to kemi (e.g., set_contact_alias_trim()) and the
> old one should stay the same. So practically a new wrapper
@eschmidbauer commented on this pull request.
> @@ -704,10 +707,12 @@ static int fix_nated_contact_f(struct sip_msg *msg,
> char *str1, char *str2)
* Replaces ip:port pair in the Contact: field with the source address
* of the packet.
*/
-static int set_contact_alias(struct sip_msg *msg)
Do not forget that we have also the advanced (oob) and basic configs in
`misc/examples/pkg/`, which were supposed to be installed in the shared docs
(they were relocated from `etc/`, not sure we got to packaging them).
I am fine to add the systemd and prometeus to the advanced config, but for
Issue was fixed for me with: https://github.com/kamailio/kamailio/pull/2386
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks!
If nobody has anything against, this can be merged before branching 5.4 to fix
the situation of "strange" UA that take the alias from 200ok of REGISTER and
use it for subsequent requests.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
Merged #2386 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2386#event-3509947899___
Kamailio (SER) - Development Mailing
Given that Prometheus is becoming quite common as a timeseries backend, what do
you think about conditionally (#!ifdef) loading xhttp_prom module?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Module: kamailio
Branch: master
Commit: fbb4312f1b2ebf6793408241d56bfc2dca6543ec
URL:
https://github.com/kamailio/kamailio/commit/fbb4312f1b2ebf6793408241d56bfc2dca6543ec
Author: Daniel-Constantin Mierla
Committer: GitHub
Date: 2020-07-03T09:40:12+02:00
Merge pull request #2386 from
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2386#issuecomment-653402089___
Kamailio (SER) - Development Mailing List
Module: kamailio
Branch: master
Commit: d0d2c8fd6a57affac7bffab441b2126b9df0dfb1
URL:
https://github.com/kamailio/kamailio/commit/d0d2c8fd6a57affac7bffab441b2126b9df0dfb1
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-07-03T08:30:46+02:00
core: init timeval
Dear Kamailio Server’s Developers
I’m an user who trying to discovery supported features of Kamailio server (for
a client application that connect to server).
Thank you all for made a beautiful thing like Kamailio.
Could you guys please help to clear my some questions as below:
- If I make a
Module: kamailio
Branch: master
Commit: 0780e781c319254307c85bd873c58c6478a28da8
URL:
https://github.com/kamailio/kamailio/commit/0780e781c319254307c85bd873c58c6478a28da8
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-07-03T08:33:13+02:00
lib/srdb1: init
Closed #2382.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2382#event-3509986104___
Kamailio (SER) - Development Mailing List
fixed with
https://github.com/kamailio/kamailio/commit/fbb4312f1b2ebf6793408241d56bfc2dca6543ec
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Module: kamailio
Branch: master
Commit: fefb3f1b2dbae8d9df24fecee763c5a1cd588107
URL:
https://github.com/kamailio/kamailio/commit/fefb3f1b2dbae8d9df24fecee763c5a1cd588107
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-07-03T10:50:06+02:00
core: tcp - more
Module: kamailio
Branch: master
Commit: 339b94ce713b2a3d3763d2c15c8d1437362f648e
URL:
https://github.com/kamailio/kamailio/commit/339b94ce713b2a3d3763d2c15c8d1437362f648e
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2020-07-03T16:46:13+02:00
modules: readme files regenerated - nathelper
@miconda Regarding force_rport(), the point I was making was exactly that it
does NOT engage in REQINIT, even if WITH_NAT is enabled. For example, replies
to OPTIONS sent to kami will always be directed to address in first Via header
even for NATted devices, even with NAT support enabled in the
Module: kamailio
Branch: master
Commit: 67f9de8a946335e2bf16fe0e6063877cd4d51fb7
URL:
https://github.com/kamailio/kamailio/commit/67f9de8a946335e2bf16fe0e6063877cd4d51fb7
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-07-03T14:02:20+02:00
core: tcp - safety
@gedia - yes, I agreed with your remark about force_port(), if that was not
clear. The debug=4 was inherited from openser times when it was a valid value,
after merging core from SER project, the values shifted back with 1. Can be
changed now to 3 and 2.
--
You are receiving this because you
Merged #2388 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2388#event-3511266194___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: 07f2857f76870f9f0fd360c6990df8f7cb0f5ffc
URL:
https://github.com/kamailio/kamailio/commit/07f2857f76870f9f0fd360c6990df8f7cb0f5ffc
Author: Emmanuel Schmidbauer
Committer: GitHub
Date: 2020-07-03T10:32:25-04:00
Merge pull request #2388 from
Module: kamailio
Branch: master
Commit: f2544789283d7ffbeda019c8a3d96e833bf34cc9
URL:
https://github.com/kamailio/kamailio/commit/f2544789283d7ffbeda019c8a3d96e833bf34cc9
Author: Emmanuel Schmidbauer
Committer: Emmanuel Schmidbauer
Date: 2020-07-02T11:43:45-04:00
nathelper: add optional
43 matches
Mail list logo
