Hi, guys!
Pua module provides a callback "send_publish". One of the parameters is
"outbound_proxy", but pua_reginfo does not use it, even if the parameter is
specified.
Documentation says: "The outbound_proxy uri to be used when sending Subscribe
requests."
Any reason to use it only for SUBSCR
Closed #1176.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1176#event-1148196622___
Kamailio (SER) - Development Mailing List
sr-dev@lis
Hi again, duplicate of [previous
pull](https://github.com/kamailio/kamailio/pull/1176), as there is some mess.
Hope this time is better.
thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1177
-- Commit Summary --
* pua_regi
Thanks for accepting, next time I will try to prepare all the things thoroughly!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1177#issuecomment-312784554___
While preparing query_params, "useragent" was missed - add it.
As before User-Agent was never present in HTTP requests.
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files fo
@vance-od pushed 2 commits.
3136925 Revert "pua_reginfo: use outbound proxy for PUBLISHes"
aa8288b Revert "pua_reginfo: correct docs"
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1365/files/5db9e0594ba6555ab8
@vance-od pushed 1 commit.
9ace9b7 usrloc: extend handle_lost_tcp, do not use inline functions
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1365/files/aa8288b094a927c01f3bef2d60224d2733d79cf9..9ace9b77ab87202a
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for
still having mess with git usage, as not using it on my work...
thank you for your patience. Clean PR created.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1365#issuecomment-35135
Closed #1365.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1365#event-1385390921___
Kamailio (SER) - Development Mailing List
sr-dev@lis
### Description
The issue started with this improvement:
https://github.com/kamailio/kamailio/commit/839cf89b02f8817156487a960ff62013e3cde530
(it works fine for single dialog bodies, but make a mess with multiple-dialog
bodies)
### Troubleshooting
**Test scheme, preconditions:**
- SIP server: kam
@phil-lavin , can you take a look at this thread?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1427#issuecomment-363106217___
Kamaili
Hi, Daniel! thanks for the patch!
will give it a try today
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1427#issuecomment-364885964__
I tried proposed changes.
in ps_match_dialog_state_from_body
there is a loop:
while(node != NULL) {
why do we need there one more while loop?
What actually happens:
.
if(strcmp(tmp_state, vstate)!=0) { // here we come only once, when matching
first dialog
...
all later dialogs are iter
The result: for multiple dialog bodie only first body checked (I added custom
logging inside your code to see where it worked)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1427#
re-tested it again, it does check only first dialog in a body
your code with my custom logging
```
int ps_match_dialog_state_from_body(str body, int *is_dialog, char *vstate)
{
xmlDocPtr doc;
xmlNodePtr node;
xmlNodePtr childNode;
char *tmp_state;
int rmatch
Hi, Daniel! Thank you for your help!
I tried to print that value in logs, but get stuck a bit (I did not found how
to print xml elements correctly). I got some sequence of crashes while attempts
to add appropriate logs.
What I tried more:
I changed:
` && xm
my shame... I did not do NULL check and that was the reason for crash.
With your logging added (processing same body and input PUBLISH as before):
```
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence
[presentity.c:361]: ps_match_dialog_state_from_body(): vstate is terminate
thanks for the last patch, I tried it.
Making the fast check the match of multiple dialog body works as expected.
Let me do deeper testing today. Will report results later.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
htt
Hi, Daniel!
I did more testing and provided change works.
What do you think regarding proper solution with comparing call-id (as you
mentioned in the beginning)?
Because current change improve the situation, but it is not what is expected by
RFC.
Anyway - I think this changes should be committe
21 matches
Mail list logo
