> Great work, just a small notice, there is a committed Readme file.
Thanks,
The committed README file is regenerated, not manually changed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@alexyosifov pushed 1 commit.
71e8bf1e99e830800f379ea8ceabbc37d048cdd6 Delete README
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1974/files/80bea2509fb3b7f792e3d12cf309ee55cfcc72d7
alexyosifov commented on this pull request.
> > > Great work, just a small notice, there is a committed Readme file.
> >
> >
> > Thanks,
> > The committed README file is regenerated, not manually changed.
>
> Yes, but please remove the changes to
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
I understand.
Best Regards,
Aleksandar Yosifov
On Wed, 5 Jun 2019 at 13:25, Daniel-Constantin Mierla <
notificati...@github.com> wrote:
> Pay attention next time because the README file was removed completely
> with this PR (I just added it back).
>
> The README file must stay in the git tree,
Closed #1980.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1980#event-2410087063___
Kamailio (SER) - Development Mailing List
Closed #1981.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1981#event-2410089763___
Kamailio (SER) - Development Mailing List
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
This is a bug fix.
In NOTIFY message from S-CSCF to UE, Message Body contains different xml
parameters and one of them can be a contact parameter with list of
unknown-params. In some cases unknown-param has value with '%' inside. For
instance: "urn%3Aurn-7%3A3gpp-service.ims.icsi.me". In this
- The new methods are used in usrloc pscscf module, but they are universal and
can be used anywhere.
core: Added debug messages in grep_sock_info.
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core,
- Parse 'security verify' header from REGISTER request message
and save updated parameters into the database.
- Added debug messages in save_pendign and save for easy debugging.
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits
…' to 'version=%d'.
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README
- added a new line to the end of some debug logs for
better formatting.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to
> @henningw, @alexyosifov - looking at the patch, the pull request here is not
> adding any `return 0`, they existed. The patch is adding a couple of
> `close_mnl_socket(sock)`.
>
> If the existing `return 0` in error cases are wrong, then they need to be
&g
- added a new config param - ipsec_reuse_server_port - reuse or not
PCSCF server port for UA Re-registration.
- added description for the new parameter in ims_ipsec_pcscf_admin.xml.
parameter ipsec_reuse_server_port.
- in ipsec_forward() add supported and require secagree headers only
for
- fixed a defect reported from Coverity Scan - Concurrent data access
violations in spi_gen.c for spi_data-spi_val.
- in create_ipsec_tunnel() return -1 when unable to convert ip address.
- in ipsec_create() go to cleanup instead return -1 when get request
for reply fails. Fixed debug message
Hi,
Now I am working to split to different pull requests (bug fixes and new
functional changes). After that I am going to close this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
- added a new optional parameter in ipsec_forward()
to set or not send force socket for request
messages. Useful for ipsec and tcp connections.
If set to 1 - send requests through existing
ipsec tunnel when tcp is used. In combination
with tcp_reuse_port=yes.
!-- Kamailio Pull Request
- fixed a defect reported from Coverity Scan - Concurrent data access
violations in spi_gen.c for spi_data-spi_val.
- added a new conf param - ipsec_reuse_server_port - reuse or not
PCSCF server port for UA Re-registration.
- added description for the new parameter in
- added a new line to the end of some debug logs for
better formatting.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master
Fixed. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2202#issuecomment-578088392___
Kamailio (SER) - Development Mailing List
@alexyosifov pushed 1 commit.
42b42d31bb3f1eff8833162c66b2327000a285eb ims_reqistrar_scscf: Fix bug with
multi-notifications
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2202/files
- Added more accurate contact comparison when
sending NOTIFY to a subscriber.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to
- Rx AAR for Terminating direction get identity
from request message if dialog is missing.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be
Hi all,
I am still waiting for a review more than a month.
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This pull request can be closed. Dedicated pull requests already merged.
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
- Prevent multiple contacts for NOTIFY message in
Message body registration tag after
RE-REGISTRATION procedure.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
Hi,
thank you for the quick response!
And see the problem right now but be honest with you - in our test lab we never
met this behavior of the P-CSCF. The P-CSCF sends SUBSCRIBE generated from
itself (with Contact: and
Call-ID 7fb844aa6636e93a-173@192.168.178.92) and there is a problem with my
- If uri contains some parameters before @ as phone context,
till now the function strips everything after that. With the
fix all parameters before and after @ are stripped and
the domain remaining.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing
@ngvoice, Hi,
Any update with the local tests?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2246#issuecomment-610357341___
Kamailio (SER) - Development
> Looks fine to me, you can merge.
>
> Just a note for the archive - would probably make sense to review static int
> handle_ruri_alias(struct sip_msg *msg) in nathelper.c, which does a kind of
> similar function internally like the new added extract_alias_ip_port, to see
> if this could be
Hi,
Could you please check it again. I did the recommended changes.
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hi,
I did some fixes. Could you please check them.
Thanks!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2246#issuecomment-617065971___
Kamailio (SER) -
@alexyosifov pushed 1 commit.
df7ee4df03767424256a31f9b9ffdbbfc0b52f4a ims_registrar_scscf: fix aor
generation in lookup()
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2287/files
@alexyosifov pushed 1 commit.
58d289c00c2f43806d84f936d4fc0e25d47ac2e2 ims_registrar_scscf: fix multiple
contacts in NOTIFY
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2246/files
- Generate AoR in lookup() from parsed uri user and
host. Skipping all users and hosts parameters.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests
@alexyosifov pushed 0 commits.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2287/files/df7ee4df03767424256a31f9b9ffdbbfc0b52f4a..2161f0cc316af0e1153b01f327d0e7c50523060c
Closed #2287.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2287#event-3255670815___
Kamailio (SER) - Development Mailing List
> Thanks for this contribution!
>
> However, wouldn't it be better to use `parse_sip_msg_uri()` so `_m->new_uri`
> or ` _m->first_line.u.request.uri` is parsed in the `_m->parsed_uri` field
> and then just build the AoR using `_m->parsed_uri.user` and
> `_m->parsed_uri.host`?
Thanks for the
Hi,
I just tested my change and reginfo enabled in PCSCF configuration. I got the
same result as you.
But the problem is that without my change there is an issue with the NOTIFY
sent to the UE. If there are two or more contacts (for example after
re-registration) the NOTIFY sent to the UE
- pass event type as parameter in notify_subscribers()
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they
Hi all,
Could you take a look at the pull request?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2296#issuecomment-625110304___
Kamailio
Hi all,
Could you take a look at the pull request?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2292#issuecomment-625110664___
Kamailio
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
- Prevent sending of multiple contacts in 200OK reply
for UE Re-Registration. Now S-CSCF replies with the
exact contact for Re-Registration.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
@alexyosifov pushed 1 commit.
3b74c1c88f0f16e4560c1141eb9bf2621c9ce875 Update save.c
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2426/files/9817f4df988b6cea09858e5dc1d6b359a12b562b
@alexyosifov pushed 1 commit.
c6d5937c6187193f04a6e772b94b7a2c2e356462 Update cmd.c
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2426/files/3b74c1c88f0f16e4560c1141eb9bf2621c9ce875
@alexyosifov commented on this pull request.
> @@ -618,6 +627,7 @@ int decode_3gpp_sms(struct sip_msg *msg) {
// Coding: 7 Bit
if (rp_data->pdu.coding == 0x00) {
- fixed the calculation for concatenated SMSs
based on TS 23.040, Sec. 9.2.3.16
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to
- added a missing field in sip_msg_update_buffer()
when restoring message fiedls: msg-pid.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be
@alexyosifov commented on this pull request.
> +// cipher_null, des, des3_ede, aes
strcpy(l_enc_algo->alg_name,"cipher_null");
+if (strncasecmp(r_ealg.s,"aes-cbc",r_ealg.len) == 0) {
+LM_DBG("Creating security associations: AES\n");
@alexyosifov commented on this pull request.
> -// for Reply and TCP sends from P-CSCF server port, for Reply and
> UDP sends from P-CSCF client port
-src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
+// Check send socket
+struct
@alexyosifov approved this pull request.
Added some comments
> @@ -846,11 +846,20 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d, int
> _cflags)
// for Reply get the dest proto from the received request
dst_proto = req->rcv.proto;
-// for Reply and
@alexyosifov approved this pull request.
> -// for Reply and TCP sends from P-CSCF server port, for Reply and
> UDP sends from P-CSCF client port
-src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
+// Check send socket
+struct
@miconda , No comments from my side.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2731#issuecomment-847306443___
Kamailio (SER) -
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable
- Validity period is present only for SUBMIT
msg type and it is an optional parameter.
For now supports only Relative VP format.
!-- Kamailio Pull Request Template --
!--
IMPORTANT:
- for detailed contributing guidelines, read:
- Added new sms pdu data: originating destination address flags;
SCTS(DELIVER)/VP(SUBMIT) absolute time format.
- decode_3gpp_sms(): added support for DELIVER type;
Added VP-AbsoluteTimeFormat for SUBMIT type.
- pv_sms_body(): added support for ucs2 coding.
- Extends of pv_get_sms() and
@miconda - the changes were made according to spec. Added more parameters that
can be set/get from the config files.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
66 matches
Mail list logo
