[sr-dev] [kamailio/kamailio] rtpengine: add UDP/TLS/RTP/SAVP and UDP/TLS/RTP/SAVPF as valid transport protocols (#1458)

2018-02-27 Thread jerzyptak
### Description UDP/TLS/RTP/SAVP and UDP/TLS/RTP/SAVPF should be recognised and handled as valid transport protocols, those should be used when DTLS is used for SRTP. ### Additional Information ``` version: kamailio 5.1.1 (x86_64/linux) ``` * **Operating System**: ``` Linux 3.10.0-693.17.1.el7

Re: [sr-dev] [kamailio/kamailio] rtpengine: add UDP/TLS/RTP/SAVP and UDP/TLS/RTP/SAVPF as valid transport protocols (#1458)

2018-02-27 Thread jerzyptak
For example calling from kamailio config file `rtpengine_answer("SDES-off ICE=remove trust-address replace-origin replace-session-connection UDP/TLS/RTP/SAVP");` will result in passing "UDP/TLS/RTP/SAVP" to rtpengine as an undefined flag instead of interpreting it as a valid transport protocol.

[sr-dev] [kamailio/kamailio] rtpengine: added support for DTLS transports (#1460)

2018-02-28 Thread jerzyptak
Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files

Re: [sr-dev] [kamailio/kamailio] rtpengine: add UDP/TLS/RTP/SAVP and UDP/TLS/RTP/SAVPF as valid transport protocols (#1458)

2018-02-28 Thread jerzyptak
I have created PR with a possible implementation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1458#issuecomment-369227493___ Kamailio

Re: [sr-dev] [kamailio/kamailio] rtpengine: added support for DTLS transports (#1460)

2018-02-28 Thread jerzyptak
Yes, this is not a bugfix, it is just a streamlining change that removes the need to use the undocumented feature `transport-protocol=UDP/TLS/...`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/

Re: [sr-dev] [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread jerzyptak
First of all, I am sorry for crating this regression - I have clearly not fully appreciated how the fall through of flags in rtpengine module works. Using "DTLS" for declaring transport is just a shortcut for the log version UDP/TLS/RTP/SAVP, so removing it will not make much difference. -- You