Re: [sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
The following attempted workaround also fails:
1. don't use DTLS=off, force transport
rtpengine_manage("ICE=remove transport-protocol=RTP/SAVP");
2. rtpengine side use dtls-passive
rtpengine --dtls-passive

For some reason this also doesn't work, as rtpengine after rewritng SDP adds

a=setup:actpass
a=fingerprint:sha-1 0F:21:F8:06:56:09:51:EC:B2:0B:47:A8:2D:98:D0:E7:E9:F7:0F:A9


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369893139___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread Daniel-Constantin Mierla
It is a side effect of PR #1460.

More specific, from mailing list discussion 
(https://lists.kamailio.org/pipermail/sr-users/2018-March/100539.html), the 
related change should be:

```
+   else if (str_eq(, "DTLS"))
+   ng_flags->transport |= 0x104;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369890586___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
@rfuchs  hoping you can take a look at this. The merge to master and backport 
to 5.1.2 has broken my use of rtpengine_manage("DTLS=off") since the DTLS key 
is removed from the ng-protocol messaged and not processed by rtpengine.

It is needed specifically for FreeSWITCH in SDES (who for some reason does not 
like a=setup:actpass and a=fingerprint)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369888212___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)

2018-03-02 Thread aalba6675
### Description

rtpengine module is hijacking the DTLS key

rtpengine_manage("DTLS=off")

DTLS=off is a valid command to rtpengine, but the module uses that flag
to set transport as UDP/TLS/RTP/SAVP

Unfortunately even though the transport can be fixed by RTP/SAVP, the lines 
outputted by rtpengine

a=setup:actpass
a=fingerprint:xx

confuse some UACs that were expecting only SDES. FreeSWITCH is affected.

### Troubleshooting


 Reproduction

rtpengine_manage("DTLS=off"). tcpdump the traffic between kamailio and 
rtpengine.
Obseve that there is no DTLS=off key.

 Debugging Data


 Log Messages


 SIP Traffic


### Possible Solutions

Don't look for DTLS key, let that be passthrough to kamailio

### Additional Information

5.1.2

* **Operating System**:
Linux CentOS 7.4

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev