Re: [sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)

2018-07-11 Thread Surendra Tiwari
please backport to 5.x.x stable branches. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1589#issuecomment-404229916___ Kamailio (SER) -

Re: [sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)

2018-07-11 Thread Daniel-Constantin Mierla
Closed #1589. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1589#event-1728338026___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)

2018-07-11 Thread Daniel-Constantin Mierla
Thanks for the contribution, however I pushed a slightly different implementation, to optimize by checking first the length of the parameter -- the commit is referenced above. Also, the commit message of your PR didn't use the format suggested by CONTRIBUTING.md guide. The indentation was not

[sr-dev] [kamailio/kamailio] Module: rr adding is_direction to kemi (#1589)

2018-07-11 Thread Surendra Tiwari
Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README