Re: [sr-dev] [kamailio/kamailio] app_python: don't hide the real exception on load failure (#1471)

2018-03-02 Thread Daniel-Constantin Mierla
Thanks! @aalba6675 you can commit directly to app_python as well, there is no 
other very active developer for the module. If you really want a review for 
your commit, then it is ok to do PR as well. Otherwise, from my point of view, 
you are more familiar with embedding python interpreter.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1471#issuecomment-370036208___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] app_python: don't hide the real exception on load failure (#1471)

2018-03-02 Thread Daniel-Constantin Mierla
Merged #1471.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1471#event-1501889489___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] app_python: don't hide the real exception on load failure (#1471)

2018-03-02 Thread aalba6675




 Pre-Submission Checklist



- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

Calling PyErr_Print() clears the error indicator and hides the real cause of 
failing to load
the module as the output is lost (module has no stderr).

The error should be left to python_handle_exception() to display via LM_ERR.


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1471

-- Commit Summary --

  * app_python: don't hide the real exception on load failure

-- File Changes --

M src/modules/app_python/app_python_mod.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1471.patch
https://github.com/kamailio/kamailio/pull/1471.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1471
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev