Re: [sr-dev] [kamailio/kamailio] ims_auth: fixed rare core dump, due to null ptr check (#1213)
You can use `git cherry-pick -x MASTER_COMMIT_ID` in branches `5.0` and `4.4` to make the backports in your local clones, then push them here as pull requests. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1213#issuecomment-322111357___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_auth: fixed rare core dump, due to null ptr check (#1213)
Thanks. What can I do to enable/support backporting to 5.0 and 4.4 branches? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1213#issuecomment-321854201___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_auth: fixed rare core dump, due to null ptr check (#1213)
Merged, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1213#issuecomment-321818702___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_auth: fixed rare core dump, due to null ptr check (#1213)
Merged #1213. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1213#event-1202640315___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] [kamailio/kamailio] ims_auth: fixed rare core dump, due to null ptr check (#1213)
The ims_auth module reads the value from the Content-Length header of a REGISTER request, before decoding the message body. Due to a missing null pointer check, reading this value leads to core dump in case the Content-Length header is missing. Pre-Submission Checklist - [ x] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ x] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Added a null pointer check in function ims_get_body() - file utils.c of module ims_auth - to check whether Content-Length Header was present in REGISTER message. If Content-Length Header is not present, a Default value of 0 will be assumed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1213 -- Commit Summary -- * ims_auth: fixed rare core dump, due to null ptr check -- File Changes -- M src/modules/ims_auth/utils.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1213.patch https://github.com/kamailio/kamailio/pull/1213.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1213 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
