Re: [sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

2020-08-12 Thread Henning Westerholt
Merged #2426 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2426#event-3648988737___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

2020-08-12 Thread Henning Westerholt
Thanks for the fix, merged

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2426#issuecomment-673045380___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

2020-08-07 Thread Henning Westerholt
Thank you. I will merge it manually to adapt the wrong commit message in the 
two latest commits.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2426#issuecomment-670375246___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

2020-08-06 Thread alexyosifov
@alexyosifov pushed 1 commit.

c6d5937c6187193f04a6e772b94b7a2c2e356462  Update cmd.c


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2426/files/3b74c1c88f0f16e4560c1141eb9bf2621c9ce875..c6d5937c6187193f04a6e772b94b7a2c2e356462
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

2020-08-06 Thread alexyosifov
@alexyosifov pushed 1 commit.

3b74c1c88f0f16e4560c1141eb9bf2621c9ce875  Update save.c


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2426/files/9817f4df988b6cea09858e5dc1d6b359a12b562b..3b74c1c88f0f16e4560c1141eb9bf2621c9ce875
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

2020-08-06 Thread Henning Westerholt
@henningw commented on this pull request.



> @@ -76,6 +76,7 @@ extern usrloc_api_t ul;
 extern struct tm_binds tmb;
 
 #define IPSEC_SEND_FORCE_SOCKET0x01 /* if set - set send force 
socket for request messages */
+#define IPSEC_REVERSE_SEARCH   0x02 /* if set - start seraching from 
the last element */

small spelling issue - searching

> @@ -196,10 +196,24 @@ static inline int update_contacts(struct sip_msg 
> *req,struct sip_msg *rpl, udoma
ci.searchflag = 
SEARCH_RECEIVED;
}
}
-   } 
+   } else {
+   char* srcip = NULL;
+   if((srcip = pkg_malloc(50)) == NULL) {

It is necessary to allocate new pkg memory here? The save_pending function just 
uses a char[50] array for a somewhat similar logic. Just wondered. :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2426#pullrequestreview-462728452___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev