Re: [sr-dev] [kamailio/kamailio] Ipsec defects (#1980)

2019-06-13 Thread alexyosifov
Closed #1980.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1980#event-2410087063___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Ipsec defects (#1980)

2019-06-13 Thread Daniel-Constantin Mierla
Can you change the commit messages to have only the content relevant for the 
changes? If not, we can apply manually the patches and write new commit 
messages.

 Right now the first line is rather useless with "fix reported defect".

They should be like:

  * first patch:

```
ims_registrar_pcscf: fixed possible use of uninitialized value in 
ipsec_forward()

- related to calling "*ul.unlock_udomain"
```

  * second patch:

```
ims_registrar_pcscf: fixed dereferencing null pointer "cb->contacts" in save()

- removed unnecessary debug message
```

For more details about commit message content, see:

  * 
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-rules

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1980#issuecomment-501586793___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev