Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-15 Thread Emmanuel BUU
Just tested both with TCP and UDP. Its working fine. Thank you very much! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365872768___

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-15 Thread Emmanuel BUU
Oups -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365868838___ Kamailio (SER) - Development Mailing List sr-dev

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-15 Thread Daniel-Constantin Mierla
Have you set `force_send_socket` parameter of `rr` module to `1`? I don't see it in your comment that shows `rr` params in config. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-15 Thread Emmanuel BUU
Daniel, in fact it is not working. See previous comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-365862634___ K

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-14 Thread Emmanuel BUU
If I inspect the packet I see a single route without transport information. And yet the correct source port is selected ! Can you tell us how kamailio guess the source port to use in that case. These traces demonstrate that in the loose_route() function, send_socket is NOT forced. And yet th

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-14 Thread Emmanuel BUU
Ok, I tested and it is working but I would kindly need an explanation 1- the setup : - kamailio 5.1 with three listen (on port 5060, 5063, 5066) - 2 UAs using UDP on port 5063 - added a log in the script ``` route[WITHINDLG] { if (!has_totag()) return; # sequential request with

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
OK, let's see the results, because it should work for single Route header, that was the purpose of the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-3649

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Emmanuel BUU
No I did not test it. I will. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-364925128___ Kamailio (SER) - Developmen

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
Did you just review the code or you also tested it? It covers the cases when enable_double_rr is 1 (or different than 0) and there is no second Route header. Because if there is a second route, then the socket is forced later to the outgoing socket. -- You are receiving this because you are su

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Emmanuel BUU
Hi Daniel, I reviewed the code and unfortunately, it does not cover the case when - enable_double_rr=1 - both UA are using the same IP and the same port and there is only one route inserted by record_route() To handle this case, see the patch I suggest below. Alternatively, we could set enab

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Thomas Carvello
Thank you for your time! One of our engineer is currently testing it. If we have any issue or comments ,we will come back to you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
Closing after the commit and remarks in the previous comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#issuecomment-364850721

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-12 Thread Daniel-Constantin Mierla
Closed #1428. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1428#event-1468935219___ Kamailio (SER) - Development Mailing List sr-dev@l

Re: [sr-dev] [kamailio/kamailio] Issue with Socket selection on Forwarding ACK message (#1428)

2018-02-09 Thread Daniel-Constantin Mierla
I pushed a commit to rr module adding a new parameter that allows enforcing send socket even on a single Route header - see 93739c0b8674a09f8364eac6f28bcc91b167843a . Testing and providing feedback will be appreciated. Anyhow, for older versions you can force the socket from config, after loos