Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
Closed #1422. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1422#event-1479119814___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
@SurendraPlivo pushed 1 commit. 13608cc rename to db_redisusrloc -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1422/files/0061e2bbe7a167a3cc6118e26b56c800ad2b8196..13608ccb46f6c23875b405f0f926aea63d3d0d1f ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
@SurendraPlivo pushed 1 commit. 0061e2b rename to db_redisusrloc -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1422/files/6de4a62f44964e91afe864d5ab0ab1f1263fc86f..0061e2bbe7a167a3cc6118e26b56c800ad2b8196 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
The module is very tight to usrloc module, embedding even the default column names for location table. If this is going to be merge in this state, I would suggest to name it like `db_redisuloc` or something else that suggests the constraints with its usage. Later can be renamed. Regarding the issue with snprintf size parameter reported above, I spotted like: ``` return_code = snprintf(table_name,(CON_TABLE(_h)->len+1) * sizeof(char),"%s%.*s%s",CON_TQUOTESZ(_h), CON_TABLE(_h)->len, CON_TABLE(_h)->s, CON_TQUOTESZ(_h)); ``` Another aspect that needs to be take care is to check if pkg_malloc() returns NULL or not -- if there is no sufficient memory, it will cause a crash. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1422#issuecomment-364108421___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
@Vadiml1024 first of all thank you for review . will you please help me out by reentrancy by producing it ? because we tested it for more than 300 rps and with 7 endpoint. we didn't face this issue.anyway its good if you can point me to specific case. in some places i see snprintf where source string size is passed as 2 parameter (buffer size). The idea is to pass target buffer size as second parameter will you please point out these places. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1422#issuecomment-362963972___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
Vadiml1024 requested changes on this pull request. I would suggest some rework: This code contains potential reentrancy problems because of strtok usage... should be using strtok_r In lot of places it uses sprintf, strcat, and strcpy which are subject to potential buffer overflows in some places i see snprintf where source string size is passed as 2 parameter (buffer size). The idea is to pass target buffer size as second parameter -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1422#pullrequestreview-93862573___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)
@agranig @miconda -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1422#issuecomment-361842108___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
