Re: [sr-dev] [kamailio/kamailio] dialog: in dlg_onreq function, the result of this check is always false (#1791)
All works fine for me. Thanks for the fix -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1791#issuecomment-452739295___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] dialog: in dlg_onreq function, the result of this check is always false (#1791)
I just pushed a patch (404f403786478a917637186446bb285e8e32cc59) that should remove the requirement of setting the dlg_flag parameter. Can you give it some tests and confirm if all works fine or not? When all ok, it can be backported. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1791#issuecomment-452693361___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] dialog: in dlg_onreq function, the result of this check is always false (#1791)
Hmm, I thought that requiring to set dlg_flag was removed, but apparently it is not. We should get rid of that, needs to be fixed somehow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1791#issuecomment-452666916___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] dialog: in dlg_onreq function, the result of this check is always false (#1791)
You are right, sorry for the noise. But I have some doubts.
You said that dlg_flag parameter is not required but if I don't set the
dlg_flag, kamailio gives me an error when load dialog module:
```
Jan 9 10:53:08 pepelux /usr/local/sbin/kamailio[27387]: ERROR: dialog
[dialog.c:519]: mod_init(): invalid dlg flag -1!!
Jan 9 10:53:08 pepelux /usr/local/sbin/kamailio[27387]: ERROR:
[core/sr_module.c:911]: init_mod(): Error while initializing module dialog
(/usr/local/lib64/kamailio/modules/dialog.so)
```
It worked for me as follow:
```
#!define DLG_FLAG 3
modparam("dialog", "dlg_flag", DLG_FLAG)
route(CNXCC);
dlg_manage();
```
My problem was that I called route(CNXCC) after dlg_manage() and it seems that
it is necessary to execute cnxcc functions before the dlg_manage().
Thanks for the help
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1791#issuecomment-452652477___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] dialog: in dlg_onreq function, the result of this check is always false (#1791)
Closed #1791. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1791#event-2062726498___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] dialog: in dlg_onreq function, the result of this check is always false (#1791)
Did you set the `dlg_flag` parameter for dialog module? * https://www.kamailio.org/docs/modules/stable/modules/dialog.html#dialog.p.flag If yes, that is not required if you use `dlg_manage()`. If you set the modparam, then you have to do setflag(X) where X is the value for dlg_flag modparam. Otherwise, if I didn't miss something, the condition there should to be ok to execute the code - dlg_flag_mask is 0 by default (with no dlg_flag set) and the expression evaluates to if(0!=0) return: ``` if((req->flags_flag_mask)!=dlg_flag_mask) return; `` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1791#issuecomment-452607617___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
