Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
@alexyosifov pushed 0 commits.



-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2287/files/df7ee4df03767424256a31f9b9ffdbbfc0b52f4a..2161f0cc316af0e1153b01f327d0e7c50523060c
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
Closed #2287.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2287#event-3255670815___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
Hi,
Could you please check it again. I did the recommended changes.

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2287#issuecomment-617053426___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-21 Thread alexyosifov
@alexyosifov pushed 1 commit.

df7ee4df03767424256a31f9b9ffdbbfc0b52f4a  ims_registrar_scscf: fix aor 
generation in lookup()


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2287/files/9f94506a18d4546c2abb8998f0eb65b2296911e2..df7ee4df03767424256a31f9b9ffdbbfc0b52f4a
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-17 Thread alexyosifov
> Thanks for this contribution!
> 
> However, wouldn't it be better to use `parse_sip_msg_uri()` so `_m->new_uri` 
> or ` _m->first_line.u.request.uri` is parsed in the `_m->parsed_uri` field 
> and then just build the AoR using `_m->parsed_uri.user` and 
> `_m->parsed_uri.host`?

Thanks for the suggestion. I will do the changes and test them next week.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2287#issuecomment-615169297___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix aor generating in lookup() (#2287)

2020-04-16 Thread Daniel-Constantin Mierla
Thanks for this contribution!

However, wouldn't it be better to use `parse_sip_msg_uri()` so `_m->new_uri` or 
` _m->first_line.u.request.uri` is parsed in the `_m->parsed_uri` field and 
then just build the AoR using `_m->parsed_uri.user` and `_m->parsed_uri.host`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2287#issuecomment-614714429___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev