Closed #2208.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#event-4402476534___
Kamailio (SER) - Development Mailing List
sr-dev@lis
OK, thanks - closing this one then, discussions can continue on the new PR
#2657.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-789771983_
lreprxoy name is changed to lrkproxy
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-789677108___
Kamailio (SER) - Develo
I think it would be good to create a PR with the new name, so it will be a
clean merge of the module. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-784263
I am planning to change lreproxy to lrkproxy. any idea in this regard?
@miconda, let me know do i have to create new PR after renaming module or some
things else?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://githu
> Please adjust your commit messages to follow the project's guidelines for
> commit messages. Just committing with the module name is not explaining
> anything.
I fixed my commit message in last update. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this
lreproxy is updated right now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-782847249___
Kamailio (SER) - Development
@mojtabaesfandiari pushed 0 commits.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2208/files/c077c81cb3e02b207eea686d7963720c076752e9..584f50b37edebf72eecf2f49d947bb4cc99f87a1
__
Please adjust your commit messages to follow the project's guidelines for
commit messages. Just committing with the module name is not explaining
anything.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/
@mojtabaesfandiari pushed 1 commit.
0a8717667a0ccdb5ae1ae9f32077d0d9e053d634 lreproxy
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2208/files/beda3fef42dfbbe96d76cf62e6b1a9f56bc957af..0a8717667a0ccdb5ae1ae9f32
> @jchavanton, Would you please let me know more details related to first
> comment that you mentioned?
> The second comment is accepted and i will do it.
> Let me know how do you test it? What unexpected performance degradation did
> you see?
@mojtabaesfandiari
Considering that my test report
Actually, I am planning for having a workshop of using lreproxy( LRKProxy ) as
soon.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-780369541_
@jchavanton, Would you please let me know more details related to first comment
that you mentioned?
The second comment is accepted and i will do it.
Let me know how do you test it?What unexpected performance degradation did you
see?
--
You are receiving this because you are subscribed to this
@jchavanton,there was a quite bit issue when the lreproxy kernel engine
received duplicate ports. You could check it after update. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/p
Few comments on the module being ready to merge :
- I noticed the module interface was outdated it should be tested one more
time, `child_init` and `mod_init` may not be working.
- The documentation is good however it is made in the README instead of the XML
files
- Based on my quick tests there
As before, I strongly suggest that you remove all references to "RTPengine" as
it is another product, not a generic name for an RTP proxy. LRKproxy is better.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.c
@miconda Sure, although, lreproxy can be searched and tracked on internet, but
i think LRKProxy is better. What do you think? If yes, i have to change the
name of lreproxy in project. let me do it during next days, Also some updates
will publish as soon. Thanks
@jchavanton I am trying to check w
@jchavanton - is the module ready to merge in your opinion (docs, code, or what
you had time to look over)?
@mojtabaesfandiari - is it ok to rename the module to LRKProxy as you made a
remark on a comment above?
--
You are receiving this because you are subscribed to this thread.
Reply to this
I left it running for several hours, no more crash, there seems to be something
odd with kamailio responsiveness degrading over time.
Could be related to my config, did you ever do long lasting end2end tests ?
One obvious missing feature is hosted NAT traversal/port latching, this will
greatly r
I was running with the default config
```
sudo python3 pylreproxy.py
```
lreproxy was using a fake IP not present in the system, maybe this was part of
the problem generating the crash ...
I got one working test.
```
/etc/py_lre_proxy/py_lre_proxy.ini
[DEFAULT]
@mojtabaesfandiari
Just made a few tests, documentation is good, well done.
However I got a crash quickly, probably due to miss config, but crash in the
kernel module makes it much more problematic.
```
Feb 11 14:09:04 anton-ThinkPad-P43s kernel: [225916.195416] RIP:
0010:main_hook_post+0x70/
yes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-775820414___
Kamailio (SER) - Development Mailing List
sr-dev@lists.
@mojtabaesfandiari is this the source code of the kernel module you mentioned
(which I think was part of Q3 in this thread)?
https://github.com/mojtabaesfandiari/py-lreproxy/tree/main/lib/c
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
For example, some upcoming updates are:
Multiple NIC relaying.
Video supporting.
Some quite bit changes for relaying RTP to unix socket.
:)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio
@jchavanton Sure, feel free for using it right now.
It could be used right now, But because this module is new, it might be
updated,
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/
@mojtabaesfandiari did you end-up sharing your code, opensource it ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-775314438___
@miconda Thanks for your suggestion about its name. I agree with you. The name
could be change LRKProxy or something else.
I dont want to say this module has more performant than rtpengine or compare
with other media engine. But just as you mentioned, the rtpengine does already
kernel/iptables-b
In Kamailio we accept modules that offer the same/similar functionality that is
provided by other modules. So from this point of view, it is not a problem that
we already have rtpproxy, rtpengine or mediaproxy as alternatives for relaying
RTP packets.
Personally, as I understood after a brief c
https://ieeexplore.ieee.org/document/9303608
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-753577000___
Kamailio (SER)
@mojtabaesfandiari pushed 1 commit.
beda3fef42dfbbe96d76cf62e6b1a9f56bc957af lreproxy
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2208/files/c5efad09dd821e1a3f3c2c037a6461c7060775bc..beda3fef42dfbbe96d76cf62e
the lreproxy module is updated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-748595933___
Kamailio (SER) - Development
@mojtabaesfandiari pushed 1 commit.
c5efad09dd821e1a3f3c2c037a6461c7060775bc lreproxy
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2208/files/15fd09bb5e4d49bb9d61ee067a17e87fc9bf4abb..c5efad09dd821e1a3f3c2c037
The Lreproxy service is published in my git, The insulation help is in Readme
file. It might be confusing,
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-74726090
Also i could have online demo in realtime scenario to show it's performance.
Actually we used offloading technique in lreproxy. Our resaults are published
in our paper. :))
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
h
The lreproxy engine with Python had done before and everyone could use the
lreproxy after i push the service in github.
In regard of comparison with rtpengine, i suggest check it in practical
scenario.
While the lreproxy could also works with multiple rtpengine services in cloud
sulotions.
Just
Hi Motjaba, I found your answers very confusing, here is what I
understand/deduct.
1- We can not conclude that lreproxy is faster than rtpengine since rtpengine
was not tested with its kernel module.
2- No one can use the lreproxy module since there python/C code required is not
developed yet.
Sure, We have to develop a kernel module for lreproxy for forwarding RTP
packets based on SDP properties.
The LREProxy engine will share in git site
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio
About Q3, can you add a link to the source code how can anyone use it ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-740307942
About Q1, I am not sure how to interpret your answer, RTP engine is using
IPtables with the kernel module, but you need to build it properly and load it,
did you do it explicitly ?
The step to load it :
```
# RUN echo " building IP iptables-extension" \
#&& cd /git/rtpengine/iptables-ext
@jchavanton Thanks for asking some important question,
Q1: Yes, Because RTPengine use local hooking in network stack while this module
works in prerouting hooking in network stack.
Q2: We have completely different designed hash search index based of SDP
parameter in session. It no have relation t
Few questions out of curiosity ...
Did you benchmark RTPengine with the kernel module or without ?
I have the impression that this solution is using libnetfilter, queue, etc ?
Doe it mean that everything is self contain or the code to manage libnetfiler
is somewhere else ?
--
You are receivin
Considering the existing modules related to RTP
```
rtp_media_server.html
rtpengine.html
rtpproxy.html
```
I would recommend adding RTP at the beginning of the name, to make sure anyone
can immediately assume this is about RTP forwarding/relaying/proxying
rtp_lr or rtp_light or `rtp_lw_relay
Yes, As @henningw is mentioned, some rework substancially is doing right now, I
don't think it's over for this branching.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuec
@miconda I had a conversation with the author of the pull request, he wants to
rework the code substancially. I don't think this should be merged in this form.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.c
Short note to say that probably branching of 5.4 will happen soon, if you want
this merged for 5.4.x release series, then it has to be made ready during the
next days.
For the code you wrote, then you put your copyright. For the code you took from
other places, you need to copy over the copyrig
@miconda Sure,
I just pasted these lines "copy rights "at top of my code because i wanted to
obey the roles of adding new module in Kamailio.
I obey these roles in other files, like lreproxy_funcs.h. Is it right?
--
You are receiving this because you are subscribed to this thread.
Reply to this
@sergey-safarov Just a quite little, I should look it more and compare its
results with my results.
Thanks for sharing it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuec
@sobomax - thanks for looking into it.
@mojtabaesfandiari - if there are continuous parts of code copied over from an
existing module such as rtpproxy, you have to keep original copyright line and
add yours for the additions. You can split the file in two, one with copied
code and one with your
@mojtabaesfandiari are you looked [`DPDK`](https://www.dpdk.org/) initiative.
This initiative driven by many hardware and software
[vendors](https://www.dpdk.org/ecosystem/#members).
`DPDK` move packet processing from kernel to network interface card.
`DPDK` allow get network packet processing at
mojtabaesfandiari commented on this pull request.
> @@ -0,0 +1,1976 @@
+/*
+ * Copyright (C) 2019-2020 Mojtaba Esfandiari.S, Nasim-Telecom
For cause of compatibilities with other codes in Kamailio, I decided to use
rtpproxy module,such as naming of functions, parsing URL, SDP, get media
descr
sobomax commented on this pull request.
> @@ -0,0 +1,1976 @@
+/*
+ * Copyright (C) 2019-2020 Mojtaba Esfandiari.S, Nasim-Telecom
>From brief look to it, this is pretty much carboon-copy of the rtpproxy
>module, as such original (c) line of the code should be reproduced. Thanks!
--
You are re
sobomax commented on this pull request.
> @@ -0,0 +1,120 @@
+/*
+ * Copyright (C) 2019-2020 Mojtaba Esfandiari.S, Nasim-Telecom
>From brief look to it, this is pretty much carboon-copy of the rtpproxy
>module, as such original (c) line of the code should be reproduced. Thanks!
--
You are rec
The kernel module does not have to be published here, but is it open source? If
yes, is it available somewhere (another github repository or a public portal)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.co
I don't publish the lreproxy engine because of quite bit of updating.
No, Actually is a linux kernel module that would be insert to linux module for
working with this module.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Where I can get source (description) of `lre proxy server`?
Is ` lre proxy server` fork of [`RTP proxy`](https://www.rtpproxy.org/)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2
sergey-safarov commented on this pull request.
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Sof
Sure, It is under developing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-579196515___
Kamailio (SER) - Development
there's no doc at all. Please take a look over other modules and provide the
documentation.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-579194500___
The lreproxy is a Light-RTP-Engine module for Kamailio project. The lreproxy
engine have developed based LKM for linux. It uses off-loading technique for
relaying huge number of RTP. It could be used in ingress nodes in your voip
network. This module use a customised rtp packet classification th
59 matches
Mail list logo
