Re: [sr-dev] [kamailio/kamailio] ims_qos: create a proper flow description for the SIP signaling (ab3d42c)

Hi @vingarzan I just want to check with you before I do a change related to this commit. With this change Rx AAR for subscription to signalling status now uses the general flow-usage: AVP_EPC_Flow_Usage_No_Information instead of AVP_EPC_Flow_Usage_AF_Signaling as it previously did. I want to

Re: [sr-dev] [kamailio/kamailio] Fix i pv6 on rx (#677)

Hi @fedefava86 Apologies for the delay on this. All looks good - thanks for the patch! Unfortunately I did some format changes since you did this pull request and had quite a few conflicts to work through. As your patch was fairly short I committed it separately and credited you on the commi

Re: [sr-dev] [kamailio/kamailio] ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration (#721)

Thanks @vingarzan All looks good - just want to check one thing with @jaybeepee on ims_registrar_pcscf: fixed removal of contacts on de-registration I have a sneaking suspicion this was removed on purpose and the contact removal is done through NOTIFY from S-CSCF. Though I don't think this w

Re: [sr-dev] [kamailio/kamailio] ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration (#721)

Ahh I see the confusion - we call reginfo_handle_notify from cfg file - which might not be the case for all P-CSCF cfg files. I think we still need to do quite a bit of polishing on this code and config. --- You are receiving this because you are subscribed to this thread. Reply to this email d

Re: [sr-dev] [kamailio/kamailio] ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration (#721)

Hi Have a look at ims_registrar_pcscf/notify.c line 205. If the contact is in usrloc and a NOTIFY is received for terminate it should remove it. But agreed we should do both - just in case. Give me a day or two I just want to double confirm with @jaybeepee why it was removed in the first pla

Re: [sr-dev] [kamailio/kamailio] ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration (#721)

Merged #721. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/721#event-730808203___ sr-dev mailing list sr-dev@lists.sip-router.org http://

Re: [sr-dev] [kamailio/kamailio] ims_qos, ima_registrar_pcscf: fixes for de-registration and adding a flow to registration (#721)

I see the reginfo_handle_notify is actually in the example pcscf config file in git: examples/pcscf/kamailio.cfg line 1184. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/721#issue

Re: [sr-dev] [kamailio] Return CSCF_RETURN_FALSE if AAR is not generated (#314)

Hi This looks completely fine to me. Regards On 7 September 2015 at 16:19, Daniel-Constantin Mierla < notificati...@github.com> wrote: > Hopefully @jaybeepee or @ngvoice > should be able to review this patch, being > related to ims mod

Re: [sr-dev] [kamailio] Return CSCF_RETURN_FALSE if AAR is not generated (#314)

Merged #314. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314#event-402875243___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev