Re: [SR-Users] A question about the code

2016-05-03 Thread Alex Balashov
Nathan, I think this is actually deliberate. The return value of an assignment operation is always going to be true, so it's just an "overly clever" way of compactly setting the value of 'ret' to -2 within the same conditional evaluation. The aim there is compactness, though it does obscure

[SR-Users] A question about the code

2016-05-03 Thread ngregory
Greetings,I am a Kamailio user trying to get more deeply familiar with the platform. I have been digging through the code and spotted something that just seems wrong. I am not really a programmer (I dabble some, but...) so did not want to go down the path of reporting a bug, at least not just yet.

[SR-Users] rtpengine default set

2016-05-03 Thread Alex Balashov
Hi, After upgrading to Kamailio v4.4, I receive the following error on boot: May 03 17:18:22 allegro-4.evaristesys.com /usr/local/sbin/kamailio[24972]: ERROR: rtpengine [rtpengine.c:2691]: select_rtpp_set(): script error-invalid id_set to be selected May 03 17:18:22 allegro-4.evaristesys.com

Re: [SR-Users] t_on_branch_failure never called AND t_relay never fails in a, forked scenario

2016-05-03 Thread Tristan Mahé
Hi Daniel, Seems like I missed your reply. I've tried with tcp only, and set_forward_no_connect is used also now. The only log shown with debug=3 is, for the failing branch: /usr/sbin/kamailio[60054]: [INVITE] ERROR: tm [../../forward.h:240]: msg_send_buffer(): tcp_send failed

[SR-Users] Planning the release of Kamailio v4.4.1

2016-05-03 Thread Daniel-Constantin Mierla
Hello, I am considering to do a minor release from branch 4.4 next week, likely on Tue or Wed, May 10 or 11, 2016. If there are issues you are aware of and not reported yet to the tracker, do it as soon as possible to try to fix what we can by the date. Cheers, Daniel -- Daniel-Constantin

Re: [SR-Users] set_body_multipart and memory leak

2016-05-03 Thread Daniel-Constantin Mierla
I guess I haven't replied to mailing list, but the patches were already backported to 4.4 branch few days ago. Cheers, Daniel On 03/05/16 18:30, Sergey Basov wrote: > > Thank you, Daniel. > > 2 мая 2016 г. 10:31 пользователь "Daniel-Constantin Mierla" >

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Daniel-Constantin Mierla
On 03/05/16 17:31, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> And I think I found the issue -- when the type was not provided, the >> pointer inside the xmlNode structure was used instead of using the >> function to return a clone of the content, in order to free it later via

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > And I think I found the issue -- when the type was not provided, the > pointer inside the xmlNode structure was used instead of using the > function to return a clone of the content, in order to free it later via > xmlrpc module garbage collector. > > I

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Daniel-Constantin Mierla
Thanks for digging in further, the details proved to be important. And I think I found the issue -- when the type was not provided, the pointer inside the xmlNode structure was used instead of using the function to return a clone of the content, in order to free it later via xmlrpc module garbage

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
in my sems xmlrpc test, i changed htable.reload command to permissions.trustedReload (that does not have parameters) and have not been able to produce a crash. my conclusion is that xmlrpc string parameter value without is causing the crash (perhaps due to memory allocation bug either in

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
string parameter value without tags is legal in xmlrpc: Scalar s s can be scalars, type is indicated by nesting the value inside one of the tags listed in this table: Tag TypeExample orfour-byte signed integer-12 0 (false) or 1 (true) 1 string hello world

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > I checked the xmlrpc module commit log and last code changes were in > September 2014 - even those are not related to any xml ops. In the past, > have you used the xmlrpc commands for other similar deployments with an > older version than 4.4 of kamailio? I

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Daniel-Constantin Mierla
Still the issue is in the system memory, even the xmlrpc module was compiled with pkg malloc manager. The crash this time is in regexp functions from libc. It could be the operations done with libxml2 inside the xmlrpc, because they use the libxml2 native functions that rely on system malloc. I

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > Thinking more of it -- is the route[cleaner] executed with rtimer on a > dedicated timer process? I have two timer routes: modparam("rtimer", "timer", "name=stat_timer;interval=60;mode=1") modparam("rtimer", "exec", "timer=stat_timer;route=stats")

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > What is the version of kamailio running there? 4.4 build from git on April 7. > xmlrpc is compiled by default to use system memory manager (expecting to > need big chunks for some responses), can you recompile it to use the > pkg? You have to edit

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Daniel-Constantin Mierla
On 03/05/16 09:01, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> These ones are no longer related to xmlrpc, but triggered by an sqlops >> query - first bracktrace, the other two are during the signal >> handling. > OK, but there must be some kind of relation to xmlrpc, because I

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > These ones are no longer related to xmlrpc, but triggered by an sqlops > query - first bracktrace, the other two are during the signal > handling. OK, but there must be some kind of relation to xmlrpc, because I have had this same test system running without

Re: [SR-Users] Kamailio and Oracle database

2016-05-03 Thread Daniel-Constantin Mierla
Hello, On 03/05/16 08:18, gmele wrote: > Hello Daniel, > > I add a look to the db_unixodbc and the presence modules. To correct the > ODBC replace query that is visibly not supported by Oracle, I would like to > add a new parameter in the db_unixodbc module : replaceQuery = {0:1}. 0 = > not

Re: [SR-Users] Kamailio and Oracle database

2016-05-03 Thread Daniel-Constantin Mierla
Hello, On 02/05/16 16:22, gmele wrote: > Hello Daniel, > > I'm now investigating the presence notification module problem and the odbc > query: > > replace watchers > (presentity_uri,watcher_username,watcher_domain,event,status,inserted_time,reason > ) values

Re: [SR-Users] Kamailio and Oracle database

2016-05-03 Thread gmele
Hello Daniel, I add a look to the db_unixodbc and the presence modules. To correct the ODBC replace query that is visibly not supported by Oracle, I would like to add a new parameter in the db_unixodbc module : replaceQuery = {0:1}. 0 = not supported, 1 = supported (default). Now, in the

Re: [SR-Users] Kamailio and Oracle database

2016-05-03 Thread Daniel-Constantin Mierla
Hello, On 02/05/16 15:25, gmele wrote: > Hello Daniel, > > I found the problem: kamctl tool for oracle created a BLOB for the BODY > column of table PRESENTITY. > > I changed it to CLOB and now it works better. OK, good to know -- perhaps we have to change the definition for oracle sql scripts.

Re: [SR-Users] xmlrpc crash

2016-05-03 Thread Daniel-Constantin Mierla
These ones are no longer related to xmlrpc, but triggered by an sqlops query - first bracktrace, the other two are during the signal handling. The one for sqlops leads quite a bit inside the libmysqlclient, which can happen because there is a buffer overflow in kamailio for the operations in the