Re: [SSSD] [PATCH] rework identification against DP too

2009-08-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 01:09 PM, Simo Sorce wrote: > On Tue, 2009-08-11 at 13:01 -0400, Simo Sorce wrote: >> Change the identification sense against DP too like I did in the >> previous patches against the monitor. > > Patch did not apply on master after the l

Re: [SSSD] [PATCH] rework identification against DP too

2009-08-11 Thread Simo Sorce
On Tue, 2009-08-11 at 13:01 -0400, Simo Sorce wrote: > Change the identification sense against DP too like I did in the > previous patches against the monitor. Patch did not apply on master after the last push, attaching a fixed patch. Simo. 0001-Change-the-why-DP-clients-identify.patch Descrip

[SSSD] [PATCH] rework identification against DP too

2009-08-11 Thread Simo Sorce
Change the identification sense against DP too like I did in the previous patches against the monitor. Simo. 0001-Change-the-why-DP-clients-identify.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

Re: [SSSD] sssd [PATCH] Make socket paths a compile-time option

2009-08-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 06:10 AM, Simo Sorce wrote: > On Mon, 2009-08-10 at 12:32 -0400, Stephen Gallagher wrote: >> I realized I mistakenly attached the wrong patch to the previous >> email. >> The correct patch is attached. > > ack. > > Simo. > > __

Re: [SSSD] [PATCH] Fix monitor ping timeout

2009-08-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 12:24 PM, Simo Sorce wrote: > On Tue, 2009-08-11 at 10:49 -0400, Stephen Gallagher wrote: >> Our configuration specifies the monitor config timeout as seconds, >> but we were passing it directly to dbus commands that require >> millisecon

Re: [SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 12:18 PM, Stephen Gallagher wrote: > On 08/11/2009 12:08 PM, Simo Sorce wrote: >>> Attached new 0002 patch with the included fixes. >> Ooops patch was buggy, sent int tried to read string (thanks Steve :) > >> New one attached. > >> Sim

Re: [SSSD] [PATCH] Fix monitor ping timeout

2009-08-11 Thread Simo Sorce
On Tue, 2009-08-11 at 10:49 -0400, Stephen Gallagher wrote: > > Our configuration specifies the monitor config timeout as seconds, > but we were passing it directly to dbus commands that require > milliseconds. Fixing this in get_monitor_config(). Also, the > default value of -1 for the timeout r

Re: [SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 12:08 PM, Simo Sorce wrote: >> Attached new 0002 patch with the included fixes. > > Ooops patch was buggy, sent int tried to read string (thanks Steve :) > > New one attached. > > Simo. > > > -

Re: [SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Simo Sorce
> Attached new 0002 patch with the included fixes. Ooops patch was buggy, sent int tried to read string (thanks Steve :) New one attached. Simo. 0002-Change-services-identification-mechanism.patch Description: application/mbox ___ sssd-devel mailing

[SSSD] [PATCH] Fix monitor ping timeout

2009-08-11 Thread Stephen Gallagher
Our configuration specifies the monitor config timeout as seconds, but we were passing it directly to dbus commands that require milliseconds. Fixing this in get_monitor_config(). Also, the default value of -1 for the timeout resulted in a timeout much too short to be useful, so I'm making it 10s i

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-11 Thread Dmitri Pal
Jakub Hrozek wrote: > On 08/10/2009 08:27 PM, Stephen Gallagher wrote: > > Ack. Waiting for a reply from Jakub as well before pushing these > patches. > > Patch 0001 (INI fix): ACK > > Patch 0002 (ELAPI): I have some comments and questions. Most of them are > just style comments, but I think at lea

Re: [SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Simo Sorce
On Tue, 2009-08-11 at 08:41 -0400, Stephen Gallagher wrote: > Patch 0002: > Minor typo in client_registration: regeistration should be > registration ok > Coding standard for dbus methods suggest the more readable: > ret = dbus_message_append_args(reply, >DBUS_TYPE

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-11 Thread Simo Sorce
On Tue, 2009-08-11 at 15:04 +0200, Jakub Hrozek wrote: > > 4) In general (this is maybe question also for the others not a review > item), is there a reason for passing the macros containing > configure-time variables as -DMACRO instead of using > AC_DEFINE_UNQUOTED > and pulling them out of conf

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-11 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 08:27 PM, Stephen Gallagher wrote: > Ack. Waiting for a reply from Jakub as well before pushing these patches. Patch 0001 (INI fix): ACK Patch 0002 (ELAPI): I have some comments and questions. Most of them are just style comments, but I

Re: [SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 06:52 AM, Simo Sorce wrote: > The following 3 patches changes the way services are started up and > identify themselves to the monitor. > > The first patch is just minor or cosmetic fixes. > > The second patch changes the identification

[SSSD] [PATCHES] services startup and identification

2009-08-11 Thread Simo Sorce
The following 3 patches changes the way services are started up and identify themselves to the monitor. The first patch is just minor or cosmetic fixes. The second patch changes the identification from monitor initiated to service initiated and acked by the monitor. This allows the service to per

Re: [SSSD] sssd [PATCH] Make socket paths a compile-time option

2009-08-11 Thread Simo Sorce
On Mon, 2009-08-10 at 12:32 -0400, Stephen Gallagher wrote: > > I realized I mistakenly attached the wrong patch to the previous > email. > The correct patch is attached. ack. Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https:/

Re: [SSSD] New Try to build SSSD on Karmic both as of 2009.08.04

2009-08-11 Thread Simo Sorce
On Mon, 2009-08-10 at 17:22 -0400, Mathias Gug wrote: > Hi, > > On Fri, Aug 7, 2009 at 11:25 AM, Stephen Gallagher wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 08/07/2009 10:40 AM, Miguel P.C. wrote: > >> Hi again, > >> > >>> International testing is always a good thing

Re: [SSSD] Proposed version and branch policy in the SSSD

2009-08-11 Thread Simo Sorce
On Thu, 2009-08-06 at 10:02 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > As the subject implies, I think we need a branch policy in the SSSD to > address things like the recent security update that we released for > 0.4.1. Currently there is no obvious way

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-11 Thread Simo Sorce
On Fri, 2009-08-07 at 13:59 -0400, Stephen Gallagher wrote: > When the backends start up, the monitor was immediately sending a > getIdentity request. However, as we've added more processing to > the initialization routines over time, we started introducing > latency between when we open the connec