Re: [SSSD] [PATCH] ELAPI: fix varargs call, update unit tests

2009-09-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/2009 10:40 AM, Jakub Hrozek wrote: > Fix another crash I noticed while integrating ELAPI..the > set_default_template functions has variable number of arguments and uses > E_EOARGS as sentinel. The call of set_default_template used in > get_def

[SSSD] [PATCHES] Patches to SSSD manpages

2009-09-17 Thread Stephen Gallagher
Patch 0001: sssd.conf(5) didn't refer to sssd-ldap(5) Patch 0002: sssd-ldap(5) was missing the groupSearchBase option -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 26564a0880eb8503bb9f8815b66f41fb5cdd96c1 Mon Sep 17 00:00:00 2001 From

Re: [SSSD] [PATCH] Add binaries and backup files to .gitignore

2009-09-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/2009 10:41 AM, Jakub Hrozek wrote: > ssia Ack - ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedo

Re: [SSSD] [PATCH] Add documentation for installing build dependencies

2009-09-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/2009 01:28 PM, jeffschr...@gmail.com wrote: > From: Jeff Schroeder > > Tested on a stripped down F10 install with backported samba4 libraries > > Signed-off-by: Jeff Schroeder > --- > BUILD.txt |9 - > 1 files changed, 8 inser

[SSSD] [PATCH] Add documentation for installing build dependencies

2009-09-17 Thread jeffschroed
From: Jeff Schroeder Tested on a stripped down F10 install with backported samba4 libraries Signed-off-by: Jeff Schroeder --- BUILD.txt |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/BUILD.txt b/BUILD.txt index b90a7a9..4e9268c 100644 --- a/BUILD.txt +++ b/BUI

Re: [SSSD] [PATCHES] Collection related patches

2009-09-17 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/2009 06:08 AM, Dmitri Pal wrote: > Dmitri Pal wrote: >> > See patch comments for details. >> > All three are not massive. >> > 1) Comparison and sorting collections I don't understand why are you testing for "first->property[second->property_

[SSSD] [PATCH] ELAPI: fix varargs call, update unit tests

2009-09-17 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fix another crash I noticed while integrating ELAPI..the set_default_template functions has variable number of arguments and uses E_EOARGS as sentinel. The call of set_default_template used in get_default_template did not use any variable arguments, re

[SSSD] [PATCH] Add binaries and backup files to .gitignore

2009-09-17 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ssia -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqySqkACgkQHsardTLnvCWw6ACgx70qhwuPN7gW3GTpiZDL/g01 vusAnjWC20VsZhUp3OBC8f3uehtUK28O =hDjv -END PGP SI

Re: [SSSD] [PATCH] ELAPI: Fix dispatcher structure initialization

2009-09-17 Thread Dmitri Pal
Simo Sorce wrote: > On Wed, 2009-09-16 at 22:04 -0400, Dmitri Pal wrote: > >> The main point is (thought it will make my merge more complex, I can >> deal with it using merge tools as you said), >> > > Just to make it clear, raising the card "I have to rebase/merge and that > is annoying",

Re: [SSSD] [PATCH] proxy bug

2009-09-17 Thread Simo Sorce
On Thu, 2009-09-17 at 06:25 -0400, Stephen Gallagher wrote: > > > > Ok new patches attached, with members debug turned into a macro. > Looks good to me. Ok pushed both. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-

Re: [SSSD] [PATCH] ELAPI: Fix dispatcher structure initialization

2009-09-17 Thread Simo Sorce
On Wed, 2009-09-16 at 22:04 -0400, Dmitri Pal wrote: > The main point is (thought it will make my merge more complex, I can > deal with it using merge tools as you said), Just to make it clear, raising the card "I have to rebase/merge and that is annoying", is not a valid reason to not accept a pa

Re: [SSSD] DHASH warnings

2009-09-17 Thread John Dennis
On 09/17/2009 12:18 AM, Dmitri Pal wrote: > Hi, > > Spotted some dhash warnings. Seems like worth fixing especially > shadowing ones... Sure, will do. Just want to point out the warnings are only in the unit test and example, not the main code. > > dhash_test.c: In function ‘main’: > dhash_test.c

Re: [SSSD] [PATCH] proxy bug

2009-09-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/16/2009 04:53 PM, Simo Sorce wrote: > On Wed, 2009-09-16 at 08:48 -0400, Simo Sorce wrote: >>> Please make it a macro or a subroutine instead of adding it three >> times. >> >> Yeah, will do. > > Ok new patches attached, with members debug turne