Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-06 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2009 07:43 PM, Stephen Gallagher wrote: Replied to the wrong patch earlier... Nack. sss_getpwnam_done() and friends should return EIO if the sysdb replies with more than one result, I think. EINVAL implies that the fault was with the

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2009 06:32 AM, Jakub Hrozek wrote: On 10/05/2009 07:43 PM, Stephen Gallagher wrote: Replied to the wrong patch earlier... Nack. sss_getpwnam_done() and friends should return EIO if the sysdb replies with more than one result, I think.

Re: [SSSD] [PATCH] Remove btreemap

2009-10-06 Thread Simo Sorce
On Tue, 2009-10-06 at 10:48 -0400, Stephen Gallagher wrote: We no longer use it anywhere in the code, having replaced it with the more efficient dhash. ack, you may want to add a small comment in some header like: /* R.I.P. btreemap 2008-2009 */ :-) Simo.

[SSSD] [PATCH] Remove mpg option

2009-10-06 Thread Simo Sorce
See subj and patch comment. Simo. 0001-Remove-magicPrivateGroups-option.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Remove DP process

2009-10-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2009 08:11 AM, Simo Sorce wrote: On Mon, 2009-10-05 at 10:16 -0400, Simo Sorce wrote: 0002 - the DP patch with the mentioned fixes New DP removal patch that also removes the dp_interfaces.h file, now completely useless. Simo.