On Mon, Nov 26, 2012 at 05:52:53PM +0100, Pavel Březina wrote:
In general, I think freeing const variable means that something is
wrong with design, although I found myself in this situation once or
twice (in other projects).
I don't think this is necessarily true; we often use a construct
On 11/26/2012 05:43 PM, Simo Sorce wrote:
On Thu, 2012-11-22 at 09:52 +0100, Michal Židek wrote:
On 11/21/2012 04:41 PM, Simo Sorce wrote:
On Wed, 2012-11-21 at 15:56 +0100, Michal Židek wrote:
On 11/21/2012 02:31 PM, Simo Sorce wrote:
On Tue, 2012-11-20 at 14:29 +0100, Michal Židek wrote:
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On 11/24/2012 05:33 AM, Simo Sorce wrote:
In particular note that we merge ipa_account_info_netgroups_done()
and ipa_account_info_users_done() into a single fucntion called
ipa_account_info_done() that handles both cases
We also remove the auxiliary function ipa_account_info_complete() that
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
https://fedorahosted.org/sssd/ticket/1673
There was a typo in the code (s/res/dom_res) which could result in
segfault (found by Coverity).
Thanks
Michal
From 8cd6cafcca5282de095e305c4e8ea060dc679854 Mon Sep 17 00:00:00 2001
From: Michal Zidek mzi...@redhat.com
Date: Tue, 27 Nov 2012 12:36:40
On 11/27/2012 12:52 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1673
There was a typo in the code (s/res/dom_res) which could result in
segfault (found by Coverity).
Thanks
Michal
Ack.
___
sssd-devel mailing list
On 11/26/2012 03:18 PM, Michal Židek wrote:
On 11/22/2012 07:16 PM, Pavel Březina wrote:
On 11/22/2012 06:47 PM, Jakub Hrozek wrote:
On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote:
On 11/22/2012 10:27 AM, Pavel Březina wrote:
On 11/21/2012 03:00 PM, Michal Židek wrote:
On
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes indentation in part of
the code (so it looks bigger than it actually is). I updated debug
messages in the changed part with the new SSSDBG_* macros.
Patch is attached.
Thanks
Michal
From
On 11/27/2012 01:44 PM, Pavel Březina wrote:
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes indentation in part of
the code (so it looks bigger than it actually is). I updated debug
messages in the
On 11/27/2012 01:34 PM, Pavel Březina wrote:
On 11/26/2012 03:18 PM, Michal Židek wrote:
On 11/22/2012 07:16 PM, Pavel Březina wrote:
On 11/22/2012 06:47 PM, Jakub Hrozek wrote:
On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote:
On 11/22/2012 10:27 AM, Pavel Březina wrote:
On
On 11/27/2012 02:16 PM, Michal Židek wrote:
On 11/27/2012 01:34 PM, Pavel Březina wrote:
On 11/26/2012 03:18 PM, Michal Židek wrote:
On 11/22/2012 07:16 PM, Pavel Březina wrote:
On 11/22/2012 06:47 PM, Jakub Hrozek wrote:
On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote:
On
On Tue 27 Nov 2012 09:28:56 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 13:59 +0100, Michal Židek wrote:
On 11/27/2012 01:44 PM, Pavel Březina wrote:
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes
On 11/27/2012 05:42 PM, Stephen Gallagher wrote:
On Tue 27 Nov 2012 09:28:56 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 13:59 +0100, Michal Židek wrote:
On 11/27/2012 01:44 PM, Pavel Březina wrote:
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
On Tue 27 Nov 2012 09:33:00 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
Can you use fail pattern instead of calling the former each time
allocation fails?
Otherwise it looks good. I like the function.
I would like to vouch for always using 'done:' as a
On Mon, Nov 26, 2012 at 10:42:17PM +0100, Jakub Hrozek wrote:
On Mon, Nov 26, 2012 at 12:00:44AM +0100, Jakub Hrozek wrote:
https://fedorahosted.org/sssd/ticket/1668
The memberof plugin did only expand the ghost users attribute to
parents when adding a nested group, but didn't implement
On Tue, 2012-11-27 at 11:49 -0500, Stephen Gallagher wrote:
On Tue 27 Nov 2012 09:33:00 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
Can you use fail pattern instead of calling the former each time
allocation fails?
Otherwise it looks good. I like
The first three patches are just refactoring. The last patch implements
the real modify operation along with a number of unit tests.
From 71902d3eab67a14ba200908b7c708d3f661e4ed8 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek jhro...@redhat.com
Date: Mon, 26 Nov 2012 13:18:59 +0100
Subject: [PATCH
On 11/27/2012 05:57 PM, Simo Sorce wrote:
On Tue, 2012-11-27 at 11:49 -0500, Stephen Gallagher wrote:
On Tue 27 Nov 2012 09:33:00 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
Can you use fail pattern instead of calling the former each time
allocation
In some situations, the c-ares lookup can return NULL instead of
a list of addresses. In this situation, we need to avoid
dereferencing NULL.
This patch adds a log message and sets the count to zero so it is
handled appropriately below.
This patch fixes the crash seen in
https://fedorahosted.org/sssd/ticket/1625
Additional info:
the class of configuration error messages could be
changed to match the default debug level.Apparently this was covered with
#1345 and in server.c
if (debug_level == SSSDBG_UNRESOLVED) {
/* set debug
On Tue, 2012-11-27 at 11:02 +0100, Michal Židek wrote:
On 11/26/2012 05:43 PM, Simo Sorce wrote:
On Thu, 2012-11-22 at 09:52 +0100, Michal Židek wrote:
On 11/21/2012 04:41 PM, Simo Sorce wrote:
On Wed, 2012-11-21 at 15:56 +0100, Michal Židek wrote:
On 11/21/2012 02:31 PM, Simo Sorce
On Tue, 2012-11-27 at 12:34 +0100, Pavel Březina wrote:
On 11/24/2012 05:33 AM, Simo Sorce wrote:
In particular note that we merge ipa_account_info_netgroups_done()
and ipa_account_info_users_done() into a single fucntion called
ipa_account_info_done() that handles both cases
We also
On Tue, 2012-10-30 at 15:30 +0100, Jakub Hrozek wrote:
On Tue, Oct 30, 2012 at 01:54:10PM +0100, Pavel Březina wrote:
Hi,
this was already discussed and the solution was
04b3ab7658985af749460010123bbe37eccf50ed.
On the client side it uses the same macro. If the protocol doesn't
match
This revision should address all concerns raised by Pavel for code that I
actually changed from the original. For patch 1 a calrification I can't
make was asked. I 'fixed' the code as I realized I copied a debug statement
wrapped in an if statement that wasn't in the original code I move around,
26 matches
Mail list logo
