Re: [SSSD] [PATCH] warn user if password is about to expire

2012-11-28 Thread Sumit Bose
On Tue, Nov 20, 2012 at 11:18:22AM +0100, Pavel Březina wrote: On 11/19/2012 04:59 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1638 Self nack. -if (pwd_exp_warning == 0 || -difftime(now + pwd_exp_warning, ppolicy-expire) 0.0) { +

Re: [SSSD] [PATCH] idmap: Silence DEBUG messages when dealing with built-in, SIDs.

2012-11-28 Thread Jakub Hrozek
On Tue, Nov 27, 2012 at 03:29:02PM +0100, Pavel Březina wrote: You are right. New patch attached. Thanks for the review Pavel. Michal Ack! Works fine, ack++ and pushed to master and sssd-1-9 ___ sssd-devel mailing list

Re: [SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

2012-11-28 Thread Jakub Hrozek
On Tue, Nov 27, 2012 at 10:45:17AM +0100, Jakub Hrozek wrote: To me, the patch makes sense. Ack ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH 1/3] Revert Avoid accessing half-deallocated memory when using talloc_zfree macro.

2012-11-28 Thread Jakub Hrozek
On Mon, Nov 26, 2012 at 04:45:56PM +0100, Pavel Březina wrote: Ack. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH 2/3] Avoid duplicating macros

2012-11-28 Thread Jakub Hrozek
On Mon, Nov 26, 2012 at 04:46:40PM +0100, Pavel Březina wrote: Ack. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

2012-11-28 Thread Jakub Hrozek
On Wed, Nov 28, 2012 at 01:35:38PM +0100, Jakub Hrozek wrote: On Tue, Nov 27, 2012 at 10:45:17AM +0100, Jakub Hrozek wrote: To me, the patch makes sense. Ack Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Null pointer dereferenced.

2012-11-28 Thread Jakub Hrozek
On Tue, Nov 27, 2012 at 11:42:02AM -0500, Stephen Gallagher wrote: Actually, I agree with Michal here. Performing the NULL check first reads better (and is more in line with our coding style elsewhere in SSSD). The patch's real changes are viewable with 'git diff -w HEAD^' after applying it,

Re: [SSSD] [PATCH] Allow more libldap debugging

2012-11-28 Thread Jakub Hrozek
On Wed, Nov 28, 2012 at 07:40:32AM -0500, Stephen Gallagher wrote: On Wed 28 Nov 2012 02:46:43 AM EST, Jakub Hrozek wrote: On Tue, Nov 27, 2012 at 11:27:03PM -0500, Simo Sorce wrote: On Wed, 2011-08-10 at 15:29 +0200, Jan Zelený wrote: On Wed, Aug 10, 2011 at 10:14:14AM +0200, Jan Zelený

Re: [SSSD] [PATCH] Allow more libldap debugging

2012-11-28 Thread Stephen Gallagher
On Wed 28 Nov 2012 02:46:43 AM EST, Jakub Hrozek wrote: On Tue, Nov 27, 2012 at 11:27:03PM -0500, Simo Sorce wrote: On Wed, 2011-08-10 at 15:29 +0200, Jan Zelený wrote: On Wed, Aug 10, 2011 at 10:14:14AM +0200, Jan Zelený wrote: This patch should not be pushed to master, but I would like to

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-28 Thread Ondrej Kos
On 28/11/12 01:31, Ariel Barria wrote: https://fedorahosted.org/sssd/ticket/1625 / //Additional info:/ /the class of configuration error messages could be changed to match the default debug level./ Apparently this was covered with #1345 and in server.c / if

Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists

2012-11-28 Thread Jakub Hrozek
On Thu, Nov 22, 2012 at 12:48:25PM -0500, Ariel Barria wrote: Date: Thu, 22 Nov 2012 15:42:59 +0100 From: jhro...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists On Wed, Nov 21, 2012 at

Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists

2012-11-28 Thread Ariel Barria
Date: Wed, 28 Nov 2012 15:10:17 +0100 From: jhro...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists On Thu, Nov 22, 2012 at 12:48:25PM -0500, Ariel Barria wrote: Date: Thu, 22 Nov 2012 15:42:59 +0100

Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists

2012-11-28 Thread Jakub Hrozek
On Wed, Nov 28, 2012 at 09:31:29AM -0500, Ariel Barria wrote: Date: Wed, 28 Nov 2012 15:10:17 +0100 From: jhro...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists On Thu, Nov 22, 2012 at 12:48:25PM

Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists

2012-11-28 Thread Stephen Gallagher
On Wed 28 Nov 2012 09:35:10 AM EST, Jakub Hrozek wrote: On Wed, Nov 28, 2012 at 09:31:29AM -0500, Ariel Barria wrote: Date: Wed, 28 Nov 2012 15:10:17 +0100 From: jhro...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATCH] when monitor_quit is call and the process not

Re: [SSSD] [PATCH] warn user if password is about to expire

2012-11-28 Thread Pavel Březina
On 11/28/2012 11:15 AM, Sumit Bose wrote: On Tue, Nov 20, 2012 at 11:18:22AM +0100, Pavel Březina wrote: On 11/19/2012 04:59 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1638 Self nack. -if (pwd_exp_warning == 0 || -difftime(now +

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-28 Thread Ariel Barria
Thanks for your comments. Date: Wed, 28 Nov 2012 14:38:29 +0100 From: o...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf On 28/11/12 01:31, Ariel Barria wrote: https://fedorahosted.org/sssd/ticket/1625

Re: [SSSD] [PATCH] when monitor_quit is call and the process not exists

2012-11-28 Thread Jakub Hrozek
On Wed, Nov 28, 2012 at 09:55:11AM -0500, Stephen Gallagher wrote: Thank you for reporting the bug and the contribution! I'd like to see a second ack on the patch as it was kind of pair programming, so I don't think I can ack on my own. Ack. Pushed to master and sssd-1-9

Re: [SSSD] [PATCH] warn user if password is about to expire

2012-11-28 Thread Sumit Bose
On Wed, Nov 28, 2012 at 04:54:45PM +0100, Pavel Březina wrote: On 11/28/2012 11:15 AM, Sumit Bose wrote: On Tue, Nov 20, 2012 at 11:18:22AM +0100, Pavel Březina wrote: On 11/19/2012 04:59 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1638 Self nack. -if

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-28 Thread Ondrej Kos
On 28/11/12 17:12, Ariel Barria wrote: Thanks for your comments. Date: Wed, 28 Nov 2012 14:38:29 +0100 From: o...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf On 28/11/12 01:31, Ariel Barria wrote:

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-28 Thread Ariel Barria
Date: Wed, 28 Nov 2012 17:50:09 +0100 From: o...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf On 28/11/12 17:12, Ariel Barria wrote: Thanks for your comments. Date: Wed, 28 Nov 2012 14:38:29