Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Lukas Slebodnik
On (07/10/15 20:51), Nikolai Kondrashov wrote: >On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote: >>Hi everyone, >> >>Here is a patch set fixing some things in integration tests and adding more >>LDAP tests: >> >> * Adding/removing a user/group/membership with rfc2307(bis) schema. >> *

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 09:32:14AM +0200, Lukas Slebodnik wrote: > Jakub, > does it look good to you? LGTM (visual inspection only) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

2015-10-08 Thread Lukas Slebodnik
On (04/10/15 21:51), Jakub Hrozek wrote: >On Fri, Oct 02, 2015 at 11:26:33AM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> Attached patch should prevent such failures as in commit >> 73ec8fdfddb2d4bf99977f758eec80e1b1ee8542 >> BUILD: Link test_data_provider_be with -ldl >> >> SSS_CRYPT_LIBS

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Pavel Reichl
On 10/08/2015 09:32 AM, Lukas Slebodnik wrote: Pavel R., could these patches used with your tests for local override? LS I'll have to amend the patches, but that was agreed to. Seems that functionality I need is there so fine by me. ___

Re: [SSSD] More upstream CI tests

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 08:02:45AM +0200, Lukas Slebodnik wrote: > On (07/10/15 17:42), Pavel Reichl wrote: > > > > > >On 10/07/2015 08:58 AM, Lukas Slebodnik wrote: > >>On (31/08/15 12:31), Jakub Hrozek wrote: > >>>On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: > On

Re: [SSSD] [PATCH] LDAP: Inform about small range size

2015-10-08 Thread Lukas Slebodnik
On (23/01/15 12:27), Stephen Gallagher wrote: >On Fri, 2015-01-23 at 17:27 +0100, Jakub Hrozek wrote: >> On Fri, Jan 23, 2015 at 05:24:51PM +0100, Michal Židek wrote: >> > On 01/23/2015 04:35 PM, Lukas Slebodnik wrote: >> > >On (23/01/15 10:21), Stephen Gallagher wrote: >> > >> >> > >> >> > >> >>

Re: [SSSD] More upstream CI tests

2015-10-08 Thread Lukas Slebodnik
On (07/10/15 17:42), Pavel Reichl wrote: > > >On 10/07/2015 08:58 AM, Lukas Slebodnik wrote: >>On (31/08/15 12:31), Jakub Hrozek wrote: >>>On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: On (19/08/15 23:38), Jakub Hrozek wrote: >Hi, > >as we're stabilizing the 1.13

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Lukas Slebodnik
On (08/10/15 10:33), Pavel Reichl wrote: > > >On 10/08/2015 09:32 AM, Lukas Slebodnik wrote: >> >>Pavel R., >>could these patches used with your tests for local override? >> >>LS >> > >I'll have to amend the patches, but that was agreed to. Seems that >functionality I need is there so fine by me.

Re: [SSSD] More upstream CI tests

2015-10-08 Thread Pavel Reichl
On 10/08/2015 08:02 AM, Lukas Slebodnik wrote: On (07/10/15 17:42), Pavel Reichl wrote: On 10/07/2015 08:58 AM, Lukas Slebodnik wrote: On (31/08/15 12:31), Jakub Hrozek wrote: On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: On (19/08/15 23:38), Jakub Hrozek wrote: Hi, as

Re: [SSSD] [PATCH] cache_req: support UPN

2015-10-08 Thread Pavel Březina
On 10/07/2015 04:28 PM, Sumit Bose wrote: On Wed, Oct 07, 2015 at 04:22:31PM +0200, Sumit Bose wrote: On Wed, Oct 07, 2015 at 02:42:18PM +0200, Pavel Březina wrote: On 10/06/2015 03:16 PM, Pavel Březina wrote: On 10/01/2015 05:06 PM, Sumit Bose wrote: On Thu, Sep 17, 2015 at 11:06:30AM

Re: [SSSD] [PATCH] typos in integration tests

2015-10-08 Thread Pavel Březina
On 10/07/2015 02:55 PM, Pavel Reichl wrote: On 10/07/2015 02:48 PM, Pavel Březina wrote: No big deal... 0001-intg-fix-typos.patch From 923d5626fd3cefaf0620c64aecacfba26b439250 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 7 Oct 2015

Re: [SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 12:19:17PM +0200, Jakub Hrozek wrote: > On Thu, Oct 08, 2015 at 09:49:51AM +0200, Lukas Slebodnik wrote: > > On (04/10/15 21:51), Jakub Hrozek wrote: > > >On Fri, Oct 02, 2015 at 11:26:33AM +0200, Lukas Slebodnik wrote: > > >> ehlo, > > >> > > >> Attached patch should

Re: [SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 09:49:51AM +0200, Lukas Slebodnik wrote: > On (04/10/15 21:51), Jakub Hrozek wrote: > >On Fri, Oct 02, 2015 at 11:26:33AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> Attached patch should prevent such failures as in commit > >>

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Nikolai Kondrashov
On 10/08/2015 10:32 AM, Lukas Slebodnik wrote: On (07/10/15 20:51), Nikolai Kondrashov wrote: On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote: Hi everyone, Here is a patch set fixing some things in integration tests and adding more LDAP tests: * Adding/removing a user/group/membership

Re: [SSSD] More upstream CI tests

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 11:02:39AM +0200, Pavel Reichl wrote: > Yes, that would be better. On the other hand one of guidelines that our team > should follow is: "Don't ask for permission ask for forgiveness". I did so > and found real bugs that would be hit with customers. Unless there will be >

Re: [SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

2015-10-08 Thread Lukas Slebodnik
On (08/10/15 13:53), Jakub Hrozek wrote: >On Thu, Oct 08, 2015 at 01:49:11PM +0200, Jakub Hrozek wrote: >> On Thu, Oct 08, 2015 at 12:19:17PM +0200, Jakub Hrozek wrote: >> > On Thu, Oct 08, 2015 at 09:49:51AM +0200, Lukas Slebodnik wrote: >> > > On (04/10/15 21:51), Jakub Hrozek wrote: >> > > >On

Re: [SSSD] [PATCH] typos in integration tests

2015-10-08 Thread Pavel Reichl
On 10/08/2015 01:43 PM, Pavel Březina wrote: -- 2.1.0 Sure, I found out few more typos. New patch is attached. Thanks, ACK. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] util: Include disabled domains in link_forest_roots

2015-10-08 Thread Michal Židek
On 10/02/2015 03:34 PM, Michal Židek wrote: On 10/02/2015 07:44 AM, Lukas Slebodnik wrote: On (01/10/15 15:41), Michal Židek wrote: On 10/01/2015 03:08 PM, Lukas Slebodnik wrote: On (01/10/15 13:56), Michal Židek wrote: On 09/16/2015 03:56 PM, Michal Židek wrote: On 09/15/2015 04:03 PM,

Re: [SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 01:49:11PM +0200, Jakub Hrozek wrote: > On Thu, Oct 08, 2015 at 12:19:17PM +0200, Jakub Hrozek wrote: > > On Thu, Oct 08, 2015 at 09:49:51AM +0200, Lukas Slebodnik wrote: > > > On (04/10/15 21:51), Jakub Hrozek wrote: > > > >On Fri, Oct 02, 2015 at 11:26:33AM +0200, Lukas

Re: [SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 01:56:38PM +0200, Lukas Slebodnik wrote: > On (08/10/15 13:53), Jakub Hrozek wrote: > >On Thu, Oct 08, 2015 at 01:49:11PM +0200, Jakub Hrozek wrote: > >> On Thu, Oct 08, 2015 at 12:19:17PM +0200, Jakub Hrozek wrote: > >> > On Thu, Oct 08, 2015 at 09:49:51AM +0200, Lukas

Re: [SSSD] [PATCH] HBAC: remove misleading comment about deny rules

2015-10-08 Thread Michal Židek
On 10/05/2015 03:44 PM, Pavel Reichl wrote: Hello, please see trivial patch attached. Thanks! Ack. I do not think this needs CI because it is just comment removal. Michal ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] sss_override fixes

2015-10-08 Thread Pavel Reichl
On 10/08/2015 01:45 PM, Pavel Březina wrote: On 10/07/2015 04:14 PM, Pavel Reichl wrote: On 10/07/2015 04:12 PM, Pavel Reichl wrote: On 10/07/2015 02:46 PM, Pavel Březina wrote: Hi, the first two patches are just nitpicks. The last patch fixes a memory violation.

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Nikolai Kondrashov
On 10/08/2015 11:39 AM, Lukas Slebodnik wrote: On (08/10/15 10:33), Pavel Reichl wrote: On 10/08/2015 09:32 AM, Lukas Slebodnik wrote: Pavel R., could these patches used with your tests for local override? LS I'll have to amend the patches, but that was agreed to. Seems that

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Lukas Slebodnik
On (08/10/15 16:29), Nikolai Kondrashov wrote: >On 10/08/2015 11:39 AM, Lukas Slebodnik wrote: >>On (08/10/15 10:33), Pavel Reichl wrote: >>> >>> >>>On 10/08/2015 09:32 AM, Lukas Slebodnik wrote: Pavel R., could these patches used with your tests for local override? LS

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-08 Thread Pavel Reichl
On 10/08/2015 03:50 PM, Nikolai Kondrashov wrote: On 10/08/2015 04:48 PM, Lukas Slebodnik wrote: On (08/10/15 16:29), Nikolai Kondrashov wrote: On 10/08/2015 11:39 AM, Lukas Slebodnik wrote: On (08/10/15 10:33), Pavel Reichl wrote: On 10/08/2015 09:32 AM, Lukas Slebodnik wrote: Pavel

Re: [SSSD] [PATCH] LDAP: Inform about small range size

2015-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2015 05:16 AM, Lukas Slebodnik wrote: > On (23/01/15 12:27), Stephen Gallagher wrote: >> On Fri, 2015-01-23 at 17:27 +0100, Jakub Hrozek wrote: >>> On Fri, Jan 23, 2015 at 05:24:51PM +0100, Michal Židek wrote: On 01/23/2015 04:35 PM,

[SSSD] [PATCH] intg: A couple of improvements

2015-10-08 Thread Nikolai Kondrashov
Hi everyone, Here are the integration test code improvement patches taken out of the "intg: Add more LDAP tests" patch set to speed up merging. These are supposed to have PEP8 errors/warnings fixed. Nick >From a1bb94e87ef4c9e9e5ff39b8d2ee8682538a450c Mon Sep 17 00:00:00 2001 From: Nikolai

Re: [SSSD] [PATCH] sss_override fixes

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 02:01:31PM +0200, Pavel Reichl wrote: > ACK, I'm not rerunning CI as only thing changed is a commit message. master: * 3119225929463aecfbb1a7fc953263736955271e * 220a4cbb7fcf30d954b2b4fecd62887373aa8764 * 1bf0ada00f59c153fe00853394508021d0ff9b24 sssd-1-13:

Re: [SSSD] [PATCH] intg: A couple of improvements

2015-10-08 Thread Nikolai Kondrashov
On 10/08/2015 08:43 PM, Nikolai Kondrashov wrote: Hi everyone, Here are the integration test code improvement patches taken out of the "intg: Add more LDAP tests" patch set to speed up merging. These are supposed to have PEP8 errors/warnings fixed. CI results:

Re: [SSSD] I would like to move these tickets out of 1.13

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 11:22:38PM +0200, Jakub Hrozek wrote: > Hi, > > because we had quite a few tickets targetting 1.13 in this week's triage > bucket, I would like to move some out of the 1.13 buckets. > > Here are my proposals, feel free to go through 1.13.2/1.13.3 and propose > your own:

[SSSD] I would like to move these tickets out of 1.13

2015-10-08 Thread Jakub Hrozek
Hi, because we had quite a few tickets targetting 1.13 in this week's triage bucket, I would like to move some out of the 1.13 buckets. Here are my proposals, feel free to go through 1.13.2/1.13.3 and propose your own: * https://fedorahosted.org/sssd/ticket/2605 - Skip replication

Re: [SSSD] [PATCH] tests: Fix compilation warning

2015-10-08 Thread Lukas Slebodnik
On (08/10/15 20:39), Jakub Hrozek wrote: >Anybody knows why Coverity wouldn't catch this? > >(I can provide link to a coverity job upon request..) IIRC coverity uses spec file(src.rpm) for building and does not run "%check" part of rpmbuild. >From 539f766b0fa8b2a8f9cf2a0af734ceee488195ae Mon Sep

Re: [SSSD] [PATCH] cache_req: support UPN

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 08:34:17PM +0200, Jakub Hrozek wrote: > On Thu, Oct 08, 2015 at 01:21:29PM +0200, Pavel Březina wrote: > > On 10/07/2015 04:28 PM, Sumit Bose wrote: > > >On Wed, Oct 07, 2015 at 04:22:31PM +0200, Sumit Bose wrote: > > >>On Wed, Oct 07, 2015 at 02:42:18PM +0200, Pavel

Re: [SSSD] [PATCH] intg: fix assert messages in test_memory_cache

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 05:18:12PM +0200, Michal Židek wrote: > On 10/06/2015 08:41 PM, Pavel Reichl wrote: > >Hello, please see simple patch attached. > > > > > ACK. > > CI link: > http://sssd-ci.duckdns.org/logs/job/29/59/summary.html > > Michal * master:

Re: [SSSD] [PATCH] cache_req: support UPN

2015-10-08 Thread Jakub Hrozek
On Wed, Oct 07, 2015 at 04:28:02PM +0200, Sumit Bose wrote: > From 3d5352977ca07f8a1a6d3bbaa57d11b54fd705d0 Mon Sep 17 00:00:00 2001 > From: Sumit Bose > Date: Wed, 7 Oct 2015 15:22:34 +0200 > Subject: [PATCH 3/3] nss: fix UPN lookups for sub-domain users This one should go to

Re: [SSSD] [PATCH] typos in integration tests

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 01:56:47PM +0200, Pavel Reichl wrote: > > > On 10/08/2015 01:43 PM, Pavel Březina wrote: > -- 2.1.0 > > > >Sure, I found out few more typos. New patch is attached. > > Thanks, ACK. * master: f106125bbd8f038a93d3fabe36899391c215f937

Re: [SSSD] [PATCH] cache_req: support UPN

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 01:21:29PM +0200, Pavel Březina wrote: > On 10/07/2015 04:28 PM, Sumit Bose wrote: > >On Wed, Oct 07, 2015 at 04:22:31PM +0200, Sumit Bose wrote: > >>On Wed, Oct 07, 2015 at 02:42:18PM +0200, Pavel Březina wrote: > >>>On 10/06/2015 03:16 PM, Pavel Březina wrote: > On

[SSSD] [PATCH] tests: Fix compilation warning

2015-10-08 Thread Jakub Hrozek
Anybody knows why Coverity wouldn't catch this? (I can provide link to a coverity job upon request..) >From 539f766b0fa8b2a8f9cf2a0af734ceee488195ae Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 8 Oct 2015 20:38:26 +0200 Subject: [PATCH] tests: Fix compilation

Re: [SSSD] [PATCH] HBAC: remove misleading comment about deny rules

2015-10-08 Thread Jakub Hrozek
On Thu, Oct 08, 2015 at 02:31:34PM +0200, Michal Židek wrote: > On 10/05/2015 03:44 PM, Pavel Reichl wrote: > >Hello, > > > >please see trivial patch attached. > > > >Thanks! > > > > Ack. I do not think this needs CI > because it is just comment removal. > > Michal * master: