[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

On Mon, 2016-03-07 at 18:40 +0100, Lukas Slebodnik wrote: > On (07/03/16 11:29), Simo Sorce wrote: > >On Mon, 2016-03-07 at 16:58 +0100, Lukas Slebodnik wrote: > >> On (04/03/16 16:42), Simo Sorce wrote: > >> >On Fri, 2016-03-04 at 21:27 +0100, Lukas Slebodnik wrote: > >> >> On (02/03/16 10:02),

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

On (07/03/16 11:29), Simo Sorce wrote: >On Mon, 2016-03-07 at 16:58 +0100, Lukas Slebodnik wrote: >> On (04/03/16 16:42), Simo Sorce wrote: >> >On Fri, 2016-03-04 at 21:27 +0100, Lukas Slebodnik wrote: >> >> On (02/03/16 10:02), Simo Sorce wrote: >> >> >On Wed, 2016-03-02 at 15:34 +0100, Lukas

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

On Mon, 2016-03-07 at 16:58 +0100, Lukas Slebodnik wrote: > On (04/03/16 16:42), Simo Sorce wrote: > >On Fri, 2016-03-04 at 21:27 +0100, Lukas Slebodnik wrote: > >> On (02/03/16 10:02), Simo Sorce wrote: > >> >On Wed, 2016-03-02 at 15:34 +0100, Lukas Slebodnik wrote: > >> >> On (01/03/16 18:28),

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

On (04/03/16 16:42), Simo Sorce wrote: >On Fri, 2016-03-04 at 21:27 +0100, Lukas Slebodnik wrote: >> On (02/03/16 10:02), Simo Sorce wrote: >> >On Wed, 2016-03-02 at 15:34 +0100, Lukas Slebodnik wrote: >> >> On (01/03/16 18:28), Simo Sorce wrote: >> >> >On Tue, 2016-03-01 at 18:22 -0500, Simo

[SSSD] [PATCH] BUILD: Simplify build of cwrap tests

ehlo, Attached patch should speed up build a little bit. But the main purspose is to sipmplify src/tests/cwrap/Makefile.am LS >From dd85774c081ff4ae1f1eb968018b8396c56232b9 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 7 Mar 2016 16:39:12 +0100 Subject: [PATCH]

[SSSD] Re: Design stub: performance enhancements for 1.14

On Sat, Mar 05, 2016 at 05:09:00PM +0100, Sumit Bose wrote: > On Wed, Mar 02, 2016 at 05:13:40PM +0100, Jakub Hrozek wrote: > > On Mon, Feb 22, 2016 at 12:03:32PM +0100, Sumit Bose wrote: > > > On Mon, Feb 22, 2016 at 11:45:21AM +0100, Jakub Hrozek wrote: > > > > On Mon, Feb 22, 2016 at 11:26:34AM

[SSSD] [PATCH] SPEC: Run extra unit tests with epel

ehlo, simple patch is attached. LS >From 1a6bb8a3adf99bdc0b81202c568c56302ebdf9ad Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 7 Mar 2016 14:59:16 +0100 Subject: [PATCH] SPEC: Run extra unit tests with epel libcmocka and cwrap is available in epel which is

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 01:11 PM, Pavel Březina wrote: Hi, see comments inline. errno_t sysdb_search_sudo_rules(TALLOC_CTX *mem_ctx, struct sss_domain_info *domain, const char *sub_filter, const char **attrs,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/03/2016 02:15 PM, Pavel Březina wrote: On 03/03/2016 02:00 PM, Petr Cech wrote: Hi, I found an interesting thing. I wonder if this is a bug or not. I tried to write a test for sysdb_sudo_store() function: # src/db/sysdb_sudo.h errno_t sysdb_sudo_store (struct * sss_domain_info domain,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some, but there were troubles with memory leak.

[SSSD] Re: [PATCH] TOOLS: Prevent dereference of null pointer

On Mon, Mar 07, 2016 at 01:33:38PM +0100, Lukas Slebodnik wrote: > On (07/03/16 12:12), Pavel Březina wrote: > >On 03/07/2016 10:14 AM, Lukas Slebodnik wrote: > >>ehlo, > >> > >>simple aptch is attached. > > > >When there, can you also talloc_free(attrs) on error? Thanks. > See updated patch > >

[SSSD] Re: [PATCH] TOOLS: Prevent dereference of null pointer

On (07/03/16 12:12), Pavel Březina wrote: >On 03/07/2016 10:14 AM, Lukas Slebodnik wrote: >>ehlo, >> >>simple aptch is attached. > >When there, can you also talloc_free(attrs) on error? Thanks. See updated patch LS >From 7e70c88277d7ae3f7b953af51da4e97917923fda Mon Sep 17 00:00:00 2001 From:

[SSSD] Re: RFC: Remove conditional build for sudo?

On (07/03/16 12:48), Pavel Březina wrote: >I'm just reviewing Petr's sudo rule invalidation patches and when I hit > >>+case TYPE_SUDO_RULE: >>+type_string = "sudo_rule"; >>+#ifdef BUILD_SUDO >>+ret = sysdb_search_sudo_rules(ctx, dinfo, >>+

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some, but there were troubles with memory leak. Maybe I haven't understood necessary logic

[SSSD] RFC: Remove conditional build for sudo?

I'm just reviewing Petr's sudo rule invalidation patches and when I hit +case TYPE_SUDO_RULE: +type_string = "sudo_rule"; +#ifdef BUILD_SUDO +ret = sysdb_search_sudo_rules(ctx, dinfo, + filter, attrs, _count, ); +#else /* BUILD_SUDO */ +

[SSSD] Re: [PATCH] TOOLS: Prevent dereference of null pointer

On 03/07/2016 10:14 AM, Lukas Slebodnik wrote: ehlo, simple aptch is attached. When there, can you also talloc_free(attrs) on error? Thanks. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [PATCH] SUDO: be able to parse modifyTimestamp correctly

One way to fix this would be to revert: f58ffb26aeaae0642a149643672fa59ec01a3a36 1476d5348fcf387e7481d833becbd993d91f8019 These patches simplified the entryUSN fitler from (&(entryUSN >= $last)(entryUSN != $last)) to (entryUSN >= $last + 1). This was requested by Thierry to improve

[SSSD] [PATCH] BUILD: Remove unused include directories

ehlo, We do not have the "include" directory in git and such directory is not generated by autotools in build directory either. LS >From af446928a2a18ebc17f17f33a2563dd2dd0c637c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 19:05:46 +0100 Subject:

[SSSD] UTIL: Fix warning misleading-indentation

ehlo, There are new warnings with gcc-6.0 LS >From 2561af75f5d0ccff51ed8f88a48fb685b83e91e1 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 15:15:20 +0100 Subject: [PATCH 1/2] UTIL: Fix indentation in dlinklist.h --- src/util/dlinklist.h | 130

[SSSD] [PATCH] TOOLS: Prevent dereference of null pointer

ehlo, simple aptch is attached. LS >From b0f5ccffb400d6dc8b23208239adc6522b0622c0 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 18:57:22 +0100 Subject: [PATCH] TOOLS: Prevent dereference of null pointer VAR_CHECK is called with (var, EOK, ...) EOK