[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-10 Thread Petr Cech
On 08/03/2016 12:34 PM, Michal Židek wrote: Two nitpicks, see inline. On 07/22/2016 02:34 PM, Petr Cech wrote: +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, + struct sysdb_attrs *attrs, + const char *ext_key,

[SSSD] Re: [PATCH] sudo man page: say that we support IPA schema

2016-08-10 Thread Dan Lavu
I asked Lukas this but he wasn't positive, is the objectClasses different when adding 'ldap_sudo_search_base' ? Or is it just location? Eitherway, I think this is going to be a little more concise, "When SSSD is configured and using the IPA provider, sudo is automatically enabled. The sudo sea

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-10 Thread Michal Židek
On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: On (10/08/16 17:41), Michal Židek wrote: Hi, see the attached patch. I modified the detection of duplicates when extending the maps (sysdb_attr:ldap_attr). When we try to add entry to the map that already exists in the map, then without this patc

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-10 Thread Lukas Slebodnik
On (10/08/16 17:41), Michal Židek wrote: >Hi, > >see the attached patch. > >I modified the detection of duplicates when >extending the maps (sysdb_attr:ldap_attr). > >When we try to add entry to the map >that already exists in the map, then >without this patch we will fail. > >With this patch, we o

[SSSD] Re: [PATCH] Fixed some typos in man pages

2016-08-10 Thread Dan Lavu
Just looked at this now, didnt realize it was just two lines, changes look good. ;) On Thu, Aug 4, 2016 at 5:25 AM, Jakub Hrozek wrote: > On Wed, Aug 03, 2016 at 09:46:46AM +0200, Fabiano Fidêncio wrote: > > On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf > wrote: > > > > > > > > >

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-10 Thread Justin Stephenson
On 08/09/2016 05:41 AM, Jakub Hrozek wrote: On Fri, Aug 05, 2016 at 12:09:27PM -0400, Justin Stephenson wrote: Hi Lukas, I sent a response on July 6th but perhaps there was an issue with the mailing list or some reason it did not go through. Yes, we had issues with the mailing list back then

[SSSD] [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-10 Thread Michal Židek
Hi, see the attached patch. I modified the detection of duplicates when extending the maps (sysdb_attr:ldap_attr). When we try to add entry to the map that already exists in the map, then without this patch we will fail. With this patch, we only fail if the newly added extension would redefine

[SSSD] Re: [PATCH] Handle unparseable names in the simple access list correctly

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 03:35:39PM +0200, Lukas Slebodnik wrote: > ACK Thank you for the careful review. Pushed to master: * 95de2cd9ea8083115f3bbbf0867aaf6b218cb624 * c777f575b0ec0c48ce3b85ea2c5cc298db02450e * 79ac0e8a4840202c3615d6ce6584df3c08efb594 * d2902de03738a3018445698650d8

[SSSD] Re: [PATCH] Handle unparseable names in the simple access list correctly

2016-08-10 Thread Lukas Slebodnik
On (29/07/16 11:44), Lukas Slebodnik wrote: >On (26/07/16 15:00), Jakub Hrozek wrote: >>Hi, >> >>please see the attached patches. I'm not sure how this bug got in, >>because in the patch that broke the functionality >>(eef359b508b898ae99d2bf292a43f0f295a2ba5e) I said in the commit message >>that I

[SSSD] Re: [PATCH] dyndns-tests: Fix false positive failures

2016-08-10 Thread Lukas Slebodnik
On (10/08/16 09:07), Petr Cech wrote: >On 08/10/2016 08:28 AM, Petr Cech wrote: >> On 08/10/2016 08:15 AM, Lukas Slebodnik wrote: >> > On (10/08/16 08:11), Lukas Slebodnik wrote: >> > > On (10/08/16 08:09), Lukas Slebodnik wrote: >> > > > ehlo, >> > > > >> > > > yesterdat, I build a sssd in copr f

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-10 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 02:16:11PM +0200, Jakub Hrozek wrote: > On Fri, Aug 05, 2016 at 01:28:36PM +0200, Lukas Slebodnik wrote: > > and does not apply anymore on current master > > ACK (CI pending). > > I did some performance tests with systemtap and the performance hit was > there, but very sma

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-10 Thread Michal Židek
On 08/10/2016 11:35 AM, Jakub Hrozek wrote: On Wed, Aug 10, 2016 at 12:02:18PM +0300, Alexander Bokovoy wrote: On Tue, 09 Aug 2016, Michal Židek wrote: Summary for Alexander (in CC): - Regarding processing GPOs on the client. - If groupPolicyContainer in AD has attribute gPCMachineExtensionNa

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 08:08:03AM +0200, Petr Cech wrote: > On 08/10/2016 07:30 AM, Petr Cech wrote: > > On 08/09/2016 07:10 PM, Lukas Slebodnik wrote: > > > On (09/08/16 10:21), Jakub Hrozek wrote: > > > > On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote: > > > > > ehlo, > > > > >

[SSSD] Re: The sorry state of code documentation

2016-08-10 Thread Nikolai Kondrashov
Hi Pavel, Thank you for your thoughtful and weighted response. Please see my comments below. On 07/25/2016 11:56 AM, Pavel Březina wrote: Hi Nick, when I joined SSSD I used to document everything, exactly the way you do. But I was trained by Jakub not to do it and in time I started to see benef

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 12:02:18PM +0300, Alexander Bokovoy wrote: > On Tue, 09 Aug 2016, Michal Židek wrote: > > Summary for Alexander (in CC): > > - Regarding processing GPOs on the client. > > - If groupPolicyContainer in AD has attribute > > gPCMachineExtensionNames that contains only whitespa

[SSSD] Re: [PATCH] Handle unparseable names in the simple access list correctly

2016-08-10 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 03:08:52PM +0200, Jakub Hrozek wrote: > On Fri, Jul 29, 2016 at 02:59:46PM +0200, Lukas Slebodnik wrote: > > On (29/07/16 13:01), Jakub Hrozek wrote: > > >On Fri, Jul 29, 2016 at 11:44:53AM +0200, Lukas Slebodnik wrote: > > >> On (26/07/16 15:00), Jakub Hrozek wrote: > > >>

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-10 Thread Alexander Bokovoy
On Tue, 09 Aug 2016, Michal Židek wrote: Summary for Alexander (in CC): - Regarding processing GPOs on the client. - If groupPolicyContainer in AD has attribute gPCMachineExtensionNames that contains only whitespaces, SSSD fails to process GPOs and denies access to users - if the gPCMachineExte

[SSSD] Re: [PATCH] intg: Allow to test netgroups

2016-08-10 Thread Lukas Slebodnik
On (10/08/16 09:24), Petr Cech wrote: >On 08/09/2016 07:09 PM, Lukas Slebodnik wrote: >> ehlo, >> >> attcheck patch is a python wrapper for >> netgroup lookups in sssd. >> >> LS > >Hello Lukas, > >thank you for this patch. You helped me. > >CI passed: >http://sssd-ci.duckdns.org/logs/job/51/24/su

[SSSD] Re: [PATCH] config_schema: Add ldap_user_email to schema

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 09:25:20AM +0200, Lukas Slebodnik wrote: > On (10/08/16 09:13), Fabiano Fidêncio wrote: > >On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik wrote: > >> ehlo, > >> > >> yet another oneliner. > >> It reminds me that we should generate either schema or > >> data for python tes

[SSSD] Re: [PATCH] config_schema: Add ldap_user_email to schema

2016-08-10 Thread Lukas Slebodnik
On (10/08/16 09:13), Fabiano Fidêncio wrote: >On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik wrote: >> ehlo, >> >> yet another oneliner. >> It reminds me that we should generate either schema or >> data for python test. > >LGTM. Although, I'm not sure what you mean by generating either schema >o

[SSSD] Re: [PATCH] config_schema: Add ldap_user_email to schema

2016-08-10 Thread Lukas Slebodnik
On (10/08/16 09:13), Fabiano Fidêncio wrote: >On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik wrote: >> ehlo, >> >> yet another oneliner. >> It reminds me that we should generate either schema or >> data for python test. > >LGTM. Although, I'm not sure what you mean by generating either schema >o

[SSSD] Re: [PATCH] intg: Allow to test netgroups

2016-08-10 Thread Petr Cech
On 08/09/2016 07:09 PM, Lukas Slebodnik wrote: ehlo, attcheck patch is a python wrapper for netgroup lookups in sssd. LS Hello Lukas, thank you for this patch. You helped me. CI passed: http://sssd-ci.duckdns.org/logs/job/51/24/summary.html I found one nitpick, comment is in code bellow.

[SSSD] Re: [PATCH] config_schema: Add ldap_user_email to schema

2016-08-10 Thread Fabiano Fidêncio
On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik wrote: > ehlo, > > yet another oneliner. > It reminds me that we should generate either schema or > data for python test. LGTM. Although, I'm not sure what you mean by generating either schema or data for python tests. > > LS > > _

[SSSD] Re: [PATCH] dyndns-tests: Fix false positive failures

2016-08-10 Thread Petr Cech
On 08/10/2016 08:28 AM, Petr Cech wrote: On 08/10/2016 08:15 AM, Lukas Slebodnik wrote: On (10/08/16 08:11), Lukas Slebodnik wrote: On (10/08/16 08:09), Lukas Slebodnik wrote: ehlo, yesterdat, I build a sssd in copr for various distributions and the dyndns-tests failed for me few time. We had