[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread lslebodn
lslebodn commented on a pull request """ On (02/09/16 08:37), celestian wrote: >I wrote the conditions in fully way for clarity. Yes, it is possible to write >it in condensed way. > >My question in note is about which type of our CI I can use. It is in memberof >plugin. I don't see any test for

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread celestian
celestian commented on a pull request """ I wrote the conditions in fully way for clarity. Yes, it is possible to write it in condensed way. My question in note is about which type of our CI I can use. It is in memberof plugin. I don't see any test for memberof plugin at all. """ See the full

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread fidencio
fidencio commented on a pull request """ I basically agree with Martin here. IMO the code could be simplified a little bit more, something like: `if (mod_ctx->membel == NULL && (mod_ctx->ghel == NULL || mod_ctx->ghel->num_values == 0))` Fabiano Fidêncio """ See the full comment at https://

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread fidencio
fidencio commented on a pull request """ I basically agree with Martin here. IMO the code could be a bit simplified a little bit more, something like: `if (mod_ctx->membel == NULL && (mod_ctx->ghel == NULL || mod_ctx->ghel->num_values == 0))` Fabiano Fidêncio """ See the full comment at ht

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread fidencio
fidencio commented on a pull request """ Sorry for the noise in this PR, but I'm just testing whether my surname will break Martin's script again or not. Fabiano Fidêncio """ See the full comment at https://github.com/SSSD/sssd/pull/13#issuecomment-244397795 ___

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread fidencio
fidencio commented on a pull request """ Sorry for the noise in this PR, but I'm just testing whether my surname will break Martin's script again or not. Fabiano Fidêncio """ See the full comment at https://github.com/SSSD/sssd/pull/13#issuecomment-244397795 ___

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread mbasti-rh
mbasti-rh commented on a pull request """ IMO you can use `mod_ctx->membel == NULL` only once ``` if (mod_ctx->membel == NULL && ( mod_ctx->ghel == NULL || (mod_ctx->ghel != NULL && mod_ctx->ghel->num_values == 0) )) ``` Just saying, mainly I want to test utf-8 notifications :) M

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Petr Cech
On 09/02/2016 03:31 PM, Justin Stephenson wrote: On 09/02/2016 05:23 AM, Petr Cech wrote: On 09/01/2016 03:36 PM, Justin Stephenson wrote: On 08/30/2016 03:54 AM, Jakub Hrozek wrote: On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote: Hello, The attached patches resolve http

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Justin Stephenson
On 09/02/2016 05:23 AM, Petr Cech wrote: On 09/01/2016 03:36 PM, Justin Stephenson wrote: On 08/30/2016 03:54 AM, Jakub Hrozek wrote: On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote: Hello, The attached patches resolve https://fedorahosted.org/sssd/ticket/3142 However, I am

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (opened)

2016-09-02 Thread celestian
celestian's pull request #13: "MEMBEROF: Don't resolve members if they are removed" was opened PR body: """ ## TOPIC If we need remove ghost (SYSDB_GHOST, DB_GHOST) attribute from group we use empty structure. This doesn't mean that there is pointer to NULL but it means that there is zero elemen

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread celestian
celestian commented on a pull request """ Note: Please, which type of our CI is the best for tests? """ See the full comment at https://github.com/SSSD/sssd/pull/13#issuecomment-244375070 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org ht

[SSSD] [sssd PR#12] failover: proceed normally when no new server is found (opened)

2016-09-02 Thread pbrezina
pbrezina's pull request #12: "failover: proceed normally when no new server is found" was opened PR body: """ https://fedorahosted.org/sssd/ticket/3131 I couldn't reproduce manually so I used the second patch as a by-code reproducer. If you apply the patch then sssd will try to resolve meta ser

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Petr Cech
On 09/02/2016 11:23 AM, Petr Cech wrote: On 09/01/2016 03:36 PM, Justin Stephenson wrote: On 08/30/2016 03:54 AM, Jakub Hrozek wrote: On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote: Hello, The attached patches resolve https://fedorahosted.org/sssd/ticket/3142 However, I am

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-02 Thread Petr Cech
On 09/01/2016 03:36 PM, Justin Stephenson wrote: On 08/30/2016 03:54 AM, Jakub Hrozek wrote: On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote: Hello, The attached patches resolve https://fedorahosted.org/sssd/ticket/3142 However, I am having difficult with the man page additi

[SSSD] Re: [PATCH SYSDB: Fix handling of version in sysdb_cache_connect_helper

2016-09-02 Thread Lukas Slebodnik
On (01/09/16 18:15), Fabiano Fidêncio wrote: >On Thu, Sep 1, 2016 at 6:02 PM, Lukas Slebodnik wrote: >> On (01/09/16 17:22), Fabiano Fidêncio wrote: >>>On Thu, Sep 1, 2016 at 5:12 PM, Lukas Slebodnik wrote: On (30/08/16 17:07), Lukas Slebodnik wrote: >On (30/08/16 16:59), Fabiano Fidênci