[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (comment)

2016-09-07 Thread mzidek-rh
mzidek-rh commented on a pull request """ The patches from PR are included in PR #18 . Labeling this one as rejected. """ See the full comment at https://github.com/SSSD/sssd/pull/16#issuecomment-245437017 ___ sssd-devel mailing list sssd-devel@lists.f

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (+Pushed)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/18 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.o

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (+Rejected)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" label *Rejected* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/16 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (-Changes requested)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/16 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fe

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread lslebodn
lslebodn commented on a pull request """ On (07/09/16 09:51), fidencio wrote: >A few minors in the commit messages that should be fixed before pushing. > >Patch0001: TOOLS: Fix a typo in groupadd() >Remove the four spaces before the link of the trac ticket. > >Patch0002: TOOLS: sss_groupshow did n

[SSSD] Re: [PATCH] failover: proceed normally when no new server is found

2016-09-07 Thread Jakub Hrozek
On Thu, Sep 01, 2016 at 02:02:40PM +0200, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/3131 > > I couldn't reproduce manually so I used the second patch as a by-code > reproducer. If you apply the patch then sssd will try to resolve meta server > twice simultaneously and triggering

[SSSD] Re: MONITOR: Add disable_netlink sssd.conf option

2016-09-07 Thread Jakub Hrozek
Hi, sorry to come late, but I have one more request (last one, I promise..) On Thu, Sep 01, 2016 at 09:36:32AM -0400, Justin Stephenson wrote: > From f647e732c2a5b8727376dded962766fb03bb5ea8 Mon Sep 17 00:00:00 2001 > From: Justin Stephenson > Date: Fri, 26 Aug 2016 15:15:32 -0400 > Subject: [PA

[SSSD] [sssd PR#20] sss_override fails to export (opened)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #20: "sss_override fails to export" was opened PR body: """ Here is a fix + CI test for https://fedorahosted.org/sssd/ticket/3179. Michal """ See the full pull-request at https://github.com/SSSD/sssd/pull/20 ... or pull the PR as Git branch: git remote add ghsssd https:/

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 06:09:58AM -0700, Jakub Hrozek wrote: > good idea ah, only when I started to implement this I realized it's already done :) See: https://github.com/SSSD/sssd/blob/master/src/providers/krb5/krb5_child.c#L1364 in the current mast

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (+Accepted)

2016-09-07 Thread jhrozek
jhrozek's pull request #19: "KRB5: Send the output username, not internal fqname to krb5_child" label *Accepted* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/19 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.o

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread fidencio
fidencio commented on a pull request """ A few minors in the commit messages that should be fixed before pushing. Patch0001: TOOLS: Fix a typo in groupadd() Remove the four spaces before the link of the trac ticket. Patch0002: TOOLS: sss_groupshow did not work Patch0003: TESTS: sss_groupadd/grou

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (synchronize)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/18 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/18/head:pr18 git checkout pr18 From 0bcb9

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (comment)

2016-09-07 Thread lslebodn
lslebodn commented on a pull request """ On (07/09/16 08:49), Jakub Hrozek wrote: >btw feel free to ping me on RH IRC for a link that shows the patch fixes the >RH tests.. > When I was looking into this bug https://bugzilla.redhat.com/show_bug.cgi?id=1372753#c7 I verified in gdb that setting kr->

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread lslebodn
lslebodn commented on a pull request """ On (07/09/16 07:18), mzidek-rh wrote: >Hi, > >This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes >fix for the ticket https://fedorahosted.org/sssd/ticket/3178. > >Michal >You can view, comment on, or merge this pull request online

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ btw feel free to ping me on RH IRC for a link that shows the patch fixes the RH tests.. """ See the full comment at https://github.com/SSSD/sssd/pull/19#issuecomment-245325705 ___ sssd-devel mailing list sssd-de

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (opened)

2016-09-07 Thread jhrozek
jhrozek's pull request #19: "KRB5: Send the output username, not internal fqname to krb5_child" was opened PR body: """ Resolves: https://fedorahosted.org/sssd/ticket/3172 krb5_child calls krb5_kuserok() during the access phase which checks if a particular user is allowed to authenticate as

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (closed)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/14 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/14/hea

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread mzidek-rh
mzidek-rh commented on a pull request """ Thanks for the tip Nick. """ See the full comment at https://github.com/SSSD/sssd/pull/18#issuecomment-245304406 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admi

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread spbnick
spbnick commented on a pull request """ Just a hint: if you avoid putting "PR" in front of the PR#16, then you'll get a link to the actual pull request on the GitHub page, plus the target pull request will have a link back. Like this: #16. """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (opened)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" was opened PR body: """ Hi, This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes fix for the ticket https://fedorahosted.org/sssd/ticket/3178. Michal """ See the full pull-request at https://github.com/S

[SSSD] [sssd PR#17] Improve support for gdm Smartcard support (opened)

2016-09-07 Thread sumit-bose
sumit-bose's pull request #17: "Improve support for gdm Smartcard support" was opened PR body: """ Those two patches try to fix two issues related to the Smartcard handling feature of gdm. The first fixes https://fedorahosted.org/sssd/ticket/3165 and the second fixes an issue which was introduced

[SSSD] Re: Getting overridden shell in pam_sss

2016-09-07 Thread Sumit Bose
On Wed, Sep 07, 2016 at 02:34:19PM +0300, Nikolai Kondrashov wrote: > On 09/07/2016 02:18 PM, Sumit Bose wrote: > > On Wed, Sep 07, 2016 at 01:28:12PM +0300, Nikolai Kondrashov wrote: > > > Hi Sumit, > > > > > > Just wanted to tell you I still need an answer to the below. > > > > ah, sorry, I thi

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (+rejected)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *rejected* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list sssd-devel@lists.fed

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (-rejected)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *rejected* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list sssd-devel@lists.f

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (-Changes requested)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (+rejected)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *rejected* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list sssd-devel@lists.fed

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 10:23:13AM -0700, mzidek-rh wrote: > The PR#16 includes jhrozek's patch from this PR as well as CI test + fix for > sss_groupshow. OK, thank you, I will close this one as rejected (just so that we don't track the PR any longer..) "

[SSSD] Re: [RFCv3] NSS tlog integration

2016-09-07 Thread Nikolai Kondrashov
On 08/29/2016 11:47 PM, Sumit Bose wrote: Finally you call sysdb_initgroups_with_views() to get the list of groups the user is a member of and compare them with the groups form the session_recording configuration. Since you compare the DNs I think this can be improved a bit. sysdb_initgroups_with

[SSSD] Re: Getting overridden shell in pam_sss

2016-09-07 Thread Nikolai Kondrashov
On 09/07/2016 02:18 PM, Sumit Bose wrote: On Wed, Sep 07, 2016 at 01:28:12PM +0300, Nikolai Kondrashov wrote: Hi Sumit, Just wanted to tell you I still need an answer to the below. ah, sorry, I think I missed this question while discussing the group lookups with Simo in the other thread. No

[SSSD] Re: Getting overridden shell in pam_sss

2016-09-07 Thread Nikolai Kondrashov
On 09/07/2016 01:48 PM, Pavel Březina wrote: On 08/19/2016 06:39 PM, Nikolai Kondrashov wrote: Hi Sumit, Now I'm again approaching the implementation of tlog integration in pam_sss, and as planned, I need to get the actual user shell to put it into TLOG_REC_SHELL environment variable upon openi

[SSSD] Re: Getting overridden shell in pam_sss

2016-09-07 Thread Sumit Bose
On Wed, Sep 07, 2016 at 01:28:12PM +0300, Nikolai Kondrashov wrote: > Hi Sumit, > > Just wanted to tell you I still need an answer to the below. ah, sorry, I think I missed this question while discussing the group lookups with Simo in the other thread. > > Thanks! > > Nick > > On 08/19/2016 0

[SSSD] Re: Getting overridden shell in pam_sss

2016-09-07 Thread Pavel Březina
On 08/19/2016 06:39 PM, Nikolai Kondrashov wrote: Hi Sumit, Now I'm again approaching the implementation of tlog integration in pam_sss, and as planned, I need to get the actual user shell to put it into TLOG_REC_SHELL environment variable upon opening of the session. However, the get_shell_ove

[SSSD] Re: [RFCv3] NSS tlog integration

2016-09-07 Thread Nikolai Kondrashov
Hi Simo, On 08/29/2016 11:47 PM, Sumit Bose wrote: Then you do a normal user lookup but if there are groups configured in the session_recording section you always do a SSS_DP_INITGROUPS instead of a SSS_DP_USER if the entry is expired. I think here you can add some improvement to reduce the numb

[SSSD] Re: Getting overridden shell in pam_sss

2016-09-07 Thread Nikolai Kondrashov
Hi Sumit, Just wanted to tell you I still need an answer to the below. Thanks! Nick On 08/19/2016 07:39 PM, Nikolai Kondrashov wrote: Now I'm again approaching the implementation of tlog integration in pam_sss, and as planned, I need to get the actual user shell to put it into TLOG_REC_SHELL

[SSSD] My development scripts

2016-09-07 Thread Pavel Březina
Hi folks, while converting my workflow scripts to github [1] I decided to polish them, give them some help and publish them on github. Feel free to use them and improve them as you wish. I'll gladly learn about your workflow and simplification. [1] https://github.com/pbrezina/sssd-dev-utils _

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

2016-09-07 Thread Petr Cech
On 09/07/2016 09:53 AM, Jakub Hrozek wrote: On Wed, Sep 07, 2016 at 08:45:18AM +0200, Lukas Slebodnik wrote: On (05/09/16 16:07), Jakub Hrozek wrote: On Mon, Sep 05, 2016 at 03:32:48PM +0200, Lukas Slebodnik wrote: On (05/09/16 15:24), Jakub Hrozek wrote: On Mon, Sep 05, 2016 at 02:31:31PM +0

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (synchronize)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/16 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/16/head:pr16 git checkout pr16 From 0bcb9c

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 11:49:09AM -0700, lslebodn wrote: > IMHO, it might be better to close this PR. > If we decide to dor support for libini_config < 1.1 or 1.2 > then it will be a different patch anyway. @see my previous comment The only reason I sugges

[SSSD] Re: [PATCH SET] SYSDB: Adding message to inform about cache

2016-09-07 Thread Jakub Hrozek
On Wed, Sep 07, 2016 at 08:45:18AM +0200, Lukas Slebodnik wrote: > On (05/09/16 16:07), Jakub Hrozek wrote: > >On Mon, Sep 05, 2016 at 03:32:48PM +0200, Lukas Slebodnik wrote: > >> On (05/09/16 15:24), Jakub Hrozek wrote: > >> >On Mon, Sep 05, 2016 at 02:31:31PM +0200, Fabiano Fidêncio wrote: > >>

[SSSD] Re: [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

2016-09-07 Thread Fabiano Fidêncio
On Wed, Sep 7, 2016 at 9:03 AM, Lukas Slebodnik wrote: > On (07/09/16 08:46), Fabiano Fidêncio wrote: >>On Wed, Sep 7, 2016 at 8:34 AM, Lukas Slebodnik wrote: >>> On (06/09/16 21:38), Fabiano Fidêncio wrote: On Tue, Sep 6, 2016 at 8:49 PM, lslebodn wrote: > lslebodn commented on a pu

[SSSD] Re: [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

2016-09-07 Thread Lukas Slebodnik
On (07/09/16 08:46), Fabiano Fidêncio wrote: >On Wed, Sep 7, 2016 at 8:34 AM, Lukas Slebodnik wrote: >> On (06/09/16 21:38), Fabiano Fidêncio wrote: >>>On Tue, Sep 6, 2016 at 8:49 PM, lslebodn >>> wrote: lslebodn commented on a pull request """ IMHO, it might be better to close