[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) celestian commented: """ I am sure this is enough. Maybe it is not the most direct solution. I try to explain it: We have user ```Administrator```, sysdb record looks like (minor

[SSSD] [sssd PR#75][synchronized] Add configuirable max payload size limit of a secret

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75 From

[SSSD] [sssd PR#74][closed] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Author: sumit-bose Title: #74: IPA/AD: check auth ctx before using it Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/74/head:pr74 git checkout pr74

[SSSD] [sssd PR#53][-Accepted] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][closed] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Author: fidencio Title: #53: Fixes in the config API related to secrets responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/53/head:pr53 git checkout pr53

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ Since there is no ticket, I only pushed the patches to master: 682c9c3467055c2149af28826f7458b857b0f8c4 da8801c363716533f60bc78e10f3a2100cebc3a1 """ See the full

[SSSD] [sssd PR#53][+Pushed] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ Thanks, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/53#issuecomment-259810451 ___ sssd-devel

[SSSD] [sssd PR#53][+Accepted] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it jhrozek commented: """ master: ea11ed3ea6291488dd762033246edc4ce3951aeb sssd-1-14: 37e070c8c2ea79d8d84bae3da3a34c81212744ab """ See the full comment at

[SSSD] [sssd PR#74][-Accepted] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#74][+Pushed] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/93/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/79#issuecomment-259803386

[SSSD] [sssd PR#69][+Changes requested] krb5: Use command line arguments instead env vars for krb5_child

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#79][opened] LIBSSS_CONFIG: Drop libsss_config

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/79 Author: fidencio Title: #79: LIBSSS_CONFIG: Drop libsss_config Action: opened PR body: """ lib_config has been used only by OpenLMI and the project has been deprecated making, then, no sense to keep the support on SSSD. Distros that, for some

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers jhrozek commented: """ ACK. I won't push the patches until tomorrow though in case @lslebodn or someone else wanted to take a look as well. I'll also wait for CI results. """ See

[SSSD] [sssd PR#68][+Accepted] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder fidencio commented: """ Change done and patchset updated. Just to make things easier for the reviewer, here is what the fix up looks like: ``` [ffidenci@cat sssd]$ git diff diff --git

[SSSD] [sssd PR#53][-Changes requested] Fixes in the config API related to secrets responder

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][+Changes requested] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ On Tue, Nov 08, 2016 at 05:40:21AM -0800, lslebodn wrote: > On (08/11/16 05:15), fidencio wrote: > >@jhrozek: > >For the first patch the tests are correct. @lslebodn

[SSSD] Re: [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread Jakub Hrozek
On Tue, Nov 08, 2016 at 02:40:23PM +0100, lslebodn wrote: > I am fine with the 1st patch. But I am not very familiar with > the secrets code therefore It would take me much more time to review > 2nd patch. I prefer if @jhrozek could review it. I see one glitch there. We should move the provider

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers lslebodn commented: """ I can see that tokengroups are documented in this PR. So I think we can close upstream ticket https://fedorahosted.org/sssd/ticket/3233 as a duplicate of

[SSSD] [sssd PR#68][-Changes requested] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child lslebodn commented: """ The password changed failed for me with this patches. I had also applied patches for PR #77. But I doubt they could cause such change. I tested just

[SSSD] [sssd PR#69][-Accepted] krb5: Use command line arguments instead env vars for krb5_child

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ So, here are some stats about the configure time that you complained before: So, I've ran the contrib/ci/run script on our F25 machine on Jenkins. This is what we have

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ So, here are some stats about the configure time that you complained before: So, I've ran the contrib/ci/run script on our F25 machine on Jenkins. This is what we have

[SSSD] Re: Nested netgroups with IPA provider

2016-11-10 Thread Michal Židek
On 11/10/2016 03:18 PM, Michal Židek wrote: On 11/10/2016 02:13 PM, Lukas Slebodnik wrote: On (10/11/16 13:57), Michal Židek wrote: On 11/10/2016 12:29 PM, Jakub Hrozek wrote: On Thu, Nov 10, 2016 at 10:49:55AM +0100, Michal Židek wrote: Hi, this is continuation of discussion about pull

[SSSD] [sssd PR#78][opened] ipa: Nested netgroups do not work

2016-11-10 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/78 Author: mzidek-rh Title: #78: ipa: Nested netgroups do not work Action: opened PR body: """ We lowercase the keys to the hash table used to store netgroups but do not lowercase it when reading the table. This results in nested netgroups not being

[SSSD] Re: Nested netgroups with IPA provider

2016-11-10 Thread Michal Židek
On 11/10/2016 02:13 PM, Lukas Slebodnik wrote: On (10/11/16 13:57), Michal Židek wrote: On 11/10/2016 12:29 PM, Jakub Hrozek wrote: On Thu, Nov 10, 2016 at 10:49:55AM +0100, Michal Židek wrote: Hi, this is continuation of discussion about pull request 51 and associated tickets. For context,

[SSSD] Re: Nested netgroups with IPA provider

2016-11-10 Thread Lukas Slebodnik
On (10/11/16 13:57), Michal Židek wrote: >On 11/10/2016 12:29 PM, Jakub Hrozek wrote: >> On Thu, Nov 10, 2016 at 10:49:55AM +0100, Michal Židek wrote: >> > Hi, >> > >> > this is continuation of discussion about pull >> > request 51 and associated tickets. >> > >> > For context, see: >> >

[SSSD] Re: Nested netgroups with IPA provider

2016-11-10 Thread Michal Židek
On 11/10/2016 12:29 PM, Jakub Hrozek wrote: On Thu, Nov 10, 2016 at 10:49:55AM +0100, Michal Židek wrote: Hi, this is continuation of discussion about pull request 51 and associated tickets. For context, see: https://github.com/SSSD/sssd/pull/59 https://fedorahosted.org/sssd/ticket/3159

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ Are you sure this is enough? Because when the patch is applied, I see that we only match the sudoUser value with the original case. Don't we also need to match

[SSSD] [sssd PR#39][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ oops...clicked send to early. I meant to say "So the filter never matches the lowercase sudoUser". """ See the full comment at

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it celestian commented: """ I wrote comment to https://fedorahosted.org/sssd/ticket/2818 and I closed https://fedorahosted.org/sssd/ticket/3238. """ See the full comment at

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it celestian commented: """ I wrote comment to t2818 and I closed t3238. """ See the full comment at https://github.com/SSSD/sssd/pull/74#issuecomment-259671320

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it sumit-bose commented: """ opps, sorry, I just opened https://fedorahosted.org/sssd/ticket/3238, feel free to close it as duplicate. """ See the full comment at

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it lslebodn commented: """ On (10/11/16 03:12), celestian wrote: >Code looks good to me. CI tests passed: >http://sssd-ci.duckdns.org/logs/job/56/88/summary.html >And I manually test it. > >@sumit-bose,

[SSSD] Re: Nested netgroups with IPA provider

2016-11-10 Thread Jakub Hrozek
On Thu, Nov 10, 2016 at 10:49:55AM +0100, Michal Židek wrote: > Hi, > > this is continuation of discussion about pull > request 51 and associated tickets. > > For context, see: > https://github.com/SSSD/sssd/pull/59 > https://fedorahosted.org/sssd/ticket/3159 >

[SSSD] [sssd PR#74][+Accepted] IPA/AD: check auth ctx before using it

2016-11-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it celestian commented: """ Code looks good to me. CI tests passed: http://sssd-ci.duckdns.org/logs/job/56/88/summary.html And I manually test it. @sumit-bose, could you please file ticket for witting

[SSSD] Nested netgroups with IPA provider

2016-11-10 Thread Michal Židek
Hi, this is continuation of discussion about pull request 51 and associated tickets. For context, see: https://github.com/SSSD/sssd/pull/59 https://fedorahosted.org/sssd/ticket/3159 https://fedorahosted.org/sssd/ticket/3116 The FreeIPA UQE guys added upstream test for this issue because we do

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ FYI: there is already better ticket https://fedorahosted.org/sssd/ticket/3159 """ See the full comment at https://github.com/SSSD/sssd/pull/59#issuecomment-259633405