[SSSD] [sssd PR#570][comment] p11_child: add OpenSSL support

2018-06-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/570 Title: #570: p11_child: add OpenSSL support sumit-bose commented: """ Yes, all patches from PR #533 are included here as well. """ See the full comment at https://github.com/SSSD/sssd/pull/570#issuecomment-393934077

[SSSD] [sssd PR#570][comment] p11_child: add OpenSSL support

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/570 Title: #570: p11_child: add OpenSSL support jhrozek commented: """ btw can we close PR #553? """ See the full comment at https://github.com/SSSD/sssd/pull/570#issuecomment-393865617 ___ sssd-devel mailing

[SSSD] [sssd PR#570][comment] p11_child: add OpenSSL support

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/570 Title: #570: p11_child: add OpenSSL support jhrozek commented: """ Thank you, the code works and I don't have any more comments. I will run CI and Coverity to be on the safe side before adding the accepted label. """ See the full comment at

[SSSD] [sssd PR#585][comment] tcurl: do not log the payload

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/585 Title: #585: tcurl: do not log the payload jhrozek commented: """ btw since we are trying to get a release out of the door, maybe a stopgap fix could be to just put some #ifdefs around the tcurl print function and then see if we can log the sanitized

[SSSD] [sssd PR#585][comment] tcurl: do not log the payload

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/585 Title: #585: tcurl: do not log the payload jhrozek commented: """ Thank you for working on the issue. The patch works, but I have some suggestions how to improve the code. First, the code is quite expensive. At the very least, it should only ever be

[SSSD] [sssd PR#579][+Changes requested] krb5 locator: add support for multiple addresses and sub-domains

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/579 Title: #579: krb5 locator: add support for multiple addresses and sub-domains Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#579][comment] krb5 locator: add support for multiple addresses and sub-domains

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/579 Title: #579: krb5 locator: add support for multiple addresses and sub-domains jhrozek commented: """ The only issue I found is that the kdcinfo files are note removed when sssd exits. One other thing we might consider is that the krb5_use_kdcinfo

[SSSD] [sssd PR#570][comment] p11_child: add OpenSSL support

2018-06-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/570 Title: #570: p11_child: add OpenSSL support sumit-bose commented: """ oops, sorry, the latest version should fix this. """ See the full comment at https://github.com/SSSD/sssd/pull/570#issuecomment-393853142

[SSSD] [sssd PR#570][comment] p11_child: add OpenSSL support

2018-06-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/570 Title: #570: p11_child: add OpenSSL support jhrozek commented: """ On Thu, May 31, 2018 at 02:02:29AM -0700, sumit-bose wrote: > ah, sorry, I meant /etc/sssd/pki/sssd_auth_ca_db.pem. thank you, this works, but it looks like the directory is not