[SSSD] Re: RFC: Use github's pull requests for tracking submissions

2016-08-19 Thread Jakub Hrozek
On Fri, Aug 19, 2016 at 12:54:25PM +0200, Lukas Slebodnik wrote: > On (19/08/16 11:49), Jakub Hrozek wrote: > >Hi, > > > >sorry for the long mail..the tl;dr is that I would like to propose we use > >github pull-requests as the preferred way of submitting patches i

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-19 Thread Jakub Hrozek
On Fri, Aug 19, 2016 at 12:54:07PM +0200, Petr Cech wrote: > On 08/17/2016 02:37 PM, Petr Cech wrote: > > On 08/12/2016 09:17 AM, Petr Cech wrote: > > > On 08/11/2016 08:53 AM, Petr Cech wrote: > > > > On 08/03/2016 12:34 PM, Michal Židek wrote: > > > > > Two nitpicks, see inline. > > > > > > > >

[SSSD] [PATCH] Add selinux_provider to validator, remove session provider from validator

2016-08-19 Thread Jakub Hrozek
rom: Jakub Hrozek <jhro...@redhat.com> Date: Fri, 19 Aug 2016 11:36:41 +0200 Subject: [PATCH 1/2] CONFIG: selinux_provider is a valid provider type We should not warn about it in the validator and should allow selinux_provider from the config API. --- src/config/SSSDConfig/__init__.py.in |

[SSSD] Re: [SSSD/sssd #5] Miscellanous patches for the sssd-secrets responder (opened)

2016-08-19 Thread Jakub Hrozek
On Fri, Aug 19, 2016 at 10:39:27AM +0200, Lukas Slebodnik wrote: > On (19/08/16 10:25), sssd-github-notificat...@fedorahosted.org wrote: > >jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets > >responder" was opened > > > >PR body: > >The first patch just makes an internal

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-19 Thread Jakub Hrozek
On Thu, Aug 18, 2016 at 12:04:46PM +0200, Lukas Slebodnik wrote: > On (18/08/16 11:41), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 04:37:43PM +0200, Lukas Slebodnik wrote: > >> On (17/08/16 15:39), Lukas Slebodnik wrote: > >> >On (16/08/16 15:22), Lukas Slebodnik

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-18 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 04:37:43PM +0200, Lukas Slebodnik wrote: > On (17/08/16 15:39), Lukas Slebodnik wrote: > >On (16/08/16 15:22), Lukas Slebodnik wrote: > >>On (16/08/16 11:50), Lukas Slebodnik wrote: > >>>On (12/08/16 16:30), Lukas Slebodnik wrote: > >

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-18 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 05:12:44PM +0200, Lukas Slebodnik wrote: > On (09/08/16 19:12), Lukas Slebodnik wrote: > >On (09/08/16 14:54), Jakub Hrozek wrote: > >>On Tue, Aug 09, 2016 at 12:36:11PM +0200, Jakub Hrozek wrote: > >>> On Wed, Aug 03, 2016 at 09:56:40A

[SSSD] Re: [PATCH] sssd-secrets systemd service and small fixes

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 04:25:47PM +0200, Lukas Slebodnik wrote: > On (17/08/16 15:03), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 02:30:15PM +0200, Lukas Slebodnik wrote: > >> On (17/08/16 13:46), Jakub Hrozek wrote: > >> >On Wed, Aug 17, 2016 at 12:49:26P

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 04:28:38PM +0200, Lukas Slebodnik wrote: > On (17/08/16 16:23), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 03:41:29PM +0200, Jakub Hrozek wrote: > >> On Wed, Aug 17, 2016 at 01:16:48PM +0200, Petr Cech wrote: > >> > @@ -379,7 +394,12 @@

[SSSD] Re: [PATCH] SPEC: Own the secrets DB path

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 03:41:54PM +0200, Lukas Slebodnik wrote: > On (17/08/16 13:48), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 09:47:36AM +0200, Jakub Hrozek wrote: > >> On Wed, Aug 17, 2016 at 09:40:38AM +0200, Lukas Slebodnik wrote: > >> > On (16/08

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 04:04:51PM +0200, Jakub Hrozek wrote: > On Wed, Aug 17, 2016 at 12:23:37PM +0200, Petr Cech wrote: > > Thanks Jakub, Lukas. > > > > CI tests almost passed, failure is not connected: > > http://sssd-ci.duckdns.org/logs/job/51/82/summary.ht

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 12:23:37PM +0200, Petr Cech wrote: > Thanks Jakub, Lukas. > > CI tests almost passed, failure is not connected: > http://sssd-ci.duckdns.org/logs/job/51/82/summary.html > > Fixed patch set attached. > > Regards ACK CI:

[SSSD] Re: [PATCH] Add support for disabling netlink use

2016-08-17 Thread Jakub Hrozek
; Kind regards, > > > Justin Stephenson > > > > > > On 08/16/2016 09:32 AM, Jakub Hrozek wrote: > > > > On Fri, Aug 12, 2016 at 11:26:15AM -0400, Justin Stephenson wrote: > > > > > code patch and man page attached, also added the PATCH: prefix to the > >

[SSSD] Re: [PATCH] sssd-secrets systemd service and small fixes

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 02:30:15PM +0200, Lukas Slebodnik wrote: > On (17/08/16 13:46), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 12:49:26PM +0200, Lukas Slebodnik wrote: > >> On (17/08/16 12:27), Jakub Hrozek wrote: > >> >On Wed, Aug 17, 2016 at 10:23:51A

[SSSD] Re: [PATCH] SPEC: Own the secrets DB path

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 09:47:36AM +0200, Jakub Hrozek wrote: > On Wed, Aug 17, 2016 at 09:40:38AM +0200, Lukas Slebodnik wrote: > > On (16/08/16 17:01), Jakub Hrozek wrote: > > >To test, run: > > >rpm -qf /var/lib/sss/secrets/ > > >the directory was unowne

[SSSD] Re: [PATCH] sssd-secrets systemd service and small fixes

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 12:49:26PM +0200, Lukas Slebodnik wrote: > On (17/08/16 12:27), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 10:23:51AM +0200, Lukas Slebodnik wrote: > >> On (15/08/16 16:05), Jakub Hrozek wrote: > >> >From 86a24747f45bdb3caeb8c36d63c74a08aed

[SSSD] Re: [PATCH] SPEC: Own the secrets DB path

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 12:23:17PM +0200, Fabiano Fidêncio wrote: > Jakub, > > On Tue, Aug 16, 2016 at 8:29 PM, Jakub Hrozek <jhro...@redhat.com> wrote: > > On Tue, Aug 16, 2016 at 05:01:55PM +0200, Jakub Hrozek wrote: > >> To test, run: > >> rpm -qf /

[SSSD] Re: [PATCH] sssd-secrets systemd service and small fixes

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 10:23:51AM +0200, Lukas Slebodnik wrote: > On (15/08/16 16:05), Jakub Hrozek wrote: > >From 86a24747f45bdb3caeb8c36d63c74a08aed90421 Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek <jhro...@redhat.com> > >Date: Mon, 15 Aug 2016 14:10:23 +0200 &g

[SSSD] Re: [PATCH] SPEC: Own the secrets DB path

2016-08-17 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 09:40:38AM +0200, Lukas Slebodnik wrote: > On (16/08/16 17:01), Jakub Hrozek wrote: > >To test, run: > >rpm -qf /var/lib/sss/secrets/ > >the directory was unowned before and should be owned by sssd-common now. > > >From a398c91ef196be680f

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 04:29:43PM +0200, Petr Cech wrote: > On 08/16/2016 03:58 PM, Stephen Gallagher wrote: > > On 08/16/2016 09:26 AM, Jakub Hrozek wrote: > > > > On Tue, Aug 16, 2016 at 03:17:19PM +0200, Petr Cech wrote: > > > > > > >>>> From

[SSSD] Re: [PATCH] SPEC: Own the secrets DB path

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 05:01:55PM +0200, Jakub Hrozek wrote: > To test, run: > rpm -qf /var/lib/sss/secrets/ > the directory was unowned before and should be owned by sssd-common now. CI: http://sssd-ci.duckdns.org/logs/job/51/74/summary.html By the way Fabiano asked on IRC wh

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 05:50:19PM +0200, Jakub Hrozek wrote: > On Fri, Aug 12, 2016 at 10:08:19AM -0400, Justin Stephenson wrote: > > Thanks Jakub for your help, updated patch set attached. > > ACK to both, I'll push the patches when CI finishes. CI: http://sssd-ci.duckdns.org

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-16 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 10:08:19AM -0400, Justin Stephenson wrote: > Thanks Jakub for your help, updated patch set attached. ACK to both, I'll push the patches when CI finishes. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] Better error message if sssctl is ran w/o activating the IFP responder

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 04:16:08PM +0200, Petr Cech wrote: > On 08/16/2016 04:06 PM, Justin Stephenson wrote: > > Updated patch attached. > > > > Kind regards, > > Justin Stephenson > > Thanks, Justin. > > Obviously ACK. Umm..I'm by no means a UI designer, but does HINT in ALL CAPS look

[SSSD] [PATCH] SPEC: Own the secrets DB path

2016-08-16 Thread Jakub Hrozek
To test, run: rpm -qf /var/lib/sss/secrets/ the directory was unowned before and should be owned by sssd-common now. >From a398c91ef196be680f6c2d5b2d5251e060005ec0 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Tue, 16 Aug 2016 16:45:36 +0200 Subject: [PATCH]

[SSSD] Re: [PATCH] Add support for disabling netlink use

2016-08-16 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 11:26:15AM -0400, Justin Stephenson wrote: > code patch and man page attached, also added the PATCH: prefix to the commit > message for the code patch. You don't have to add the PATCH prefix, git adds that automatically when you format the patch with "git format-patch".

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 03:17:19PM +0200, Petr Cech wrote: > > > From 24d32d0eb12ddc433e64ffd6411e9e13f0067b35 Mon Sep 17 00:00:00 2001 > > > From: Petr Cech > > > Date: Fri, 13 May 2016 05:21:07 -0400 > > > Subject: [PATCH 1/5] AD_PROVIDER: Add ad_enabled_domains option > > >

[SSSD] Re: [PATCH] DP: Add log message for get account info

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 10:04:27AM +0200, Petr Cech wrote: > On 08/16/2016 09:20 AM, Petr Cech wrote: > > On 08/16/2016 09:17 AM, Lukas Slebodnik wrote: > > > ehlo, > > > > > > Petr improved debug messages in > > >

[SSSD] Re: [PATCH] sssd-secrets systemd service and small fixes

2016-08-15 Thread Jakub Hrozek
On Mon, Aug 15, 2016 at 04:01:13PM +0200, Jakub Hrozek wrote: > Hi, > > attached are three small but important patches related to sssd-secrets. > The context is that I started to write tests and manpage for > sssd-secrets and noticed some issues. I hope the patches themselves

[SSSD] [PATCH] sssd-secrets systemd service and small fixes

2016-08-15 Thread Jakub Hrozek
Hi, attached are three small but important patches related to sssd-secrets. The context is that I started to write tests and manpage for sssd-secrets and noticed some issues. I hope the patches themselves offer a nice commit message. To test the socket activation, you can just install the RPMs

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-15 Thread Jakub Hrozek
On Mon, Aug 15, 2016 at 09:47:27AM +0200, Petr Cech wrote: > On 08/12/2016 04:13 PM, Jakub Hrozek wrote: > > On Fri, Aug 12, 2016 at 03:41:26PM +0200, Petr Cech wrote: > > > On 08/12/2016 03:07 PM, Jakub Hrozek wrote: > > > > > Logs now look like: > > > &g

[SSSD] Re: [PATCH] CONFIG: full_name_format is an allowed option for all domains

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 02:38:44PM +0200, Lukas Slebodnik wrote: > On (12/08/16 14:13), Jakub Hrozek wrote: > >On Fri, Aug 12, 2016 at 01:47:04PM +0200, Lukas Slebodnik wrote: > >> On (12/08/16 07:39), Stephen Gallagher wrote: > >> >On 08/12/2016 07:30 AM, Lukas Sleb

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: > On (10/08/16 20:59), Michal Židek wrote: > >On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: > >> On (10/08/16 17:41), Michal Židek wrote: > >> > Hi, > >> > > >> > see the attached patch. > >> > > >> > I modified the detection of

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 03:41:26PM +0200, Petr Cech wrote: > On 08/12/2016 03:07 PM, Jakub Hrozek wrote: > > > Logs now look like: > > > > > > > > [root@albireo sssd]# grep 'child' sssd_ipa.cygnus.dev.log > > > > [child_handler_setup] (0x2000): Sett

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 02:51:21PM +0200, Petr Cech wrote: > On 08/12/2016 11:27 AM, Jakub Hrozek wrote: > > On Wed, Aug 10, 2016 at 08:54:25AM +0200, Petr Cech wrote: > > > Sorry, I experienced some issue with mailing list. > > > So I send it again. > > &g

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 12:53:25PM +0200, Petr Cech wrote: > On 08/12/2016 11:06 AM, Jakub Hrozek wrote: > > On Thu, Aug 11, 2016 at 02:23:39PM +0200, Petr Cech wrote: > > > On 08/09/2016 02:49 PM, Jakub Hrozek wrote: > > > > On Tue, Aug 09, 2016 at 12:

[SSSD] Re: [PATCH] CONFIG: full_name_format is an allowed option for all domains

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 01:47:04PM +0200, Lukas Slebodnik wrote: > On (12/08/16 07:39), Stephen Gallagher wrote: > >On 08/12/2016 07:30 AM, Lukas Slebodnik wrote: > >> On (12/08/16 13:24), Jakub Hrozek wrote: > >>> Hi, > >>> > >&g

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 11:40:24AM +0200, Pavel Březina wrote: > > I'm sorry, I sent wrong patches. How about now? > Now I have last two comments before I ack :) both are in the largest patch, the other can be considered acked. > From de872fd874b8395f526743f1836dea335726b3ff Mon Sep 17

[SSSD] [PATCH] CONFIG: full_name_format is an allowed option for all domains

2016-08-12 Thread Jakub Hrozek
Hi, a simple one-liner is attached. >From c7bd0b7e695d031258ab47d8c425c9d5843d4069 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Fri, 12 Aug 2016 13:23:16 +0200 Subject: [PATCH] CONFIG: full_name_format is an allowed option for all domains --- src/config/cfg_

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-12 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 12:09:10PM -0400, Justin Stephenson wrote: > > On 08/09/2016 05:41 AM, Jakub Hrozek wrote: > > On Fri, Aug 05, 2016 at 12:09:27PM -0400, Justin Stephenson wrote: > > > Hi Lukas, > > > > > > I sent a response on

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-08-12 Thread Jakub Hrozek
On Thu, Aug 11, 2016 at 11:49:07AM +0200, Pavel Březina wrote: > On 08/09/2016 11:21 AM, Jakub Hrozek wrote: > > On Fri, Aug 05, 2016 at 12:02:19PM +0200, Pavel Březina wrote: > > > On 07/25/2016 12:55 PM, Pavel Březina wrote: > > > > On 07/20/2016 03:03 PM, Jakub

[SSSD] Re: [PATCH] Fix Japanese translation bug

2016-08-12 Thread Jakub Hrozek
On Thu, Aug 11, 2016 at 11:46:23PM +0900, Muneyuki Noguchi wrote: > Hi, > > The attached patch fixes Japanese translation bug > by replacing "kiken", which means danger in Japanese, with "kigen". > This bug was introduced on 19 Jul 2012. Hi Muneyuki-san, I don't speak Japanese, so I really

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-12 Thread Jakub Hrozek
+0200 > From: Petr Cech <pc...@redhat.com> > To: sssd-devel@lists.fedorahosted.org > > On 08/09/2016 11:07 AM, Jakub Hrozek wrote: > > On Mon, Jul 25, 2016 at 06:18:28PM +0200, Petr Cech wrote: > > > > Hello, > > > > > > > > there is fi

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-12 Thread Jakub Hrozek
On Thu, Aug 11, 2016 at 02:23:39PM +0200, Petr Cech wrote: > On 08/09/2016 02:49 PM, Jakub Hrozek wrote: > > On Tue, Aug 09, 2016 at 12:57:58PM +0200, Petr Cech wrote: > > > On 08/09/2016 11:26 AM, Jakub Hrozek wrote: > > > > On Mon, Aug 08, 2016 at 09:

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-11 Thread Jakub Hrozek
On Thu, Aug 11, 2016 at 10:39:19AM +0200, Lukas Slebodnik wrote: > On (11/08/16 10:34), Jakub Hrozek wrote: > >On Thu, Aug 11, 2016 at 10:30:09AM +0200, Jakub Hrozek wrote: > >> ACK > >> > >> CI: http://sssd-ci.duckdns.org/logs/

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-11 Thread Jakub Hrozek
On Thu, Aug 11, 2016 at 10:30:09AM +0200, Jakub Hrozek wrote: > ACK > > CI: http://sssd-ci.duckdns.org/logs/job/51/34/summary.html master: b1a8b4a1291529367b46c79eb02448eced3bf8d2 I think this patch should be applied to the stable (sssd-1-13) branch as well. Anyon

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-11 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 11:53:43AM +0200, Michal Židek wrote: > On 08/10/2016 11:35 AM, Jakub Hrozek wrote: > > On Wed, Aug 10, 2016 at 12:02:18PM +0300, Alexander Bokovoy wrote: > > > On Tue, 09 Aug 2016, Michal Židek wrote: > > > > Summary for Alexander (in CC):

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-10 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 02:16:11PM +0200, Jakub Hrozek wrote: > On Fri, Aug 05, 2016 at 01:28:36PM +0200, Lukas Slebodnik wrote: > > and does not apply anymore on current master > > ACK (CI pending). > > I did some performance tests with systemtap and the performance hit

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 08:08:03AM +0200, Petr Cech wrote: > On 08/10/2016 07:30 AM, Petr Cech wrote: > > On 08/09/2016 07:10 PM, Lukas Slebodnik wrote: > > > On (09/08/16 10:21), Jakub Hrozek wrote: > > > > On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas S

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 12:02:18PM +0300, Alexander Bokovoy wrote: > On Tue, 09 Aug 2016, Michal Židek wrote: > > Summary for Alexander (in CC): > > - Regarding processing GPOs on the client. > > - If groupPolicyContainer in AD has attribute > > gPCMachineExtensionNames that contains only

[SSSD] Re: [PATCH] Handle unparseable names in the simple access list correctly

2016-08-10 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 03:08:52PM +0200, Jakub Hrozek wrote: > On Fri, Jul 29, 2016 at 02:59:46PM +0200, Lukas Slebodnik wrote: > > On (29/07/16 13:01), Jakub Hrozek wrote: > > >On Fri, Jul 29, 2016 at 11:44:53AM +0200, Lukas Slebodnik wrote: > > >> On (26/07

[SSSD] Re: [PATCH] config_schema: Add ldap_user_email to schema

2016-08-10 Thread Jakub Hrozek
On Wed, Aug 10, 2016 at 09:25:20AM +0200, Lukas Slebodnik wrote: > On (10/08/16 09:13), Fabiano Fidêncio wrote: > >On Wed, Aug 10, 2016 at 8:23 AM, Lukas Slebodnik wrote: > >> ehlo, > >> > >> yet another oneliner. > >> It reminds me that we should generate either schema or >

[SSSD] [PATCH] IPA: Parse qualified names when guessing AD user principal

2016-08-09 Thread Jakub Hrozek
ldap_user_principal = nosuchatt Please see the commit message for more details. >From 80dd688eaf7a20fbf6d71768c29fb7d73b315238 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Tue, 9 Aug 2016 22:08:27 +0200 Subject: [PATCH] IPA: Parse qualified names when guessin

[SSSD] Re: [PATCH] sssctl: use internal API to remove files

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 02:49:05PM +0200, Petr Cech wrote: > On 08/09/2016 02:10 PM, Pavel Březina wrote: > > On 08/09/2016 01:53 PM, Petr Cech wrote: > > > On 08/05/2016 01:48 PM, Petr Cech wrote: > > > > On 07/13/2016 01:47 PM, Pavel Březina wrote: > > > > > 0001-utils-add-remove_subtree.patch >

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 12:36:11PM +0200, Jakub Hrozek wrote: > On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > > On (13/07/16 17:48), Lukas Slebodnik wrote: > > >ehlo, > > > > > >attched patch is an integration test for regression #3093. >

[SSSD] Re: tasks for newcomers or non-developers

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 08:18:16AM -0400, Dan Lavu wrote: > I think it should be less formal than that, maybe on the wiki page, to have > a simple wishlist? So they'll ask to do it, grant access, write a draft in > the wiki, one reviewer, then publish? We can do that, but I would stil prefer (at

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 12:57:58PM +0200, Petr Cech wrote: > On 08/09/2016 11:26 AM, Jakub Hrozek wrote: > > On Mon, Aug 08, 2016 at 09:46:55AM +0200, Petr Cech wrote: > > > > On 08/04/2016 05:01 PM, Petr Cech wrote: > > > > > > On 08/04/2016 04:35 PM, P

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-09 Thread Jakub Hrozek
On Fri, Aug 05, 2016 at 01:28:36PM +0200, Lukas Slebodnik wrote: > and does not apply anymore on current master ACK (CI pending). I did some performance tests with systemtap and the performance hit was there, but very small (the user lookup went from 2-3ms to 4-6ms). nonetheless, Simo had a

[SSSD] Re: tasks for newcomers or non-developers

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 07:26:24AM -0400, Dan Lavu wrote: > I know it's not code related, but documentation and guides come to mind. > Maybe let people contribute more freely to the upstream wiki as they work > on tickets? Yes, how should we let potential contributors let about what's needed?

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 12:36:11PM +0200, Jakub Hrozek wrote: > On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > > On (13/07/16 17:48), Lukas Slebodnik wrote: > > >ehlo, > > > > > >attched patch is an integration test for regression #3093. >

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-09 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > On (13/07/16 17:48), Lukas Slebodnik wrote: > >ehlo, > > > >attched patch is an integration test for regression #3093. > >I prepared a test and I let someone else to fix it :-) > > > >I will try to find more bugs in downstream

[SSSD] Re: tasks for newcomers or non-developers

2016-08-09 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 10:20:37AM +0200, Jakub Hrozek wrote: > Hi, > > Over the last couple of weeks, I've talked to several people, mostly > engineers with not too much development experience, who said they would > like to start contributing little fixes to SSSD. I would li

[SSSD] which tickets do we need to close before releasing 1.14.1?

2016-08-09 Thread Jakub Hrozek
I would say we want to include: https://fedorahosted.org/sssd/ticket/3110 - Access denied after activating user in 389ds https://fedorahosted.org/sssd/ticket/3120 - SSSD fails to start when ldap_user_extra_attrs contains mail https://fedorahosted.org/sssd/ticket/3101 - sssd

[SSSD] Re: [PATCH] gpo: gPCMachineExtensionNames with just whitespaces

2016-08-09 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 05:40:44PM +0200, Michal Židek wrote: > Hi, > > the attached patch fixes: > https://fedorahosted.org/sssd/ticket/3114 > > We have a user that can not login with > enforced GPO because of this. I do not > think it is a common issue, I could not > create

[SSSD] Re: [PATCH] Warn if ad_server contains IP address

2016-08-09 Thread Jakub Hrozek
On Fri, Aug 05, 2016 at 12:09:27PM -0400, Justin Stephenson wrote: > Hi Lukas, > > I sent a response on July 6th but perhaps there was an issue with the > mailing list or some reason it did not go through. Yes, we had issues with the mailing list back then (it was a Fedora mailman bug that was

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 11:27:12AM +0200, Jakub Hrozek wrote: > On Fri, Aug 05, 2016 at 02:49:59PM +0200, Petr Cech wrote: > > On 08/04/2016 11:06 AM, Jakub Hrozek wrote: > > > On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: > > > > On Tue, Jul 26,

[SSSD] Re: [PATCH] NSS: Do not check local users with disabled local_negative_timeout

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 07:54:15AM +0200, Petr Cech wrote: > On 08/08/2016 04:20 PM, Petr Cech wrote: > > On 08/08/2016 04:09 PM, Lukas Slebodnik wrote: > > > On (08/08/16 15:36), Petr Cech wrote: > > > > On 08/08/2016 03:14 PM, Petr Cech wrote: > > > > > On 08/08/2016 02:40 PM, Lukas Slebodnik

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-09 Thread Jakub Hrozek
On Fri, Aug 05, 2016 at 02:49:59PM +0200, Petr Cech wrote: > On 08/04/2016 11:06 AM, Jakub Hrozek wrote: > > On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: > > > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pc...@redhat.com> wrote: > > > > H

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-09 Thread Jakub Hrozek
On Mon, Aug 08, 2016 at 09:46:55AM +0200, Petr Cech wrote: > On 08/04/2016 05:01 PM, Petr Cech wrote: > > On 08/04/2016 04:35 PM, Petr Cech wrote: > > > Hi list, > > > > > > there is the first version of patch for [1]. I need > > > to investigate if we have the same issue in other > > > *_childs.

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-08-09 Thread Jakub Hrozek
On Fri, Aug 05, 2016 at 12:02:19PM +0200, Pavel Březina wrote: > On 07/25/2016 12:55 PM, Pavel Březina wrote: > > On 07/20/2016 03:03 PM, Jakub Hrozek wrote: > > > On Wed, Jul 20, 2016 at 03:00:14PM +0200, Jakub Hrozek wrote: > > > > On Tue, Jul 19, 2016 at 12:20:1

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 11:15:29AM +0200, Pavel Březina wrote: > On 08/09/2016 11:08 AM, Jakub Hrozek wrote: > > On Tue, Aug 09, 2016 at 11:03:43AM +0200, Pavel Březina wrote: > > > On 08/09/2016 10:53 AM, Jakub Hrozek wrote: > > > > On Tue, Aug 09, 2016 at 10:39:

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 11:03:43AM +0200, Pavel Březina wrote: > On 08/09/2016 10:53 AM, Jakub Hrozek wrote: > > On Tue, Aug 09, 2016 at 10:39:25AM +0200, Jakub Hrozek wrote: > > > On Mon, Aug 08, 2016 at 10:28:41AM +0200, Petr Cech wrote: > > > > > > > &

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-09 Thread Jakub Hrozek
On Mon, Jul 25, 2016 at 06:18:28PM +0200, Petr Cech wrote: > Hello, > > there is fixed patch set attached. > > Segmentation fault was caused by wrong pointer :-(, sorry. > > This new patch set has new debug message. I am open to dissccus the > debug_level and content of message. Any improving

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 10:39:25AM +0200, Jakub Hrozek wrote: > On Mon, Aug 08, 2016 at 10:28:41AM +0200, Petr Cech wrote: > > > > > > On 08/08/2016 10:26 AM, Pavel Březina wrote: > > > On 08/05/2016 01:02 PM, Petr Cech wrote: > > > > On 08/05/2016 12:

[SSSD] Re: [PATCH] sssctl: Generic help for cache-upgrade and config-check

2016-08-09 Thread Jakub Hrozek
On Mon, Aug 08, 2016 at 10:45:32AM +0200, Pavel Březina wrote: > On 08/05/2016 12:47 PM, Michal Židek wrote: > > On 08/05/2016 12:01 PM, Pavel Březina wrote: > > > On 07/26/2016 04:43 PM, Michal Židek wrote: > > > > Hi! > > > > > > > > Attached is patch for ticket: > > > >

[SSSD] Re: [PATCH] DP: Initialize D-Bus as soon as possible

2016-08-09 Thread Jakub Hrozek
On Mon, Aug 08, 2016 at 10:28:41AM +0200, Petr Cech wrote: > > > On 08/08/2016 10:26 AM, Pavel Březina wrote: > > On 08/05/2016 01:02 PM, Petr Cech wrote: > > > On 08/05/2016 12:19 PM, Petr Cech wrote: > > > > On 08/05/2016 11:41 AM, Pavel Březina wrote: > > > > >

[SSSD] Re: [PATCH] NSS: Use correct name for invalidating memory cache

2016-08-09 Thread Jakub Hrozek
On Mon, Aug 08, 2016 at 06:37:10PM +0200, Lukas Slebodnik wrote: > ehlo, > > yet another patch which fixes issues caused by sysdb refactoring. > > reproducer: > a) add user with two groups > b) call id user > c) add another group to user > d) authenticate > e) check tha id -G return 3 groups. >

[SSSD] Re: [PATCH] Unit tests for pam_sss using pam_wrapper (need help with CI..)

2016-08-09 Thread Jakub Hrozek
On Tue, Aug 09, 2016 at 08:04:38AM +0200, Lukas Slebodnik wrote: > On (09/05/16 10:07), Jakub Hrozek wrote: > >On Wed, May 04, 2016 at 11:36:57PM +0200, Lukas Slebodnik wrote: > >> On (27/04/16 10:51), Jakub Hrozek wrote: > >> >Hi, > >> > >

[SSSD] [PATCH] Fix offline resolution of autofs maps and netgroups

2016-08-04 Thread Jakub Hrozek
:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Thu, 4 Aug 2016 17:58:32 +0200 Subject: [PATCH 1/2] AUTOFS: Fix offline resolution of autofs maps https://fedorahosted.org/sssd/ticket/3080 If talking to the Data Provider failed, we never re-tried looking into the cache. We should consult

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 12:55:02PM +0200, Lukas Slebodnik wrote: > On (04/08/16 12:16), Jakub Hrozek wrote: > >On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > >> On (13/07/16 17:48), Lukas Slebodnik wrote: > >> >ehlo, > >> >

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:12:53AM +0200, Jakub Hrozek wrote: > ACK > > Just waiting for CI to finish before pushing.. CI: http://sssd-ci.duckdns.org/logs/job/50/80/summary.html * master: * ba3c902014ac0b04ec761296fdb1c3ede747a5f2 * 4b9ee02b1f5252b2a116adf0c0c6c7a

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > On (13/07/16 17:48), Lukas Slebodnik wrote: > >ehlo, > > > >attched patch is an integration test for regression #3093. > >I prepared a test and I let someone else to fix it :-) > > > >I will try to find more bugs in downstream

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:35:30AM +0200, Michal Židek wrote: > On 07/12/2016 06:38 PM, Lukas Slebodnik wrote: > > On (12/07/16 15:59), Michal Židek wrote: > > > On 07/12/2016 03:36 PM, Lukas Slebodnik wrote: > > > > On (12/07/16 15:16), Michal Židek wrote: > > > > > +# secrets responder > > > > >

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:26:41AM +0200, Jakub Hrozek wrote: > On Thu, Aug 04, 2016 at 11:19:36AM +0200, Lukas Slebodnik wrote: > > On (04/08/16 11:15), Jakub Hrozek wrote: > > >On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: > > >> On (03/08/16

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:19:36AM +0200, Lukas Slebodnik wrote: > On (04/08/16 11:15), Jakub Hrozek wrote: > >On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: > >> On (03/08/16 18:56), Lukas Slebodnik wrote: > >> >On (29/07/16 16:41), Jakub Hroze

[SSSD] Re: [PATCH] Fixed some typos in man pages

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 09:46:46AM +0200, Fabiano Fidêncio wrote: > On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf wrote: > > > > > > ___ > > sssd-devel mailing list > > sssd-devel@lists.fedorahosted.org > >

[SSSD] Re: [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 08:08:35PM +0200, Lukas Slebodnik wrote: > >So ACK to oneliner :-) > > > http://sssd-ci.duckdns.org/logs/job/50/79/summary.html > > LS * master: 6a89b38c032593ed705e679c23e6a4efce9f3def ___ sssd-devel mailing list

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: > On (03/08/16 18:56), Lukas Slebodnik wrote: > >On (29/07/16 16:41), Jakub Hrozek wrote: > >>On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: > >>> On Thu, Jul 28, 2016 at 01:33:32P

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 05:21:53PM +0200, Fabiano Fidêncio wrote: > On Wed, Aug 3, 2016 at 5:10 PM, Jakub Hrozek <jhro...@redhat.com> wrote: > > On Tue, Aug 02, 2016 at 04:08:03PM +0200, Fabiano Fidêncio wrote: > >> So, sorry for the very long title and please,

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech wrote: > > Hello list, > > > > attached patch fixes duplication of pid file declaration. I hope that the > > util/util.h is the right place for it. Another opinion are

[SSSD] Re: [PATCH] Two code-hardening patches

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 06:08:44PM +0200, Lukas Slebodnik wrote: > On (03/08/16 18:05), Jakub Hrozek wrote: > >Hi, > > > >these two patches add error handling to the code. The first prevents > >operating on ldb_message if retrieving the message fails. I only tested

[SSSD] tasks for newcomers or non-developers

2016-08-04 Thread Jakub Hrozek
Hi, Over the last couple of weeks, I've talked to several people, mostly engineers with not too much development experience, who said they would like to start contributing little fixes to SSSD. I would like to find some tasks that they can easily handle without making their had spin from looking

[SSSD] [PATCH] Two code-hardening patches

2016-08-03 Thread Jakub Hrozek
the code better. The second just checks a return value. >From 1e67ab6596ac73d12c97abc5feebe2ee1fca6a3f Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Wed, 3 Aug 2016 17:43:14 +0200 Subject: [PATCH 1/2] PAM: Do not act on ldb_message in case of a failure --- src/resp

[SSSD] [PATCH] SYSDB: Fix setting dataExpireTimestamp if sysdb is supposed to set the current time

2016-08-03 Thread Jakub Hrozek
Hi, please see the attached patch and the test. They should fix https://fedorahosted.org/sssd/ticket/3064. I don't think more explanation than what is in the ticket and in the commit message is needed :) >From 1507a9c0c461b2fa3bf4fe59358a5150cb57c5a4 Mon Sep 17 00:00:00 2001 From: Jakub Hro

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-03 Thread Jakub Hrozek
On Tue, Aug 02, 2016 at 04:08:03PM +0200, Fabiano Fidêncio wrote: > So, sorry for the very long title and please, see the proposed patches > for solving https://fedorahosted.org/sssd/ticket/3094 > > > Best Regards, > -- > Fabiano Fidêncio > From 7b04832fce0bdf7f8e86c30f60811f7d219e62fc Mon Sep

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-08-03 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 02:28:40PM +0200, Lukas Slebodnik wrote: > On (28/07/16 09:22), Jakub Hrozek wrote: > >On Wed, Jul 27, 2016 at 05:56:48PM +0200, Lukas Slebodnik wrote: > >> On (27/07/16 15:57), Jakub Hrozek wrote: > >> >On Mon, Jul 25, 2016 at 04:11:16P

[SSSD] [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-03 Thread Jakub Hrozek
Hi, see the attached patch. You can use Lukas' integration tests to help with review. >From 46a705afa5c04399e8ae41bfa98836cf40803f0f Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Wed, 3 Aug 2016 13:18:51 +0200 Subject: [PATCH] LDAP: Use FQDN when linking pa

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 12:52:31PM +0200, Petr Cech wrote: > On 08/03/2016 12:46 PM, Lukas Slebodnik wrote: > > On (03/08/16 12:34), Michal Židek wrote: > > > Two nitpicks, see inline. > > > > > > On 07/22/2016 02:34 PM, Petr Cech wrote: > > > > > > > > +static errno_t add_to_missing_attrs

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-29 Thread Jakub Hrozek
On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: > On Thu, Jul 28, 2016 at 01:33:32PM +0200, Lukas Slebodnik wrote: > > On (28/07/16 12:06), thierry bordaz wrote: > > >On 07/28/2016 09:39 AM, Jakub Hrozek wrote: > > >> On Wed, Jul 27, 2016 at 04:09:07

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 03:06:47PM +0200, Lukas Slebodnik wrote: > On (29/07/16 14:27), Jakub Hrozek wrote: > >On Fri, Jul 29, 2016 at 02:09:02PM +0200, Lukas Slebodnik wrote: > >> On (29/07/16 13:59), Jakub Hrozek wrote: > >> >On Fri, Jul 29, 2016 at 01:49:41P

<    1   2   3   4   5   6   7   8   9   10   >