[SSSD] [sssd PR#1006][-Changes requested] LDAP: Netgroups refresh in background task

2020-03-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/1006 Title: #1006: LDAP: Netgroups refresh in background task Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#1006][+Accepted] LDAP: Netgroups refresh in background task

2020-03-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/1006 Title: #1006: LDAP: Netgroups refresh in background task Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] [sssd PR#1007][comment] LDAP: Remove unused sdap_refresh code

2020-03-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/1007 Title: #1007: LDAP: Remove unused sdap_refresh code jhrozek commented: """ On Thu, Mar 19, 2020 at 06:17:27AM -0700, Paweł Poławski wrote: > I just need to check one thing - if similar functions for AD and IPA are > unused too

[SSSD]WARNING: MERGED [sssd PR#962][closed] nss: use real primary gid if the value is overriden (sssd-1-16)

2019-12-13 Thread jhrozek
*WARNING: this pull request has been merged!* This is only mirrored repo thus any changes will be erased. Please push commit(s) to authoritative repository. URL: https://github.com/SSSD/sssd/pull/962 Author: mzidek-rh Title: #962: nss: use real primary gid if the value is overriden (sssd-1-16

[SSSD] [sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

2019-11-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/558 Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache jhrozek commented: """ Maybe? I don't plan on working on this, so do whatever you like.. """ See the full comme

[SSSD] [sssd PR#921][comment] util/server.c: fix handling when error occurs in waitpid()

2019-10-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/921 Title: #921: util/server.c: fix handling when error occurs in waitpid() jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/921#issuecomment-547995771 __

[SSSD] [sssd PR#920][comment] Add comment to workaround for libsemanage issue

2019-10-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/920 Title: #920: Add comment to workaround for libsemanage issue jhrozek commented: """ add to whitelist """ See the full comment at https://github.com/SSSD/sssd/pull/920#issuecomment-547849552

[SSSD] [sssd PR#904][comment] KCM: Set kdc_offset to zero initially

2019-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/904 Title: #904: KCM: Set kdc_offset to zero initially jhrozek commented: """ @frozencemetery Do you have an opinion about this one way or the other? This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1757224 ""&

[SSSD] [sssd PR#904][opened] KCM: Set kdc_offset to zero initially

2019-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/904 Author: jhrozek Title: #904: KCM: Set kdc_offset to zero initially Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/4100 KCM assumed that the client library would always set the KDC offset, but that's

[SSSD] [sssd PR#896][opened] KCM: Fix typo in allocation check

2019-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/896 Author: jhrozek Title: #896: KCM: Fix typo in allocation check Action: opened PR body: """ Spotted by adelton """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pu

[SSSD] [sssd PR#546][comment] TESTS: Re-add tests for `kdestroy -A`

2019-09-18 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/546 Title: #546: TESTS: Re-add tests for `kdestroy -A` jhrozek commented: """ Alexey, I don't know if Debian already picked up the fixed libkrb5. If not, I think it would be nice to add this as a separate test and mark it as xfail or

[SSSD] [sssd PR#885][comment] Fix option type for ldap_group_type

2019-09-18 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/885 Title: #885: Fix option type for ldap_group_type jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/885#issuecomment-532818264 _

[SSSD] [sssd PR#878][comment] backport the background refresh patches to sssd-1-16

2019-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/878 Title: #878: backport the background refresh patches to sssd-1-16 jhrozek commented: """ Yes? But I only tried on my local F-30 system """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#558][synchronized] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

2019-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/558 Author: jhrozek Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/558

[SSSD] [sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

2019-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/558 Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache jhrozek commented: """ Rebased per @pbrezina 's request """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#693][comment] SYSDB: Fall back to the MPG result of getgrgid search if the non-MPG search for override doesn't match anything

2019-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/693 Title: #693: SYSDB: Fall back to the MPG result of getgrgid search if the non-MPG search for override doesn't match anything jhrozek commented: """ Rebased per @pbrezina 's request """ See the full comment a

[SSSD] [sssd PR#693][synchronized] SYSDB: Fall back to the MPG result of getgrgid search if the non-MPG search for override doesn't match anything

2019-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/693 Author: jhrozek Title: #693: SYSDB: Fall back to the MPG result of getgrgid search if the non-MPG search for override doesn't match anything Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sss

[SSSD] [sssd PR#876][synchronized] KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize

2019-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/876 Author: jhrozek Title: #876: KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/876/head:pr876

[SSSD] [sssd PR#876][comment] KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize

2019-08-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/876 Title: #876: KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize jhrozek commented: """ So, the initialize() command receives the principal. We could iterate over the ccaches for this client and check if t

[SSSD] [sssd PR#876][comment] KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize

2019-08-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/876 Title: #876: KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize jhrozek commented: """ btw this PR fixes the most glaring issue but maybe the whole problem needs more work. What this doesn't take int

[SSSD] [sssd PR#876][opened] KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize

2019-08-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/876 Author: jhrozek Title: #876: KCM: Fill in pre-created ccache instead of creating a new one in kcm_initialize Action: opened PR body: """ This is a continuation of https://pagure.io/SSSD/sssd/issue/3873 Some programs like openssh us

[SSSD] [sssd PR#866][comment] autofs: do not enumerate when only single entry is requested

2019-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/866 Title: #866: autofs: do not enumerate when only single entry is requested jhrozek commented: """ @pbrezina do you think this patchset is backportable to sssd-1-16 at all? """ See the full comment at https://github.com/S

[SSSD] [sssd PR#845][+Pushed] MAN: Document that PAM stack contains the systemd-user service in the account phase in RHEL-8

2019-08-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/845 Title: #845: MAN: Document that PAM stack contains the systemd-user service in the account phase in RHEL-8 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send a

[SSSD] [sssd PR#865][opened] KCM: Use int32_t type conversion in DEBUG message for int32_t variable

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/865 Author: jhrozek Title: #865: KCM: Use int32_t type conversion in DEBUG message for int32_t variable Action: opened PR body: """ The KDC offset is stored as int32_t, but a DEBUG message in KCM was using an uint32_t. This lead to

[SSSD] [sssd PR#857][comment] Don't qualify users from files domain when default_domain_suffix is set

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/857 Title: #857: Don't qualify users from files domain when default_domain_suffix is set jhrozek commented: """ * master: 41da9ddfd084024ba9ca20b6d3c0b531c0473231 """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#857][closed] Don't qualify users from files domain when default_domain_suffix is set

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/857 Author: jhrozek Title: #857: Don't qualify users from files domain when default_domain_suffix is set Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/857/head:pr857 git che

[SSSD] [sssd PR#862][+Pushed] pam: fix loop in Smartcard authentication

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/862 Title: #862: pam: fix loop in Smartcard authentication Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fe

[SSSD] [sssd PR#862][closed] pam: fix loop in Smartcard authentication

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/862 Author: sumit-bose Title: #862: pam: fix loop in Smartcard authentication Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/862/head:pr862 git checkout pr862 _

[SSSD] [sssd PR#862][comment] pam: fix loop in Smartcard authentication

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/862 Title: #862: pam: fix loop in Smartcard authentication jhrozek commented: """ * master: 5574de0f87e72d85547add9a48f9ac0def27f47d """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#862][+Accepted] pam: fix loop in Smartcard authentication

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/862 Title: #862: pam: fix loop in Smartcard authentication Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#862][comment] pam: fix loop in Smartcard authentication

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/862 Title: #862: pam: fix loop in Smartcard authentication jhrozek commented: """ ACK, thank you """ See the full comment at https://github.com/SSSD/sssd/pull/862#issuecomment-521219414

[SSSD] [sssd PR#824][comment] CONFDB: Files domain if activated without .conf

2019-08-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/824 Title: #824: CONFDB: Files domain if activated without .conf jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-521162256

[SSSD] [sssd PR#863][comment] ci: add Debian 10

2019-08-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/863 Title: #863: ci: add Debian 10 jhrozek commented: """ Hi @pbrezina I would prefer if @alexey-tikhonov could check the valgrind errors, because he was already looking into them. Honestly they seem a bit too much like a black check :

[SSSD] [sssd PR#857][comment] Don't qualify users from files domain when default_domain_suffix is set

2019-08-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/857 Title: #857: Don't qualify users from files domain when default_domain_suffix is set jhrozek commented: """ Thanks @mzidek-rh for the review. How about now? """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#857][-Changes requested] Don't qualify users from files domain when default_domain_suffix is set

2019-08-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/857 Title: #857: Don't qualify users from files domain when default_domain_suffix is set Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#857][synchronized] Don't qualify users from files domain when default_domain_suffix is set

2019-08-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/857 Author: jhrozek Title: #857: Don't qualify users from files domain when default_domain_suffix is set Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/857/head:pr85

[SSSD] [sssd PR#861][opened] IPA: Allow paging when fetching external groups

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/861 Author: jhrozek Title: #861: IPA: Allow paging when fetching external groups Action: opened PR body: """ For some reason (I guess a mistake during refactoring..) the LDAP search request that fetches the external groups does not en

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable jhrozek commented: """ * master: * ad9dd137e2f8ad46cfb921fb7bf137fb3442692e * a97ec73e04b6347bb6aa9794f5ea9f4ca3424801 * ba01db0dcd43ef1b2079d9cc209534d45a3e938d ""&

[SSSD] [sssd PR#837][+Pushed] p11_child: make OCSP digest configurable

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fed

[SSSD] [sssd PR#837][closed] p11_child: make OCSP digest configurable

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/837 Author: sumit-bose Title: #837: p11_child: make OCSP digest configurable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/837/head:pr837 git checkout pr837 __

[SSSD] [sssd PR#705][closed] KCM: Add configurable quotas

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Author: jhrozek Title: #705: KCM: Add configurable quotas Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/705/head:pr705 git checkout pr705

[SSSD] [sssd PR#705][+Pushed] KCM: Add configurable quotas

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#705][comment] KCM: Add configurable quotas

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas jhrozek commented: """ * master: * 247aa48004ceb2efba42e917cebecc0ab74dc207 * f024b5e46b62ad49f0099ed8db8155e7ea475639 * f00db73d7bbf312e3e2a772b8b10895d5460b989 * 940002ca21abde53ad81df622

[SSSD] [sssd PR#824][comment] CONFDB: Files domain if activated without .conf

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/824 Title: #824: CONFDB: Files domain if activated without .conf jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-519099537

[SSSD] [sssd PR#859][+Accepted] Make sure child log files have the right permissions

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/859 Title: #859: Make sure child log files have the right permissions Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#837][+Accepted] p11_child: make OCSP digest configurable

2019-08-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#857][opened] Don't qualify users from files domain when default_domain_suffix is set

2019-08-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/857 Author: jhrozek Title: #857: Don't qualify users from files domain when default_domain_suffix is set Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/4052 The files domain should always be non-qualified.

[SSSD] [sssd PR#636][+Pushed] failover: tune up default timeouts

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Title: #636: failover: tune up default timeouts Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Co

[SSSD] [sssd PR#636][closed] failover: tune up default timeouts

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Author: pbrezina Title: #636: failover: tune up default timeouts Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/636/head:pr636 git checkout pr636 __

[SSSD] [sssd PR#636][comment] failover: tune up default timeouts

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Title: #636: failover: tune up default timeouts jhrozek commented: """ * master: * 049f3906b9ef2041b5e1df666bd570379ae60718 * e97ff0adb62c89cfc7e75858b7e592e0303720b0 * 99e2a107f01c625cb59cb8858

[SSSD] [sssd PR#847][comment] systemd: add Restart=on-failure to sssd.service

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/847 Title: #847: systemd: add Restart=on-failure to sssd.service jhrozek commented: """ * master: b1ea33eca64a0429513fcfe2ba7402ff56889b46 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#847][closed] systemd: add Restart=on-failure to sssd.service

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/847 Author: pbrezina Title: #847: systemd: add Restart=on-failure to sssd.service Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/847/head:pr847 git checkout pr847 _

[SSSD] [sssd PR#847][+Pushed] systemd: add Restart=on-failure to sssd.service

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/847 Title: #847: systemd: add Restart=on-failure to sssd.service Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#853][+Pushed] DYNDNS: dyndns_update is not enough

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/853 Title: #853: DYNDNS: dyndns_update is not enough Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#853][comment] DYNDNS: dyndns_update is not enough

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/853 Title: #853: DYNDNS: dyndns_update is not enough jhrozek commented: """ * master: * f2c69a67ad0cd9d4db94aa66e46ede0cb0790480 * 1c7521898f1cb13607c536977029561f89573c7c * 5b235bbdbea355923e4f2aeb745c8e514b423984 """

[SSSD] [sssd PR#853][closed] DYNDNS: dyndns_update is not enough

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/853 Author: thalman Title: #853: DYNDNS: dyndns_update is not enough Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/853/head:pr853 git checkout pr853

[SSSD] [sssd PR#855][+Pushed] nss: Fix command 'endservent' resetting wrong struct member

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/855 Title: #855: nss: Fix command 'endservent' resetting wrong struct member Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#855][comment] nss: Fix command 'endservent' resetting wrong struct member

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/855 Title: #855: nss: Fix command 'endservent' resetting wrong struct member jhrozek commented: """ * sssd-1-16: 9673ca8 * master: 06479a1 """ See the full comment at https://github.com/S

[SSSD] [sssd PR#855][closed] nss: Fix command 'endservent' resetting wrong struct member

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/855 Author: scabrero Title: #855: nss: Fix command 'endservent' resetting wrong struct member Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/855/head:pr855 git checkout pr855 _

[SSSD] [sssd PR#636][+Accepted] failover: tune up default timeouts

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Title: #636: failover: tune up default timeouts Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#636][comment] failover: tune up default timeouts

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Title: #636: failover: tune up default timeouts jhrozek commented: """ F-30 failed CI and there are no logs. But I don't see anything OS-specific in the patches and at the same time all my concerns were addressed. Thank you. AC

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable jhrozek commented: """ OK, I tried also different values of the `ocsp_dgst` option and at least I see that the revoked cert is still revoked..and invalid value seems to fall back

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable jhrozek commented: """ Sorry it took me almost four weeks to test the PR. I think OSCP in general works fine. With a valid certificate I was getting: ``` (Wed Jul 31 15:34:

[SSSD] [sssd PR#851][comment] Update __init__.py.in

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/851 Title: #851: Update __init__.py.in jhrozek commented: """ I don't know if it's easy or possible but wouldn't it be better to amend the config API to internally synthetize the provider values, but does not write them to

[SSSD] [sssd PR#841][+Changes requested] DEBUG: Add debug to display ldapsearch requests

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fe

[SSSD] [sssd PR#841][comment] DEBUG: Add debug to display ldapsearch requests

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests jhrozek commented: """ The code looks OK. I haven't tried it, but looks simple enough. But most importantly, it is not enough to resolve the issue, I think. What the ori

[SSSD] [sssd PR#847][comment] systemd: add Restart=on-failure to sssd.service

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/847 Title: #847: systemd: add Restart=on-failure to sssd.service jhrozek commented: """ ACK, tested by sending SIGV to the main sssd process, systemd spawned another one. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#847][+Accepted] systemd: add Restart=on-failure to sssd.service

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/847 Title: #847: systemd: add Restart=on-failure to sssd.service Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#705][comment] KCM: Add configurable quotas

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas jhrozek commented: """ Now some pep8 errors found by CI were fixed. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#705][synchronized] KCM: Add configurable quotas

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Author: jhrozek Title: #705: KCM: Add configurable quotas Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/705/head:pr705 git checkout pr705 From

[SSSD] [sssd PR#855][+Accepted] nss: Fix command 'endservent' resetting wrong struct member

2019-07-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/855 Title: #855: nss: Fix command 'endservent' resetting wrong struct member Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists

[SSSD] [sssd PR#853][comment] DYNDNS: dyndns_update is not enough

2019-07-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/853 Title: #853: DYNDNS: dyndns_update is not enough jhrozek commented: """ @pbrezina this seems like code you would like to review? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#705][-Changes requested] KCM: Add configurable quotas

2019-07-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedo

[SSSD] [sssd PR#851][comment] Update __init__.py.in

2019-07-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/851 Title: #851: Update __init__.py.in jhrozek commented: """ I thought @pbrezina might? """ See the full comment at https://github.com/SSSD/sssd/pull/851#issuecomment-516357806 _

[SSSD] [sssd PR#636][comment] failover: tune up default timeouts

2019-07-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Title: #636: failover: tune up default timeouts jhrozek commented: """ I'm sorry, but now the tests don't work: ``` In file included from /var/lib/jenkins/workspace/ci/label/rhel7/src/providers/fail_over_srv.h:27:0,

[SSSD] [sssd PR#705][comment] KCM: Add configurable quotas

2019-07-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas jhrozek commented: """ @mzidek-rh please try now, there was some conflict between the tests, so I just removed the secrets db with the quota tests. (Only the patch with the tests was modifie

[SSSD] [sssd PR#705][synchronized] KCM: Add configurable quotas

2019-07-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Author: jhrozek Title: #705: KCM: Add configurable quotas Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/705/head:pr705 git checkout pr705 From

[SSSD] [sssd PR#705][+Changes requested] KCM: Add configurable quotas

2019-07-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedo

[SSSD] [sssd PR#705][comment] KCM: Add configurable quotas

2019-07-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas jhrozek commented: """ I can see the tests failing now, too.. Setting Changes requested so I can take a look.. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#855][comment] nss: Fix command 'endservent' resetting wrong struct member

2019-07-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/855 Title: #855: nss: Fix command 'endservent' resetting wrong struct member jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/855#issuecomment-515186167

[SSSD] [sssd PR#854][comment] LDAP: Do not require START_TLS for loopback connections

2019-07-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/854 Title: #854: LDAP: Do not require START_TLS for loopback connections jhrozek commented: """ @simo5 this is one of the things I don't dare to include in the project without your blessing :-) So me and @scabrero talked about this o

[SSSD] [sssd PR#854][comment] LDAP: Do not require START_TLS for loopback connections

2019-07-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/854 Title: #854: LDAP: Do not require START_TLS for loopback connections jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/854#issuecomment-514748771

[SSSD] [sssd PR#851][comment] Update __init__.py.in

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/851 Title: #851: Update __init__.py.in jhrozek commented: """ Oh and about the centos CI triggers. I added both Alexey and Tomas to the centos CI whitelist so that the "OK to test" magic phrase would work for them. Honestly I t

[SSSD] [sssd PR#851][comment] Update __init__.py.in

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/851 Title: #851: Update __init__.py.in jhrozek commented: """ @alexey-tikhonov all the CI engines are green now. Unless you have more comments, would you mind adding the Accepted label so that we can push the PR? """

[SSSD] [sssd PR#824][comment] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/824 Title: #824: CONFDB: Files domain if activated without .conf jhrozek commented: """ @thalman can you re-push the PR so that the internal CI also gets triggered? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#824][comment] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/824 Title: #824: CONFDB: Files domain if activated without .conf jhrozek commented: """ @alexey-tikhonov do you also plan on reviewing this PR? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#825][+Pushed] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/825 Title: #825: CONFDB: Files domain if activated without .conf Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#825][closed] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/825 Author: thalman Title: #825: CONFDB: Files domain if activated without .conf Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/825/head:pr825 git checkout pr825 __

[SSSD] [sssd PR#825][comment] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/825 Title: #825: CONFDB: Files domain if activated without .conf jhrozek commented: """ Ah, sorry, there is already PR#824. So I can close this one. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#843][closed] p11_child: prefer better digest function if card supports it

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/843 Author: sumit-bose Title: #843: p11_child: prefer better digest function if card supports it Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/843/head:pr843 git checkout pr843 __

[SSSD] [sssd PR#843][comment] p11_child: prefer better digest function if card supports it

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/843 Title: #843: p11_child: prefer better digest function if card supports it jhrozek commented: """ * master: * 60748f69d9e21cf4cfd0655a0d7b81a715e9ae04 * 7f0a8f5060b28dc35e152d7290b583de99361d80 """ See the full comme

[SSSD] [sssd PR#825][comment] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/825 Title: #825: CONFDB: Files domain if activated without .conf jhrozek commented: """ * master: * 31e08f300ff9c19e87ee9b230d8d9a5970c7dcdb * 15cc1e404f1725d05cb6a285abba70853ae89ad1 """ See the full comment at https:/

[SSSD] [sssd PR#825][comment] CONFDB: Files domain if activated without .conf

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/825 Title: #825: CONFDB: Files domain if activated without .conf jhrozek commented: """ Looks like the patches don't apply cleanly atop sssd-1-16. @thalman would you like to open a separate backport PR? """ See the

[SSSD] [sssd PR#852][+Pushed] tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait()

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/852 Title: #852: tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait() Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#852][closed] tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait()

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/852 Author: alexal Title: #852: tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait() Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/852/head:pr852 git checkout pr852 ___

[SSSD] [sssd PR#852][comment] tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait()

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/852 Title: #852: tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait() jhrozek commented: """ * master: ff8284e222f2c03e6ff72d6b03390db79e0511cd Thank you very much for the contribution """ See the full comment at htt

[SSSD] [sssd PR#852][comment] tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait()

2019-07-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/852 Title: #852: tests/cmocka/test_dyndns.c: Switching to tevent_loop_wait() jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/852#issuecomment-513710114 __

[SSSD] [sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

2019-07-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/796 Title: #796: ci: enable sssd-ci for 1-16 branch jhrozek commented: """ * sssd-1-16: * 85dab318ce0ea745722a89a761d60bb33b102f6f * 8003e324912741c3083147180d7ee5fb0827eb0a * f988c870b2a8daa049896da1c

[SSSD] [sssd PR#796][closed] ci: enable sssd-ci for 1-16 branch

2019-07-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/796 Author: pbrezina Title: #796: ci: enable sssd-ci for 1-16 branch Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/796/head:pr796 git checkout pr796 __

[SSSD] [sssd PR#796][+Pushed] ci: enable sssd-ci for 1-16 branch

2019-07-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/796 Title: #796: ci: enable sssd-ci for 1-16 branch Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Co

  1   2   3   4   5   6   7   8   9   10   >