[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

2017-12-14 Thread tiran
URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check tiran commented: """ As a software developer with over 20 years of coding experience and involved in lots of Open Source projects written in C, Go and Python, I have to disagree with you. A consis

[SSSD] [sssd PR#58][comment] Fix bug in libcrypto version of sss_decrypt

2016-10-21 Thread tiran
URL: https://github.com/SSSD/sssd/pull/58 Title: #58: Fix bug in libcrypto version of sss_decrypt tiran commented: """ ACK Let's investigate the LTO/PGO issue in a different ticket. I'm not even sure that the problem actually exists. """ See the full comment at

[SSSD] [sssd PR#58][comment] Fix bug in libcrypto version of sss_decrypt

2016-10-21 Thread tiran
URL: https://github.com/SSSD/sssd/pull/58 Title: #58: Fix bug in libcrypto version of sss_decrypt tiran commented: """ I cannot recall that I reviewed the code. In fact I didn't even know that OpenSSL had a constant timing comparison operator called ```CRYPTO_memcmp```. @lsl

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-16 Thread tiran
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder tiran commented: """ * Can SSSD's secret responder contact Custodia over Unix socket? I'd rather have UDS as the default example configuration than TCP/IP. * We are consi