Re: [SSSD] [PATCH] Add better checks on PAM socket

2010-03-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/11/2010 09:06 AM, Stephen Gallagher wrote: > On 03/10/2010 09:55 AM, Stephen Gallagher wrote: >> On 03/08/2010 08:55 AM, Sumit Bose wrote: >>> Hi, > >>> this patch adds a check the public PAM socket it a socket that belongs >>> to root for all p

Re: [SSSD] [PATCH] Add better checks on PAM socket

2010-03-15 Thread Sumit Bose
On Fri, Mar 12, 2010 at 04:50:19PM -0600, George McCollister wrote: > I think char buf[CMSG_SPACE(sizeof(struct ucred))]; on > src/sss_client/common.c:66 needs to be aligned. I'll look at it more on > Monday. > While trying to find out where the alignment might go wrong I realized that there migh

Re: [SSSD] [PATCH] Add better checks on PAM socket

2010-03-12 Thread George McCollister
I think char buf[CMSG_SPACE(sizeof(struct ucred))]; on src/sss_client/common.c:66 needs to be aligned. I'll look at it more on Monday. George McCollister On 03/08/2010 07:55 AM, Sumit Bose wrote: > Hi, > > this patch adds a check the public PAM socket it a socket that belongs > to root for all pl

Re: [SSSD] [PATCH] Add better checks on PAM socket

2010-03-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/10/2010 09:55 AM, Stephen Gallagher wrote: > On 03/08/2010 08:55 AM, Sumit Bose wrote: >> Hi, > >> this patch adds a check the public PAM socket it a socket that belongs >> to root for all plattforms and uses a SCM_CREDENTIALS ancillary >> messa

Re: [SSSD] [PATCH] Add better checks on PAM socket

2010-03-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/2010 08:55 AM, Sumit Bose wrote: > Hi, > > this patch adds a check the public PAM socket it a socket that belongs > to root for all plattforms and uses a SCM_CREDENTIALS ancillary > message to identify the uid/gid/pid of the peer if these mes

[SSSD] [PATCH] Add better checks on PAM socket

2010-03-08 Thread Sumit Bose
Hi, this patch adds a check the public PAM socket it a socket that belongs to root for all plattforms and uses a SCM_CREDENTIALS ancillary message to identify the uid/gid/pid of the peer if these messages are available. bye, Sumit From b148d1e7276a8e83079ebf735d3bd34f7b690660 Mon Sep 17 00:00:00