Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 10:44 AM, Simo Sorce wrote: > On Wed, 2009-11-04 at 16:11 +0100, Sumit Bose wrote: >> On Wed, Nov 04, 2009 at 09:25:29AM -0500, Simo Sorce wrote: >>> On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: +if (e != NULL) { +

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Simo Sorce
On Wed, 2009-11-04 at 16:11 +0100, Sumit Bose wrote: > On Wed, Nov 04, 2009 at 09:25:29AM -0500, Simo Sorce wrote: > > On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: > > > +if (e != NULL) { > > > +dummy = talloc_strdup(talloc_parent(e->name), newname); > > > > The parent should b

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Sumit Bose
On Wed, Nov 04, 2009 at 09:25:29AM -0500, Simo Sorce wrote: > On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: > > +if (e != NULL) { > > +dummy = talloc_strdup(talloc_parent(e->name), newname); > > The parent should be "attrs", I would use that and not talloc_parent(), > so even if

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Simo Sorce
On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: > +if (e != NULL) { > +dummy = talloc_strdup(talloc_parent(e->name), newname); The parent should be "attrs", I would use that and not talloc_parent(), so even if the parent is something "else", we get the new parent right. Simo. --

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Sumit Bose
On Wed, Nov 04, 2009 at 12:53:22PM +0100, Sumit Bose wrote: > Hi, > > this patch adds the sysdb_attrs_replace_name() call to replace the name > of an attribute with a new one. This is useful if you want to store the > results of an LDAP query in sysdb, but need to replace certain attribute > names

[SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Sumit Bose
Hi, this patch adds the sysdb_attrs_replace_name() call to replace the name of an attribute with a new one. This is useful if you want to store the results of an LDAP query in sysdb, but need to replace certain attribute names, e.g. member or memberOf. bye, Sumit >From 68d17d27f4f876e2060b93bbeb9