Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-09 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2009 09:25 AM, Dmitri Pal wrote: I am unclear about couple things here: a) Is my solution acceptable for the given situation? b) If not what is the preferred solution? c) What is different about the given typecast and why this typecast

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/07/2009 10:05 AM, Jakub Hrozek wrote: On 09/05/2009 02:32 AM, Dmitri Pal wrote: See patch comment. This patch most likely will not apply cleanly without my previous ELAPI patches. So far it is 4 th pending patch. More to come. In

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2009 08:41 AM, Dmitri Pal wrote: Thank you for review, comments inline. Stephen Gallagher wrote: On 09/07/2009 10:05 AM, Jakub Hrozek wrote: On 09/05/2009 02:32 AM, Dmitri Pal wrote: See patch comment. This patch most likely will not

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-08 Thread Dmitri Pal
I am unclear about couple things here: a) Is my solution acceptable for the given situation? b) If not what is the preferred solution? c) What is different about the given typecast and why this typecast suppresses warning (if it does) while others do not? Please advise. I think

Re: [SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

2009-09-07 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/05/2009 02:32 AM, Dmitri Pal wrote: See patch comment. This patch most likely will not apply cleanly without my previous ELAPI patches. So far it is 4 th pending patch. More to come. In general, I think the patch is OK. Some comments,