Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 01:30 PM, Stephen Gallagher wrote: > > You're welcome. That's why the tests are there. > > Ack. > Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among softw

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 12:49 PM, Simo Sorce wrote: > > Thanks for catching this, it unveiled a serious error. > > Attached patch that correctly passes all tests. > > Simo. > You're welcome. That's why the tests are there. Ack. - -- Stephen Gallagher RHC

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 11:16 -0500, Stephen Gallagher wrote: > Nack > You broke the sysdb tests > > ../../server/tests/sysdb-tests.c:1758:F:SYSDB > Tests:test_sysdb_get_user_attr:27010: [5]: Could not get attributes > for > user testuser27010 [..] Thanks for catching this, it unveiled a serious er

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2009 05:16 AM, Sumit Bose wrote: > On Tue, Nov 17, 2009 at 08:38:00PM -0500, Simo Sorce wrote: >> I've been thinking about optimizing group enumerations for a while as >> they were way too slow for my taste. >> >> I did that by relying on the

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Sumit Bose
On Tue, Nov 17, 2009 at 08:38:00PM -0500, Simo Sorce wrote: > I've been thinking about optimizing group enumerations for a while as > they were way too slow for my taste. > > I did that by relying on the way we store users in the database and by > parsing the member attribute of the groups countin

[SSSD] [PATCH] Optimize gorup enumerations

2009-11-17 Thread Simo Sorce
I've been thinking about optimizing group enumerations for a while as they were way too slow for my taste. I did that by relying on the way we store users in the database and by parsing the member attribute of the groups counting on the fact we build the user dn as name=,cn=users, This patch