Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Jakub Hrozek
On Wed, Jul 16, 2014 at 05:19:54PM +0200, Michal Židek wrote: We decided to use $(NULL) at the end of lists in Makefile.am. So you will not change two lines with adding new library next time. see 1746e8b8399da2a7a8da4aace186f66055ccfec1 LS Ok. I added it where I modified the end of the

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Simo Sorce
On Wed, 2014-08-27 at 14:30 +0200, Jakub Hrozek wrote: On Wed, Jul 16, 2014 at 05:19:54PM +0200, Michal Židek wrote: We decided to use $(NULL) at the end of lists in Makefile.am. So you will not change two lines with adding new library next time. see

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Jakub Hrozek
On Wed, Aug 27, 2014 at 08:48:14AM -0400, Simo Sorce wrote: On Wed, 2014-08-27 at 14:30 +0200, Jakub Hrozek wrote: On Wed, Jul 16, 2014 at 05:19:54PM +0200, Michal Židek wrote: We decided to use $(NULL) at the end of lists in Makefile.am. So you will not change two lines with adding

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Simo Sorce
On Wed, 2014-08-27 at 16:47 +0200, Jakub Hrozek wrote: On Wed, Aug 27, 2014 at 08:48:14AM -0400, Simo Sorce wrote: On Wed, 2014-08-27 at 14:30 +0200, Jakub Hrozek wrote: On Wed, Jul 16, 2014 at 05:19:54PM +0200, Michal Židek wrote: We decided to use $(NULL) at the end of lists in

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Lukas Slebodnik
On (27/08/14 16:47), Jakub Hrozek wrote: On Wed, Aug 27, 2014 at 08:48:14AM -0400, Simo Sorce wrote: On Wed, 2014-08-27 at 14:30 +0200, Jakub Hrozek wrote: On Wed, Jul 16, 2014 at 05:19:54PM +0200, Michal Židek wrote: We decided to use $(NULL) at the end of lists in Makefile.am. So you

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Simo Sorce
On Wed, 2014-08-27 at 17:00 +0200, Lukas Slebodnik wrote: On (27/08/14 16:47), Jakub Hrozek wrote: On Wed, Aug 27, 2014 at 08:48:14AM -0400, Simo Sorce wrote: On Wed, 2014-08-27 at 14:30 +0200, Jakub Hrozek wrote: On Wed, Jul 16, 2014 at 05:19:54PM +0200, Michal Židek wrote: We decided

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Lukas Slebodnik
On (27/08/14 11:08), Simo Sorce wrote: On Wed, 2014-08-27 at 17:00 +0200, Lukas Slebodnik wrote: On (27/08/14 16:47), Jakub Hrozek wrote: On Wed, Aug 27, 2014 at 08:48:14AM -0400, Simo Sorce wrote: On Wed, 2014-08-27 at 14:30 +0200, Jakub Hrozek wrote: On Wed, Jul 16, 2014 at 05:19:54PM

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-08-27 Thread Simo Sorce
On Wed, 2014-08-27 at 17:25 +0200, Lukas Slebodnik wrote: On (27/08/14 11:08), Simo Sorce wrote: On Wed, 2014-08-27 at 17:00 +0200, Lukas Slebodnik wrote: On (27/08/14 16:47), Jakub Hrozek wrote: On Wed, Aug 27, 2014 at 08:48:14AM -0400, Simo Sorce wrote: On Wed, 2014-08-27 at 14:30

Re: [SSSD] [PATCH] Use sss_strerror instead of strerror

2014-07-16 Thread Lukas Slebodnik
On (16/07/14 16:37), Michal Židek wrote: On 05/11/2014 11:10 PM, Jakub Hrozek wrote: I haven't tested this patch to be honest, but then again, there's not so much to test except compiling and a bit of sanity testing.. I prefer Michal's version of using sss_strerror explicitly instead of the route