URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
master:
2d527aab0bab0c5323b7ea09c9a8c3820f4f8736
52f45837ded98564968da42229b37db6a36ad627
ead25e32c52c8c2f5fd9abd179e9e81de58f9ca3
82c5971fafe6063a90289ebba08035fc49ae8590
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
On Wed, Feb 22, 2017 at 09:29:02AM -0800, sumit-bose wrote:
> Thank you for the rigid review,
Since the review took so long, it better be good :-)
> I've fixed the comments move some strucht
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
sumit-bose commented:
"""
Thank you for the rigid review, I've fixed the comments move some strucht
members to a previous patch to not break the individual compilation.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
The patches work now, if the three small issues above and the individual
compilation are addressed, I'll ack
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
sumit-bose commented:
"""
Thank you for review and testing. I fixed the issue with changing the expired
password and reordered the patches so that sss_authtok_set_sc is defined before
it is used.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
OK, apart from the issue with the patch compilation, I found one more with
manual testing -- it looks like changing the expired password of a newly
created IPA user is not working correctly.
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
There is a small issue where `sss_authtok_set_sc` is used before it's defined,
which would break bisect.
btw I'm battling a bit with the downstream tests, it looks like saying these
patches
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
sumit-bose commented:
"""
Hi Lukas,
thank you for your comments. I move get_pkinit_identity() out if the ifdef
block. For pam_check_user_done() I removed the assignment which should
hopefully silence the Coverity
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
lslebodn commented:
"""
On (09/02/17 02:50), sumit-bose wrote:
>Thank you for running the tests, the valgirind issue was the same as the last
>coverity warning.
>
The function get_pkinit_identity is defined inside
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
sumit-bose commented:
"""
Thank you for running the tests, the valgirind issue was the same as the last
coverity warning.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/137#issuecomment-278608541
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
pam_srv_test doesn't like being run under valgrind:
http://sssd-ci.duckdns.org/logs/job/61/71/rhel7/ci-build-debug/ci-make-check-valgrind.log
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
jhrozek commented:
"""
There are some Coverity warnings:
```
Error: UNINIT (CWE-457):
sssd-1.15.1/src/p11_child/p11_child_nss.c:112: var_decl: Declaring variable
"key_id_str" without initializer.
12 matches
Mail list logo
