[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 jhrozek commented: """ * master: * e1052a50b9cf42963e0a805a43e295742609693 8 * 4ef0b19a5e8a327443d027e57487c8a1e4f654ce * 180e0b282be6aeb047c4b24b46e0b56afba1fdc8 *

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ Ack. Thank you for your patience. """ See the full comment at https://github.com/SSSD/sssd/pull/246#issuecomment-300441160

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ Patchset updated! """ See the full comment at https://github.com/SSSD/sssd/pull/246#issuecomment-299454749

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ ```c static errno_t cache_req_search_ncache_filter(TALLOC_CTX *mem_ctx, struct cache_req *cr,

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ ```c static errno_t cache_req_search_ncache_filter(TALLOC_CTX *mem_ctx, struct cache_req *cr,

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ * **CACHE_REQ: Add a new cache_req_ncache_filter_fn() plugin function** ```c /** + * Filter the result through the negative cache. + * + * This is

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ And I started a CI build ... """ See the full comment at https://github.com/SSSD/sssd/pull/246#issuecomment-297916257

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ Okay, patchset update and using directly the name we get from the message (which is the internal fqname). It does work for the bug report and it

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 jhrozek commented: """ On Thu, Apr 27, 2017 at 04:57:02AM -0700, Pavel Březina wrote: > > One thing that is not exactly clear to me (and I may need your guidance) is > > ...

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ > One thing that is not exactly clear to me (and I may need your guidance) is > ... just getting the name from the DB is not enough to the the >

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Thu, Apr 27, 2017 at 1:29 PM, Fabiano Fidêncio wrote: > > > On Thu, Apr 27, 2017 at 1:26 PM, Pavel Březina

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Thu, Apr 27, 2017 at 1:26 PM, Pavel Březina wrote: > *@pbrezina* requested changes on this pull request. >

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ patchset updated. """ See the full comment at https://github.com/SSSD/sssd/pull/246#issuecomment-297677084

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ > But there's no memory involved at all on sss_get_name_from_msg(). I'll follow > you suggestion and update the PR anyways. Yes, that means if

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ > But there's no memory involved at all on sss_get_name_from_msg(). I'll follow > you suggestion and update the PR anyways. Yes, that means if

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Thu, Apr 27, 2017 at 10:53 AM, Pavel Březina wrote: > What do we want to do in this case? It would fail with EINVAL later

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ > What do we want to do in this case? It would fail with EINVAL later on when > filling the grent/pwent anyways, no? That comment should said

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Wed, Apr 26, 2017 at 6:34 PM, Fabiano Fidêncio wrote: > > > On Wed, Apr 26, 2017 at 11:34 AM, Pavel Březina

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Wed, Apr 26, 2017 at 11:34 AM, Pavel Březina wrote: > >- > >*NSS: Use fqnames when performing a ncache check* >

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Wed, Apr 26, 2017 at 11:34 AM, Pavel Březina wrote: > >- > >*NSS: Use fqnames when performing a ncache check* >

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ * **NSS: Use fqnames when performing a ncache check** This should be done in the ncache module, not in the callers. * **RESPONDER: Make

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ * **NSS: Use fqnames when performing a ncache check** This should be done in the ncache module, not in the callers. * **RESPONDER: Make

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ New patch set pushed and in the end the changes were not intrusive at all. @pbrezina, I've partially taken your idea (with some changes). Please, let

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 lslebodn commented: """ On (25/04/17 03:59), fidencio wrote: >On Tue, Apr 25, 2017 at 12:16 PM, Pavel Březina >wrote: > >> Hi, we should solve this

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Tue, Apr 25, 2017 at 12:16 PM, Pavel Březina wrote: > Hi, we should solve this on cache_req level so we get the same

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ This is really from top of my mind, there may be another, easier way to do it. But we should do it on cache_req level. """ See the full comment at

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ Hi, we should solve this on `cache_req` level so we get the same resultt in `nss` and `ifp` (and others) responders. What I had in mind was to create